| Message ID | 20210513114617.30191-2-aford173@gmail.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | ebc666f39ff67a01e748c34d670ddf05a9e45220 |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | [1/3] arm64: dts: renesas: beacon: Fix USB extal reference | expand |
Hi Adam, Thanks for your patch! On Thu, May 13, 2021 at 1:46 PM Adam Ford <aford173@gmail.com> wrote: > The RZ/G2 boards expect there to be a external clock reference for an > USB2 EHCI controllers. For the Beacon boards, this reference clock > is controlled by a programmable verasaclock. Because the RZ/G2 versaclock > family have a special clock driver when using an external clock, has > the third clock reference in the EHCI node needs to point to this > special clock, called usb2_clksel. > > Since the usb2_clksel does not keep the usb_extal clock enabled, > the 4th clock entry for the EHCI nodes needs to reference it to > keep the clock running and make USB functional. > > Signed-off-by: Adam Ford <aford173@gmail.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-devel for v5.14, with the above fixed. Gr{oetje,eeting}s, Geert
diff --git a/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi b/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi index d8046fedf9c1..e3c8b2fe143e 100644 --- a/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi +++ b/arch/arm64/boot/dts/renesas/beacon-renesom-baseboard.dtsi @@ -271,12 +271,12 @@ &ehci0 { dr_mode = "otg"; status = "okay"; - clocks = <&cpg CPG_MOD 703>, <&cpg CPG_MOD 704>; + clocks = <&cpg CPG_MOD 703>, <&cpg CPG_MOD 704>, <&usb2_clksel>, <&versaclock5 3>; }; &ehci1 { status = "okay"; - clocks = <&cpg CPG_MOD 703>, <&cpg CPG_MOD 704>; + clocks = <&cpg CPG_MOD 703>, <&cpg CPG_MOD 704>, <&usb2_clksel>, <&versaclock5 3>; }; &hdmi0 {
The RZ/G2 boards expect there to be a external clock reference for USB2 EHCI controllers. For the Beacon boards, this reference clock is controlled by a programmable verasaclock. Because the RZ/G2 family have a special clock driver when using an external clock, the third clock reference in the EHCI node needs to point to this special clock, called usb2_clksel. Since the usb2_clksel does not keep the usb_extal clock enabled, the 4th clock entry for the EHCI nodes needs to reference it to keep the clock running and make USB functional. Signed-off-by: Adam Ford <aford173@gmail.com>