| Message ID | 1621318822-29332-5-git-send-email-skakit@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add PMIC DT files for sc7280 | expand |
On 18-05-21, 11:50, satya priya wrote: > Add temp-alarm node for PM8350C pmic and also modify gpio > node to add gpio ranges and "qcom,spmi-gpio" compatible. These should be two patches explaining why things are done like that > > Signed-off-by: satya priya <skakit@codeaurora.org> > Reviewed-by: Matthias Kaehlcke <mka@chromium.org> > --- > Changes in RESEND V4: > - No Changes. > > arch/arm64/boot/dts/qcom/pm8350c.dtsi | 32 +++++++++++++++++++++++++++++++- > 1 file changed, 31 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi b/arch/arm64/boot/dts/qcom/pm8350c.dtsi > index 2b9b75e..e1b75ae 100644 > --- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi > +++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi > @@ -13,13 +13,43 @@ > #address-cells = <1>; > #size-cells = <0>; > > + pm8350c_temp_alarm: temp-alarm@a00 { > + compatible = "qcom,spmi-temp-alarm"; > + reg = <0xa00>; > + interrupts = <0x2 0xa 0x0 IRQ_TYPE_EDGE_BOTH>; > + #thermal-sensor-cells = <0>; > + }; > + > pm8350c_gpios: gpio@8800 { > - compatible = "qcom,pm8350c-gpio"; > + compatible = "qcom,pm8350c-gpio", "qcom,spmi-gpio"; why is this changed? > reg = <0x8800>; > gpio-controller; > + gpio-ranges = <&pm8350c_gpios 0 0 9>; > #gpio-cells = <2>; > interrupt-controller; > #interrupt-cells = <2>; > }; > }; > }; > + > +&thermal_zones { > + pm8350c_thermal: pm8350c-thermal { > + polling-delay-passive = <100>; > + polling-delay = <0>; > + thermal-sensors = <&pm8350c_temp_alarm>; > + > + trips { > + pm8350c_trip0: trip0 { > + temperature = <95000>; > + hysteresis = <0>; > + type = "passive"; > + }; > + > + pm8350c_crit: pm8350c-crit { > + temperature = <115000>; > + hysteresis = <0>; > + type = "critical"; > + }; > + }; > + }; > +}; > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation
On 2021-05-18 17:18, Vinod Koul wrote: > On 18-05-21, 11:50, satya priya wrote: >> Add temp-alarm node for PM8350C pmic and also modify gpio >> node to add gpio ranges and "qcom,spmi-gpio" compatible. > > These should be two patches explaining why things are done like that > Okay, will split them. >> >> Signed-off-by: satya priya <skakit@codeaurora.org> >> Reviewed-by: Matthias Kaehlcke <mka@chromium.org> >> --- >> Changes in RESEND V4: >> - No Changes. >> >> arch/arm64/boot/dts/qcom/pm8350c.dtsi | 32 >> +++++++++++++++++++++++++++++++- >> 1 file changed, 31 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi >> b/arch/arm64/boot/dts/qcom/pm8350c.dtsi >> index 2b9b75e..e1b75ae 100644 >> --- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi >> +++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi >> @@ -13,13 +13,43 @@ >> #address-cells = <1>; >> #size-cells = <0>; >> >> + pm8350c_temp_alarm: temp-alarm@a00 { >> + compatible = "qcom,spmi-temp-alarm"; >> + reg = <0xa00>; >> + interrupts = <0x2 0xa 0x0 IRQ_TYPE_EDGE_BOTH>; >> + #thermal-sensor-cells = <0>; >> + }; >> + >> pm8350c_gpios: gpio@8800 { >> - compatible = "qcom,pm8350c-gpio"; >> + compatible = "qcom,pm8350c-gpio", "qcom,spmi-gpio"; > > why is this changed? As per the Documentation[1], either "qcom,spmi-gpio" or "qcom,ssbi-gpio" must be added based on whether the device is on an spmi bus or an ssbi bus respectively. [1] https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/pinctrl/qcom%2Cpmic-gpio.txt#L41 > >> reg = <0x8800>; >> gpio-controller; >> + gpio-ranges = <&pm8350c_gpios 0 0 9>; >> #gpio-cells = <2>; >> interrupt-controller; >> #interrupt-cells = <2>; >> }; >> }; >> }; >> + >> +&thermal_zones { >> + pm8350c_thermal: pm8350c-thermal { >> + polling-delay-passive = <100>; >> + polling-delay = <0>; >> + thermal-sensors = <&pm8350c_temp_alarm>; >> + >> + trips { >> + pm8350c_trip0: trip0 { >> + temperature = <95000>; >> + hysteresis = <0>; >> + type = "passive"; >> + }; >> + >> + pm8350c_crit: pm8350c-crit { >> + temperature = <115000>; >> + hysteresis = <0>; >> + type = "critical"; >> + }; >> + }; >> + }; >> +}; >> -- >> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a >> member >> of Code Aurora Forum, hosted by The Linux Foundation
diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi b/arch/arm64/boot/dts/qcom/pm8350c.dtsi index 2b9b75e..e1b75ae 100644 --- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi +++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi @@ -13,13 +13,43 @@ #address-cells = <1>; #size-cells = <0>; + pm8350c_temp_alarm: temp-alarm@a00 { + compatible = "qcom,spmi-temp-alarm"; + reg = <0xa00>; + interrupts = <0x2 0xa 0x0 IRQ_TYPE_EDGE_BOTH>; + #thermal-sensor-cells = <0>; + }; + pm8350c_gpios: gpio@8800 { - compatible = "qcom,pm8350c-gpio"; + compatible = "qcom,pm8350c-gpio", "qcom,spmi-gpio"; reg = <0x8800>; gpio-controller; + gpio-ranges = <&pm8350c_gpios 0 0 9>; #gpio-cells = <2>; interrupt-controller; #interrupt-cells = <2>; }; }; }; + +&thermal_zones { + pm8350c_thermal: pm8350c-thermal { + polling-delay-passive = <100>; + polling-delay = <0>; + thermal-sensors = <&pm8350c_temp_alarm>; + + trips { + pm8350c_trip0: trip0 { + temperature = <95000>; + hysteresis = <0>; + type = "passive"; + }; + + pm8350c_crit: pm8350c-crit { + temperature = <115000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; +};