diff mbox series

[1/2] clk: renesas: cpg-mssr: Remove unused [RM]MSTPCR() definitions

Message ID 2d8bc4d9806b419ebb06030d2f31b2ea1e59b1d6.1620119700.git.geert+renesas@glider.be (mailing list archive)
State Accepted
Delegated to: Geert Uytterhoeven
Headers show
Series clk: renesas: cpg-mssr: Small cleaups | expand

Commit Message

Geert Uytterhoeven May 4, 2021, 9:17 a.m. UTC
The Realtime Module Stop Control Register definitions (RMSTPCR(i)) are
incorrect for i >= 8 on R-Car Gen2 and Gen3.

As these are unused, and not planned to be used, just like the
corresponding Modem Module Stop Control Register definitions (MMSTPCR())
on R-Mobile APE6 (they are intended for the software running on the
Real-Time and Modem CPU cores), they can just be removed.

Reported-by: Hai Nguyen Pham <hai.pham.ud@renesas.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/clk/renesas/renesas-cpg-mssr.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Stephen Boyd May 26, 2021, 3:17 a.m. UTC | #1
Quoting Geert Uytterhoeven (2021-05-04 02:17:21)
> The Realtime Module Stop Control Register definitions (RMSTPCR(i)) are
> incorrect for i >= 8 on R-Car Gen2 and Gen3.
> 
> As these are unused, and not planned to be used, just like the
> corresponding Modem Module Stop Control Register definitions (MMSTPCR())
> on R-Mobile APE6 (they are intended for the software running on the
> Real-Time and Modem CPU cores), they can just be removed.
> 
> Reported-by: Hai Nguyen Pham <hai.pham.ud@renesas.com>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---

Acked-by: Stephen Boyd <sboyd@kernel.org>
diff mbox series

Patch

diff --git a/drivers/clk/renesas/renesas-cpg-mssr.c b/drivers/clk/renesas/renesas-cpg-mssr.c
index fc531d35b269d3cd..c3230398e1c1b596 100644
--- a/drivers/clk/renesas/renesas-cpg-mssr.c
+++ b/drivers/clk/renesas/renesas-cpg-mssr.c
@@ -100,12 +100,6 @@  static const u16 srcr_for_v3u[] = {
 	0x2C20, 0x2C24, 0x2C28, 0x2C2C, 0x2C30, 0x2C34, 0x2C38,
 };
 
-/* Realtime Module Stop Control Register offsets */
-#define RMSTPCR(i)	(smstpcr[i] - 0x20)
-
-/* Modem Module Stop Control Register offsets (r8a73a4) */
-#define MMSTPCR(i)	(smstpcr[i] + 0x20)
-
 /* Software Reset Clearing Register offsets */
 
 static const u16 srstclr[] = {