| Message ID | 1622024648-33438-1-git-send-email-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Deferred |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | drivers/net/sungem: Fix inconsistent indenting | expand |
| Context | Check | Description |
|---|---|---|
| netdev/cover_letter | success | Link |
| netdev/fixes_present | success | Link |
| netdev/patch_count | success | Link |
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/subject_prefix | warning | Target tree name not specified in the subject |
| netdev/cc_maintainers | success | CCed 3 of 3 maintainers |
| netdev/source_inline | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Link |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/verify_fixes | success | Link |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/header_inline | success | Link |
On Wed, 26 May 2021 18:24:08 +0800 Jiapeng Chong wrote: > Eliminate the follow smatch warning: > > drivers/net/sungem_phy.c:412 genmii_read_link() warn: inconsistent > indenting. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > drivers/net/sungem_phy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/sungem_phy.c b/drivers/net/sungem_phy.c > index 291fa44..4daac5f 100644 > --- a/drivers/net/sungem_phy.c > +++ b/drivers/net/sungem_phy.c > @@ -409,7 +409,7 @@ static int genmii_read_link(struct mii_phy *phy) > * though magic-aneg shouldn't prevent this case from occurring > */ > > - return 0; > + return 0; > } > > static int generic_suspend(struct mii_phy* phy) Do you have any statistics on how many such patches we'd need to apply to make the kernel free for such warning? If it's too many it's probably not worth it, this patch for example has net zero effect on readability.
diff --git a/drivers/net/sungem_phy.c b/drivers/net/sungem_phy.c index 291fa44..4daac5f 100644 --- a/drivers/net/sungem_phy.c +++ b/drivers/net/sungem_phy.c @@ -409,7 +409,7 @@ static int genmii_read_link(struct mii_phy *phy) * though magic-aneg shouldn't prevent this case from occurring */ - return 0; + return 0; } static int generic_suspend(struct mii_phy* phy)
Eliminate the follow smatch warning: drivers/net/sungem_phy.c:412 genmii_read_link() warn: inconsistent indenting. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/net/sungem_phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)