| Message ID | 20210324231424.2890039-1-swboyd@chromium.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c0dcfe6a784fdf7fcc0fdc74bfbb06e9f77de964 |
| Headers | show |
| Series | [v2] arm64: dts: qcom: c630: Add no-hpd to DSI bridge node | expand |
Hi, On Wed, Mar 24, 2021 at 4:14 PM Stephen Boyd <swboyd@chromium.org> wrote: > > We should indicate that we're not using the HPD pin on this device, per > the binding document. Otherwise if code in the future wants to enable > HPD in the bridge when this property is absent we'll be enabling HPD > when it isn't supposed to be used. Presumably this board isn't using hpd > on the bridge. > > Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > Cc: Douglas Anderson <dianders@chromium.org> > Cc: Steev Klimaszewski <steev@kali.org> > Fixes: 956e9c85f47b ("arm64: dts: qcom: c630: Define eDP bridge and panel") > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- > arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Douglas Anderson <dianders@chromium.org>
Hello: This patch was applied to qcom/linux.git (refs/heads/for-next): On Wed, 24 Mar 2021 16:14:24 -0700 you wrote: > We should indicate that we're not using the HPD pin on this device, per > the binding document. Otherwise if code in the future wants to enable > HPD in the bridge when this property is absent we'll be enabling HPD > when it isn't supposed to be used. Presumably this board isn't using hpd > on the bridge. > > Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > Cc: Douglas Anderson <dianders@chromium.org> > Cc: Steev Klimaszewski <steev@kali.org> > Fixes: 956e9c85f47b ("arm64: dts: qcom: c630: Define eDP bridge and panel") > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > > [...] Here is the summary with links: - [v2] arm64: dts: qcom: c630: Add no-hpd to DSI bridge node https://git.kernel.org/qcom/c/c0dcfe6a784f You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts index 140db2d5ba31..c2a709a384e9 100644 --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts @@ -376,6 +376,8 @@ sn65dsi86: bridge@2c { clocks = <&sn65dsi86_refclk>; clock-names = "refclk"; + no-hpd; + ports { #address-cells = <1>; #size-cells = <0>;
We should indicate that we're not using the HPD pin on this device, per the binding document. Otherwise if code in the future wants to enable HPD in the bridge when this property is absent we'll be enabling HPD when it isn't supposed to be used. Presumably this board isn't using hpd on the bridge. Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Cc: Douglas Anderson <dianders@chromium.org> Cc: Steev Klimaszewski <steev@kali.org> Fixes: 956e9c85f47b ("arm64: dts: qcom: c630: Define eDP bridge and panel") Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 2 ++ 1 file changed, 2 insertions(+)