diff mbox series

[2/2] perf: qcom_l2_pmu: move to use request_irq by IRQF_NO_AUTOEN flag

Message ID 1622595642-61678-3-git-send-email-tiantao6@hisilicon.com (mailing list archive)
State Not Applicable, archived
Headers show
Series move to use request_irq by IRQF_NO_AUTOEN flag | expand

Commit Message

Tian Tao June 2, 2021, 1 a.m. UTC
request_irq() after setting IRQ_NOAUTOEN as below
irq_set_status_flags(irq, IRQ_NOAUTOEN); request_irq(dev, irq...); can
be replaced by request_irq() with IRQF_NO_AUTOEN flag.

this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which
is being merged: https://lore.kernel.org/patchwork/patch/1388765/

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
 drivers/perf/qcom_l2_pmu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Mark Rutland June 2, 2021, 10:16 a.m. UTC | #1
On Wed, Jun 02, 2021 at 09:00:42AM +0800, Tian Tao wrote:
> request_irq() after setting IRQ_NOAUTOEN as below
> irq_set_status_flags(irq, IRQ_NOAUTOEN); request_irq(dev, irq...); can
> be replaced by request_irq() with IRQF_NO_AUTOEN flag.
> 
> this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which
> is being merged: https://lore.kernel.org/patchwork/patch/1388765/
> 
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>

As with patch 1, I see that the patch above was merged in v5.13-rc1 as commit:

  cbe16f35bee6880b ("genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()")

With that in mind:

Acked-by: Mark Rutland <mark.rutland@arm.com>

I expect Will will pick this up.

Thanks,
Mark.

> ---
>  drivers/perf/qcom_l2_pmu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/perf/qcom_l2_pmu.c b/drivers/perf/qcom_l2_pmu.c
> index fc54a80..b60e301 100644
> --- a/drivers/perf/qcom_l2_pmu.c
> +++ b/drivers/perf/qcom_l2_pmu.c
> @@ -869,14 +869,14 @@ static int l2_cache_pmu_probe_cluster(struct device *dev, void *data)
>  	irq = platform_get_irq(sdev, 0);
>  	if (irq < 0)
>  		return irq;
> -	irq_set_status_flags(irq, IRQ_NOAUTOEN);
>  	cluster->irq = irq;
>  
>  	cluster->l2cache_pmu = l2cache_pmu;
>  	cluster->on_cpu = -1;
>  
>  	err = devm_request_irq(&pdev->dev, irq, l2_cache_handle_irq,
> -			       IRQF_NOBALANCING | IRQF_NO_THREAD,
> +			       IRQF_NOBALANCING | IRQF_NO_THREAD |
> +			       IRQF_NO_AUTOEN,
>  			       "l2-cache-pmu", cluster);
>  	if (err) {
>  		dev_err(&pdev->dev,
> -- 
> 2.7.4
>
diff mbox series

Patch

diff --git a/drivers/perf/qcom_l2_pmu.c b/drivers/perf/qcom_l2_pmu.c
index fc54a80..b60e301 100644
--- a/drivers/perf/qcom_l2_pmu.c
+++ b/drivers/perf/qcom_l2_pmu.c
@@ -869,14 +869,14 @@  static int l2_cache_pmu_probe_cluster(struct device *dev, void *data)
 	irq = platform_get_irq(sdev, 0);
 	if (irq < 0)
 		return irq;
-	irq_set_status_flags(irq, IRQ_NOAUTOEN);
 	cluster->irq = irq;
 
 	cluster->l2cache_pmu = l2cache_pmu;
 	cluster->on_cpu = -1;
 
 	err = devm_request_irq(&pdev->dev, irq, l2_cache_handle_irq,
-			       IRQF_NOBALANCING | IRQF_NO_THREAD,
+			       IRQF_NOBALANCING | IRQF_NO_THREAD |
+			       IRQF_NO_AUTOEN,
 			       "l2-cache-pmu", cluster);
 	if (err) {
 		dev_err(&pdev->dev,