| Message ID | 20210607221543.254144-1-kamalheib1@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | [for-next] RDMA/irdma: Fix return error sign from irdma_modify_qp | expand |
> Subject: [PATCH for-next] RDMA/irdma: Fix return error sign from > irdma_modify_qp > > There is a typo in the returned error code sign from irdma_modify_qp() when the > attr_mask is not supported - Fix it. > > Fixes: b48c24c2d710 ("RDMA/irdma: Implement device supported verb APIs") > Signed-off-by: Kamal Heib <kamalheib1@gmail.com> > --- > drivers/infiniband/hw/irdma/verbs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/irdma/verbs.c b/drivers/infiniband/hw/irdma/verbs.c > index 294155293243..154ca25e7e32 100644 > --- a/drivers/infiniband/hw/irdma/verbs.c > +++ b/drivers/infiniband/hw/irdma/verbs.c > @@ -1472,7 +1472,7 @@ int irdma_modify_qp(struct ib_qp *ibqp, struct > ib_qp_attr *attr, int attr_mask, > unsigned long flags; > > if (attr_mask & ~IB_QP_ATTR_STANDARD_BITS) > - return ~EOPNOTSUPP; > + return -EOPNOTSUPP; > Oops. That's a bad one. Thanks! Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
On Tue, Jun 08, 2021 at 01:15:43AM +0300, Kamal Heib wrote: > There is a typo in the returned error code sign from irdma_modify_qp() > when the attr_mask is not supported - Fix it. > > Fixes: b48c24c2d710 ("RDMA/irdma: Implement device supported verb APIs") > Signed-off-by: Kamal Heib <kamalheib1@gmail.com> > Acked-by: Shiraz Saleem <shiraz.saleem@intel.com> > --- > drivers/infiniband/hw/irdma/verbs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to for-next, thanks Jason
diff --git a/drivers/infiniband/hw/irdma/verbs.c b/drivers/infiniband/hw/irdma/verbs.c index 294155293243..154ca25e7e32 100644 --- a/drivers/infiniband/hw/irdma/verbs.c +++ b/drivers/infiniband/hw/irdma/verbs.c @@ -1472,7 +1472,7 @@ int irdma_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr, int attr_mask, unsigned long flags; if (attr_mask & ~IB_QP_ATTR_STANDARD_BITS) - return ~EOPNOTSUPP; + return -EOPNOTSUPP; ctx_info = &iwqp->ctx_info; offload_info = &iwqp->iwarp_info;
There is a typo in the returned error code sign from irdma_modify_qp() when the attr_mask is not supported - Fix it. Fixes: b48c24c2d710 ("RDMA/irdma: Implement device supported verb APIs") Signed-off-by: Kamal Heib <kamalheib1@gmail.com> --- drivers/infiniband/hw/irdma/verbs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)