| Message ID | 20210609140335.14425-1-thunder.leizhen@huawei.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [1/1] irqchip/exynos-combiner: remove unnecessary oom message | expand |
On 09/06/2021 16:03, Zhen Lei wrote: > Fixes scripts/checkpatch.pl warning: > WARNING: Possible unnecessary 'out of memory' message > > Remove it can help us save a bit of memory. > > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> > --- > drivers/irqchip/exynos-combiner.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/irqchip/exynos-combiner.c b/drivers/irqchip/exynos-combiner.c > index 14106126cbf3262..552aa04ff063123 100644 > --- a/drivers/irqchip/exynos-combiner.c > +++ b/drivers/irqchip/exynos-combiner.c > @@ -177,10 +177,8 @@ static void __init combiner_init(void __iomem *combiner_base, > nr_irq = max_nr * IRQ_IN_COMBINER; > > combiner_data = kcalloc(max_nr, sizeof (*combiner_data), GFP_KERNEL); > - if (!combiner_data) { > - pr_warn("%s: could not allocate combiner data\n", __func__); > + if (!combiner_data) > return; > - } > > combiner_irq_domain = irq_domain_add_linear(np, nr_irq, > &combiner_irq_domain_ops, combiner_data); > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Best regards, Krzysztof
diff --git a/drivers/irqchip/exynos-combiner.c b/drivers/irqchip/exynos-combiner.c index 14106126cbf3262..552aa04ff063123 100644 --- a/drivers/irqchip/exynos-combiner.c +++ b/drivers/irqchip/exynos-combiner.c @@ -177,10 +177,8 @@ static void __init combiner_init(void __iomem *combiner_base, nr_irq = max_nr * IRQ_IN_COMBINER; combiner_data = kcalloc(max_nr, sizeof (*combiner_data), GFP_KERNEL); - if (!combiner_data) { - pr_warn("%s: could not allocate combiner data\n", __func__); + if (!combiner_data) return; - } combiner_irq_domain = irq_domain_add_linear(np, nr_irq, &combiner_irq_domain_ops, combiner_data);
Fixes scripts/checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message Remove it can help us save a bit of memory. Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> --- drivers/irqchip/exynos-combiner.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)