[-V8,00/10] Migrate Pages in lieu of discard

Message

Huang, Ying June 18, 2021, 6:15 a.m. UTC

The full series is also available here:

	https://github.com/hying-caritas/linux/tree/automigrate-20210618

The changes since the last post are as follows,

 * Change the page allocation flags per Michal's comments.
 * Change the user interface to enable the feature.

--

We're starting to see systems with more and more kinds of memory such
as Intel's implementation of persistent memory.

Let's say you have a system with some DRAM and some persistent memory.
Today, once DRAM fills up, reclaim will start and some of the DRAM
contents will be thrown out.  Allocations will, at some point, start
falling over to the slower persistent memory.

That has two nasty properties.  First, the newer allocations can end
up in the slower persistent memory.  Second, reclaimed data in DRAM
are just discarded even if there are gobs of space in persistent
memory that could be used.

This set implements a solution to these problems.  At the end of the
reclaim process in shrink_page_list() just before the last page
refcount is dropped, the page is migrated to persistent memory instead
of being dropped.

While I've talked about a DRAM/PMEM pairing, this approach would
function in any environment where memory tiers exist.

This is not perfect.  It "strands" pages in slower memory and never
brings them back to fast DRAM.  Huang Ying has follow-on work which
repurposes autonuma to promote hot pages back to DRAM.

This is also all based on an upstream mechanism that allows
persistent memory to be onlined and used as if it were volatile:

	http://lkml.kernel.org/r/[e-mail]

We have tested the patchset with the postgresql and pgbench.  On a
2-socket server machine with DRAM and PMEM, the kernel with the
patchset can improve the score of pgbench up to 22.1% compared with
that of the DRAM only + disk case.  This comes from the reduced disk
read throughput (which reduces up to 70.8%).

== Open Issues ==

 * Memory policies and cpusets that, for instance, restrict allocations
   to DRAM can be demoted to PMEM whenever they opt in to this
   new mechanism.  A cgroup-level API to opt-in or opt-out of
   these migrations will likely be required as a follow-on.
 * Could be more aggressive about where anon LRU scanning occurs
   since it no longer necessarily involves I/O.  get_scan_count()
   for instance says: "If we have no swap space, do not bother
   scanning anon pages"

--

Changes since (automigrate-20210331):
 * Change the page allocation flags per Michal's comments.
 * Change the user interface to enable the feature.

Changes since (automigrate-20210304):
 * Add ack/review tags
 * Remove duplicate synchronize_rcu() call

Changes since (automigrate-20210122):
 * move from GFP_HIGHUSER -> GFP_HIGHUSER_MOVABLE since pages *are*
   movable.
 * Separate out helpers that check for being able to relaim anonymous
   pages versus being able to meaningfully scan the anon LRU.

Changes since (automigrate-20200818):
 * Fall back to normal reclaim when demotion fails
 * Fix some compile issues, when page migration and NUMA are off

Changes since (automigrate-20201007):
 * separate out checks for "can scan anon LRU" from "can actually
   swap anon pages right now".  Previous series conflated them
   and may have been overly aggressive scanning LRU
 * add MR_DEMOTION to tracepoint header
 * remove unnecessary hugetlb page check

Changes since (https://lwn.net/Articles/824830/):
 * Use higher-level migrate_pages() API approach from Yang Shi's
   earlier patches.
 * made sure to actually check node_reclaim_mode's new bit
 * disabled migration entirely before introducing RECLAIM_MIGRATE
 * Replace GFP_NOWAIT with explicit __GFP_KSWAPD_RECLAIM and
   comment why we want that.
 * Comment on effects of that keep multiple source nodes from
   sharing target nodes

Cc: Dave Hansen <[e-mail]>
Cc: Michal Hocko <[e-mail]>
Cc: Yang Shi <[e-mail]>
Cc: David Rientjes <[e-mail]>
Cc: Dan Williams <[e-mail]>
Cc: David Hildenbrand <[e-mail]>
Cc: osalvador <[e-mail]>
Cc: Wei Xu <[e-mail]>

Comments

Oscar Salvador June 22, 2021, 9 a.m. UTC | #1

On Fri, Jun 18, 2021 at 02:15:27PM +0800, Huang Ying wrote:
> The full series is also available here:
> 
> 	https://github.com/hying-caritas/linux/tree/automigrate-20210618
> 
> The changes since the last post are as follows,
> 
>  * Change the page allocation flags per Michal's comments.
>  * Change the user interface to enable the feature.

Hi Huang Ying,

I would suggest going back to [1] and revisit the feedback provided in v7,
as it seemed you ignored (probably not intentionally) some of the provided
comments.

Thanks

Huang, Ying June 23, 2021, 1:12 a.m. UTC | #2

Oscar Salvador <[e-mail]> writes:

> On Fri, Jun 18, 2021 at 02:15:27PM +0800, Huang Ying wrote:
>> The full series is also available here:
>> 
>> 	https://github.com/hying-caritas/linux/tree/automigrate-20210618
>> 
>> The changes since the last post are as follows,
>> 
>>  * Change the page allocation flags per Michal's comments.
>>  * Change the user interface to enable the feature.
>
> Hi Huang Ying,
>
> I would suggest going back to [1] and revisit the feedback provided in v7,
> as it seemed you ignored (probably not intentionally) some of the provided
> comments.

Hi, Oscar,

I am really sorry about that.  It's my fault forgetting reviewing all
comments for v7.  All your comments are valuable for me, it's not my
intention to ignore them.  I will be more careful in the future.  Thanks
a lot for your reminding.

Best Regards,
Huang, Ying