| Message ID | 1624363243-12306-1-git-send-email-liweihang@huawei.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [for-next] RDMA/hns: Fix incorrect lsn field | expand |
On 2021/6/22 20:01, liweihang wrote: > From: Yixing Liu <liuyixing1@huawei.com> > > In RNR NAK screnario, according to the specification, when no credit is > available, only the first fragment of the send request can be sent. The > LSN(Limit Sequence Number) field should be 0 or the entire packet will be > resent. > > Fixes: f0cb411aad23 ("RDMA/hns: Use new interface to modify QP context") > Signed-off-by: Yixing Liu <liuyixing1@huawei.com> > Signed-off-by: Weihang Li <liweihang@huawei.com> > --- > drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c > index 069c7cd..7da2a74 100644 > --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c > +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c > @@ -4515,7 +4515,6 @@ static int modify_qp_rtr_to_rts(struct ib_qp *ibqp, > > hr_reg_clear(qpc_mask, QPC_CHECK_FLG); > > - hr_reg_write(context, QPC_LSN, 0x100); > hr_reg_clear(qpc_mask, QPC_LSN); > This hr_reg_clear() is redundant and needs to be removed. I will resend this patch. Weihang > hr_reg_clear(qpc_mask, QPC_V2_IRRL_HEAD); >
diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c index 069c7cd..7da2a74 100644 --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c @@ -4515,7 +4515,6 @@ static int modify_qp_rtr_to_rts(struct ib_qp *ibqp, hr_reg_clear(qpc_mask, QPC_CHECK_FLG); - hr_reg_write(context, QPC_LSN, 0x100); hr_reg_clear(qpc_mask, QPC_LSN); hr_reg_clear(qpc_mask, QPC_V2_IRRL_HEAD);