| Message ID | 1625915095-23077-1-git-send-email-stefan.wahren@i2se.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ab37a7a890c1176144a4c66ff3d51ef2c20ed486 |
| Headers | show |
| Series | ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in | expand |
On 7/10/2021 4:04 AM, Stefan Wahren wrote: > The usage of usb-nop-xceiv PHY on Raspberry Pi boards with BCM283x has > been a "regression source" a lot of times. The last case is breakage of > USB mass storage boot has been commit e590474768f1 ("driver core: Set > fw_devlink=on by default") for multi_v7_defconfig. As long as > NOP_USB_XCEIV is configured as module, the dwc2 USB driver defer probing > endlessly and prevent booting from USB mass storage device. So make > the driver built-in as in bcm2835_defconfig and arm64/defconfig. Should not that be fixed somehow? > > Reported-by: Ojaswin Mujoo <ojaswin98@gmail.com> > Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> > --- > arch/arm/configs/multi_v7_defconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig > index 52a0400..d9abaae 100644 > --- a/arch/arm/configs/multi_v7_defconfig > +++ b/arch/arm/configs/multi_v7_defconfig > @@ -821,7 +821,7 @@ CONFIG_USB_ISP1760=y > CONFIG_USB_HSIC_USB3503=y > CONFIG_AB8500_USB=y > CONFIG_KEYSTONE_USB_PHY=m > -CONFIG_NOP_USB_XCEIV=m > +CONFIG_NOP_USB_XCEIV=y > CONFIG_AM335X_PHY_USB=m > CONFIG_TWL6030_USB=m > CONFIG_USB_GPIO_VBUS=y >
Hi Florian, Am 11.07.21 um 23:27 schrieb Florian Fainelli: > > > On 7/10/2021 4:04 AM, Stefan Wahren wrote: >> The usage of usb-nop-xceiv PHY on Raspberry Pi boards with BCM283x has >> been a "regression source" a lot of times. The last case is breakage of >> USB mass storage boot has been commit e590474768f1 ("driver core: Set >> fw_devlink=on by default") for multi_v7_defconfig. As long as >> NOP_USB_XCEIV is configured as module, the dwc2 USB driver defer probing >> endlessly and prevent booting from USB mass storage device. So make >> the driver built-in as in bcm2835_defconfig and arm64/defconfig. > > Should not that be fixed somehow? maybe that why send this bug report, but never get a feedback [1] My spare time is too limited to fight multiple regressions on Raspberry Pi, so i decided send at least this solution. [1] - https://www.spinics.net/lists/arm-kernel/msg905208.html > >> >> Reported-by: Ojaswin Mujoo <ojaswin98@gmail.com> >> Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") >> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> >> ---
Hello: This patch was applied to soc/soc.git (refs/heads/arm/fixes): On Sat, 10 Jul 2021 13:04:55 +0200 you wrote: > The usage of usb-nop-xceiv PHY on Raspberry Pi boards with BCM283x has > been a "regression source" a lot of times. The last case is breakage of > USB mass storage boot has been commit e590474768f1 ("driver core: Set > fw_devlink=on by default") for multi_v7_defconfig. As long as > NOP_USB_XCEIV is configured as module, the dwc2 USB driver defer probing > endlessly and prevent booting from USB mass storage device. So make > the driver built-in as in bcm2835_defconfig and arm64/defconfig. > > [...] Here is the summary with links: - ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in https://git.kernel.org/soc/soc/c/ab37a7a890c1 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
From: Arnd Bergmann <arnd@arndb.de> On Sat, 10 Jul 2021 13:04:55 +0200, Stefan Wahren wrote: > The usage of usb-nop-xceiv PHY on Raspberry Pi boards with BCM283x has > been a "regression source" a lot of times. The last case is breakage of > USB mass storage boot has been commit e590474768f1 ("driver core: Set > fw_devlink=on by default") for multi_v7_defconfig. As long as > NOP_USB_XCEIV is configured as module, the dwc2 USB driver defer probing > endlessly and prevent booting from USB mass storage device. So make > the driver built-in as in bcm2835_defconfig and arm64/defconfig. Applied to arm/fixes, thanks! [1/1] ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in commit: ab37a7a890c1176144a4c66ff3d51ef2c20ed486 Arnd
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index 52a0400..d9abaae 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm/configs/multi_v7_defconfig @@ -821,7 +821,7 @@ CONFIG_USB_ISP1760=y CONFIG_USB_HSIC_USB3503=y CONFIG_AB8500_USB=y CONFIG_KEYSTONE_USB_PHY=m -CONFIG_NOP_USB_XCEIV=m +CONFIG_NOP_USB_XCEIV=y CONFIG_AM335X_PHY_USB=m CONFIG_TWL6030_USB=m CONFIG_USB_GPIO_VBUS=y
The usage of usb-nop-xceiv PHY on Raspberry Pi boards with BCM283x has been a "regression source" a lot of times. The last case is breakage of USB mass storage boot has been commit e590474768f1 ("driver core: Set fw_devlink=on by default") for multi_v7_defconfig. As long as NOP_USB_XCEIV is configured as module, the dwc2 USB driver defer probing endlessly and prevent booting from USB mass storage device. So make the driver built-in as in bcm2835_defconfig and arm64/defconfig. Reported-by: Ojaswin Mujoo <ojaswin98@gmail.com> Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> --- arch/arm/configs/multi_v7_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)