| Message ID | 20210618123851.1344518-3-anup.patel@wdc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Linux RISC-V ACLINT Support | expand |
On Fri, 18 Jun 2021 13:38:42 +0100, Anup Patel <anup.patel@wdc.com> wrote: > > We add "#define pr_fmt()" in smp.c to use "riscv:" as common > print prefix for all pr_xyz() statements in this file. > > Signed-off-by: Anup Patel <anup.patel@wdc.com> > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> > --- > arch/riscv/kernel/smp.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/arch/riscv/kernel/smp.c b/arch/riscv/kernel/smp.c > index 547dc508f7d1..eea0c9d11d9f 100644 > --- a/arch/riscv/kernel/smp.c > +++ b/arch/riscv/kernel/smp.c > @@ -8,6 +8,7 @@ > * Copyright (C) 2017 SiFive > */ > > +#define pr_fmt(fmt) "riscv: " fmt > #include <linux/cpu.h> > #include <linux/clockchips.h> > #include <linux/interrupt.h> > @@ -114,7 +115,7 @@ static void send_ipi_mask(const struct cpumask *mask, enum ipi_message_type op) > if (ipi_ops && ipi_ops->ipi_inject) > ipi_ops->ipi_inject(mask); > else > - pr_warn("SMP: IPI inject method not available\n"); > + pr_warn("IPI inject method not available\n"); > } > > static void send_ipi_single(int cpu, enum ipi_message_type op) > @@ -126,7 +127,7 @@ static void send_ipi_single(int cpu, enum ipi_message_type op) > if (ipi_ops && ipi_ops->ipi_inject) > ipi_ops->ipi_inject(cpumask_of(cpu)); > else > - pr_warn("SMP: IPI inject method not available\n"); > + pr_warn("IPI inject method not available\n"); "SMP:" made a lot more sense. I assume that the user knows that they are using a RISC-V machine. On the other hand, seeing a "SMP:" prefix for a message indicates the provenance of the message. I honestly don't see the point in this change. M.
On Mon, Jul 26, 2021 at 7:14 PM Marc Zyngier <maz@kernel.org> wrote: > > On Fri, 18 Jun 2021 13:38:42 +0100, > Anup Patel <anup.patel@wdc.com> wrote: > > > > We add "#define pr_fmt()" in smp.c to use "riscv:" as common > > print prefix for all pr_xyz() statements in this file. > > > > Signed-off-by: Anup Patel <anup.patel@wdc.com> > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> > > --- > > arch/riscv/kernel/smp.c | 9 +++++---- > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > diff --git a/arch/riscv/kernel/smp.c b/arch/riscv/kernel/smp.c > > index 547dc508f7d1..eea0c9d11d9f 100644 > > --- a/arch/riscv/kernel/smp.c > > +++ b/arch/riscv/kernel/smp.c > > @@ -8,6 +8,7 @@ > > * Copyright (C) 2017 SiFive > > */ > > > > +#define pr_fmt(fmt) "riscv: " fmt > > #include <linux/cpu.h> > > #include <linux/clockchips.h> > > #include <linux/interrupt.h> > > @@ -114,7 +115,7 @@ static void send_ipi_mask(const struct cpumask *mask, enum ipi_message_type op) > > if (ipi_ops && ipi_ops->ipi_inject) > > ipi_ops->ipi_inject(mask); > > else > > - pr_warn("SMP: IPI inject method not available\n"); > > + pr_warn("IPI inject method not available\n"); > > } > > > > static void send_ipi_single(int cpu, enum ipi_message_type op) > > @@ -126,7 +127,7 @@ static void send_ipi_single(int cpu, enum ipi_message_type op) > > if (ipi_ops && ipi_ops->ipi_inject) > > ipi_ops->ipi_inject(cpumask_of(cpu)); > > else > > - pr_warn("SMP: IPI inject method not available\n"); > > + pr_warn("IPI inject method not available\n"); > > "SMP:" made a lot more sense. I assume that the user knows that they > are using a RISC-V machine. On the other hand, seeing a "SMP:" prefix > for a message indicates the provenance of the message. > > I honestly don't see the point in this change. The intention was to distinguish arch specific prints from generic kernel prints at boot-time because "SMP: " prefix was not making it obvious that these are arch specific prints. I am certainly fine dropping this patch as well. Regards, Anup > > M. > > -- > Without deviation from the norm, progress is not possible.
diff --git a/arch/riscv/kernel/smp.c b/arch/riscv/kernel/smp.c index 547dc508f7d1..eea0c9d11d9f 100644 --- a/arch/riscv/kernel/smp.c +++ b/arch/riscv/kernel/smp.c @@ -8,6 +8,7 @@ * Copyright (C) 2017 SiFive */ +#define pr_fmt(fmt) "riscv: " fmt #include <linux/cpu.h> #include <linux/clockchips.h> #include <linux/interrupt.h> @@ -114,7 +115,7 @@ static void send_ipi_mask(const struct cpumask *mask, enum ipi_message_type op) if (ipi_ops && ipi_ops->ipi_inject) ipi_ops->ipi_inject(mask); else - pr_warn("SMP: IPI inject method not available\n"); + pr_warn("IPI inject method not available\n"); } static void send_ipi_single(int cpu, enum ipi_message_type op) @@ -126,7 +127,7 @@ static void send_ipi_single(int cpu, enum ipi_message_type op) if (ipi_ops && ipi_ops->ipi_inject) ipi_ops->ipi_inject(cpumask_of(cpu)); else - pr_warn("SMP: IPI inject method not available\n"); + pr_warn("IPI inject method not available\n"); } #ifdef CONFIG_IRQ_WORK @@ -242,7 +243,7 @@ void smp_send_stop(void) cpumask_clear_cpu(smp_processor_id(), &mask); if (system_state <= SYSTEM_RUNNING) - pr_crit("SMP: stopping secondary CPUs\n"); + pr_crit("stopping secondary CPUs\n"); send_ipi_mask(&mask, IPI_CPU_STOP); } @@ -252,7 +253,7 @@ void smp_send_stop(void) udelay(1); if (num_online_cpus() > 1) - pr_warn("SMP: failed to stop secondary CPUs %*pbl\n", + pr_warn("failed to stop secondary CPUs %*pbl\n", cpumask_pr_args(cpu_online_mask)); }