mbox series

[v2,net-next,0/2] Convert switchdev_bridge_port_{,un}offload to notifiers

Message ID 20210803203409.1274807-1-vladimir.oltean@nxp.com (mailing list archive)
Headers show
Series Convert switchdev_bridge_port_{,un}offload to notifiers | expand

Message

Vladimir Oltean Aug. 3, 2021, 8:34 p.m. UTC
The introduction of the explicit switchdev bridge port offloading API
has introduced dependency regressions between switchdev drivers and the
bridge, with some drivers where switchdev support was optional before
being now compiled as a module when the bridge is a module, or worse.

This patch makes the switchdev bridge port offload/unoffload events
visible on the blocking notifier call chain, so that the bridge can
indirectly do something when those events happen, without the driver
explicitly calling a symbol exported by the bridge driver.

v1->v2: removed a bogus return value from a void function

Vladimir Oltean (2):
  net: make switchdev_bridge_port_{,unoffload} loosely coupled with the
    bridge
  Revert "net: build all switchdev drivers as modules when the bridge is
    a module"

 drivers/net/ethernet/microchip/sparx5/Kconfig |  1 -
 drivers/net/ethernet/ti/Kconfig               |  2 -
 drivers/net/ethernet/ti/am65-cpsw-nuss.c      |  2 +-
 drivers/net/ethernet/ti/cpsw_new.c            |  2 +-
 include/linux/if_bridge.h                     | 35 -------------
 include/net/switchdev.h                       | 46 +++++++++++++++++
 net/bridge/br.c                               | 51 ++++++++++++++++++-
 net/bridge/br_private.h                       | 29 +++++++++++
 net/bridge/br_switchdev.c                     | 36 ++++---------
 net/switchdev/switchdev.c                     | 48 +++++++++++++++++
 10 files changed, 184 insertions(+), 68 deletions(-)

Comments

Vladimir Oltean Aug. 3, 2021, 8:43 p.m. UTC | #1
Obsoleted by v2:
https://patchwork.kernel.org/project/netdevbpf/cover/20210803203409.1274807-1-vladimir.oltean@nxp.com/
Vladimir Oltean Aug. 3, 2021, 11:15 p.m. UTC | #2
On Tue, Aug 03, 2021 at 11:43:29PM +0300, Vladimir Oltean wrote:
> Obsoleted by v2:
> https://patchwork.kernel.org/project/netdevbpf/cover/20210803203409.1274807-1-vladimir.oltean@nxp.com/

Sorry, this is in fact v2, the most up to date version currently, it is
not obsoleted by anything.
patchwork-bot+netdevbpf@kernel.org Aug. 4, 2021, 11:40 a.m. UTC | #3
Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

On Tue,  3 Aug 2021 23:34:07 +0300 you wrote:
> The introduction of the explicit switchdev bridge port offloading API
> has introduced dependency regressions between switchdev drivers and the
> bridge, with some drivers where switchdev support was optional before
> being now compiled as a module when the bridge is a module, or worse.
> 
> This patch makes the switchdev bridge port offload/unoffload events
> visible on the blocking notifier call chain, so that the bridge can
> indirectly do something when those events happen, without the driver
> explicitly calling a symbol exported by the bridge driver.
> 
> [...]

Here is the summary with links:
  - [v2,net-next,1/2] net: make switchdev_bridge_port_{,unoffload} loosely coupled with the bridge
    https://git.kernel.org/netdev/net-next/c/957e2235e526
  - [v2,net-next,2/2] Revert "net: build all switchdev drivers as modules when the bridge is a module"
    https://git.kernel.org/netdev/net-next/c/a54182b2a518

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html