| Message ID | 1627098243-2742-1-git-send-email-dillon.minfei@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add ilitek ili9341 panel driver | expand |
Hi All Just a gentle ping, thanks. Best regards. Dillon On Sat, 24 Jul 2021 at 11:44, <dillon.minfei@gmail.com> wrote: > > From: Dillon Min <dillon.minfei@gmail.com> > > Since the st,sf-tc240t-9370-t dts binding already exist in stm32f429-disco.dts > but, the panel driver didn't get accepted from mainline. it's time to submit > patch fot it. > > This driver can support two different interface by different dts bindings: > - spi+dpi, use spi to configure register, dpi for graphic data. > st,sf-tc240t-9370-t > - only spi, just like tiny/ili9341.c (actually, this part is copy from tiny) > adafruit,yx240qv29 > > I was submited the first patch last year, you can find it at [1]. > this patch has one major difference from that one, which is replace the low > level communication way, from spi_sync() to mipi_dbi_{command, > command_stackbuf}() interface, referred from Linus's patch [2]. > > both the two dpi/dbi interface was tested on stm32f429-disco board, if anyone > want to verify this patch, you need apply the clk patch for this board first, > you can get it from [3]. > > [1] "drm/panel: Add ilitek ili9341 panel driver" > https://lore.kernel.org/lkml/1590378348-8115-7-git-send-email-dillon.minfei@gmail.com/ > > [2] "drm/panel: s6e63m0: Switch to DBI abstraction for SPI" > https://lore.kernel.org/dri-devel/20210611214243.669892-1-linus.walleij@linaro.org/ > > [3] > https://lore.kernel.org/lkml/1590378348-8115-6-git-send-email-dillon.minfei@gmail.com/ > > v4: > - fix m68k-allmodconfig build error which reported by lkp, thanks. > - add Copyright 2018 David Lechner <david@lechnology.com>. > v3 link: > https://lore.kernel.org/lkml/1627013203-23099-1-git-send-email-dillon.minfei@gmail.com/ > > v3: > - add Fixes tags. > - collect reviewed-by tags from linus and jagan. > - replace DRM_ERROR() with dev_err() or drm_err(). > - remove kernel-doc markers from struct ili9341_config{}. > - reorder include headers. > - remove the struct device *dev from struct ili9341{}. > - restructure the ili9341_probe() function, add two ili9341_{dbi,dpi)_probe() > to make it more readable according to jagan's suggestion, thanks. > > for the full drm driver exist in drm/panel need Sam and Laurent's feedback. > so, not cover this part at this time, will be update later. > > v2 link: > https://lore.kernel.org/lkml/1626853288-31223-1-git-send-email-dillon.minfei@gmail.com/ > > v2: > - replace vcc regulator to bulk regulators in driver, from linus suggestion. > - fix dtbs_check warnings on ili9341 dts binding check. > - add bulk regulation node in ilitek,ili9341.yaml. > v1 link: > https://lore.kernel.org/lkml/1626430843-23823-1-git-send-email-dillon.minfei@gmail.com/ > > Dillon Min (3): > dt-bindings: display: panel: Add ilitek ili9341 panel bindings > ARM: dts: stm32: fix dtbs_check warning on ili9341 dts binding > drm/panel: Add ilitek ili9341 panel driver > > .../bindings/display/panel/ilitek,ili9341.yaml | 78 ++ > arch/arm/boot/dts/stm32f429-disco.dts | 2 +- > drivers/gpu/drm/panel/Kconfig | 12 + > drivers/gpu/drm/panel/Makefile | 1 + > drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 792 +++++++++++++++++++++ > 5 files changed, 884 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml > create mode 100644 drivers/gpu/drm/panel/panel-ilitek-ili9341.c > > -- > 1.9.1 >
On Sat, Jul 24, 2021 at 6:46 AM <dillon.minfei@gmail.com> wrote: > > From: Dillon Min <dillon.minfei@gmail.com> > > Since the st,sf-tc240t-9370-t dts binding already exist in stm32f429-disco.dts > but, the panel driver didn't get accepted from mainline. it's time to submit > patch fot it. > > This driver can support two different interface by different dts bindings: > - spi+dpi, use spi to configure register, dpi for graphic data. > st,sf-tc240t-9370-t > - only spi, just like tiny/ili9341.c (actually, this part is copy from tiny) > adafruit,yx240qv29 ... > I was submited the first patch last year, you can find it at [1]. submitted > this patch has one major difference from that one, which is replace the low > level communication way, from spi_sync() to mipi_dbi_{command, > command_stackbuf}() interface, referred from Linus's patch [2]. Can you shed a light on the road map here. I have the SPI panel (tiny) based on the ILI9341 and I'm using actually mi0283qt driver. With yours we will have 3 (three!) drivers for the same chip. I really do not want this. Without road map on the prospective of these all drivers, NAK.
Hi Andy Thanks for your question. On Thu, 5 Aug 2021 at 18:16, Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Sat, Jul 24, 2021 at 6:46 AM <dillon.minfei@gmail.com> wrote: > > > > From: Dillon Min <dillon.minfei@gmail.com> > > > > Since the st,sf-tc240t-9370-t dts binding already exist in stm32f429-disco.dts > > but, the panel driver didn't get accepted from mainline. it's time to submit > > patch fot it. > > > > This driver can support two different interface by different dts bindings: > > - spi+dpi, use spi to configure register, dpi for graphic data. > > st,sf-tc240t-9370-t > > - only spi, just like tiny/ili9341.c (actually, this part is copy from tiny) > > adafruit,yx240qv29 > > ... > > > I was submited the first patch last year, you can find it at [1]. > > submitted Thanks. > > > this patch has one major difference from that one, which is replace the low > > level communication way, from spi_sync() to mipi_dbi_{command, > > command_stackbuf}() interface, referred from Linus's patch [2]. > > Can you shed a light on the road map here. Personally, I'd like to merge tiny/mi0283qt.c, tiny/ili9341.c(already done) into this driver later (keep original author, copyright, dts compatible string). then remove these two drivers under tiny, but it's up to Sam and Laurent agreement. For long term, just like Peter suggested, let all panel based on ili9xxx with single-dbi or dbi & dpi interface to be supported by single ilitek-ili9xxx.c, something like panel/panel-simple.c (panel/panel-ilitek-ili9322c, tiny/ili9225.c, tiny/ili9486.c, tiny/mi0283qt.c, etc). it's also needs maintainers permission. > I have the SPI panel (tiny) based on the ILI9341 and I'm using > actually mi0283qt driver. With yours we will have 3 (three!) drivers > for the same chip. I really do not want this. Without road map on the > prospective of these all drivers, NAK. Yes, it will make users confused if there are three different drivers for the same chip. I'll continue to work on this driver. Thanks again for point this out. Best Regards Dillon > > -- > With Best Regards, > Andy Shevchenko
From: Dillon Min <dillon.minfei@gmail.com> Since the st,sf-tc240t-9370-t dts binding already exist in stm32f429-disco.dts but, the panel driver didn't get accepted from mainline. it's time to submit patch fot it. This driver can support two different interface by different dts bindings: - spi+dpi, use spi to configure register, dpi for graphic data. st,sf-tc240t-9370-t - only spi, just like tiny/ili9341.c (actually, this part is copy from tiny) adafruit,yx240qv29 I was submited the first patch last year, you can find it at [1]. this patch has one major difference from that one, which is replace the low level communication way, from spi_sync() to mipi_dbi_{command, command_stackbuf}() interface, referred from Linus's patch [2]. both the two dpi/dbi interface was tested on stm32f429-disco board, if anyone want to verify this patch, you need apply the clk patch for this board first, you can get it from [3]. [1] "drm/panel: Add ilitek ili9341 panel driver" https://lore.kernel.org/lkml/1590378348-8115-7-git-send-email-dillon.minfei@gmail.com/ [2] "drm/panel: s6e63m0: Switch to DBI abstraction for SPI" https://lore.kernel.org/dri-devel/20210611214243.669892-1-linus.walleij@linaro.org/ [3] https://lore.kernel.org/lkml/1590378348-8115-6-git-send-email-dillon.minfei@gmail.com/ v4: - fix m68k-allmodconfig build error which reported by lkp, thanks. - add Copyright 2018 David Lechner <david@lechnology.com>. v3 link: https://lore.kernel.org/lkml/1627013203-23099-1-git-send-email-dillon.minfei@gmail.com/ v3: - add Fixes tags. - collect reviewed-by tags from linus and jagan. - replace DRM_ERROR() with dev_err() or drm_err(). - remove kernel-doc markers from struct ili9341_config{}. - reorder include headers. - remove the struct device *dev from struct ili9341{}. - restructure the ili9341_probe() function, add two ili9341_{dbi,dpi)_probe() to make it more readable according to jagan's suggestion, thanks. for the full drm driver exist in drm/panel need Sam and Laurent's feedback. so, not cover this part at this time, will be update later. v2 link: https://lore.kernel.org/lkml/1626853288-31223-1-git-send-email-dillon.minfei@gmail.com/ v2: - replace vcc regulator to bulk regulators in driver, from linus suggestion. - fix dtbs_check warnings on ili9341 dts binding check. - add bulk regulation node in ilitek,ili9341.yaml. v1 link: https://lore.kernel.org/lkml/1626430843-23823-1-git-send-email-dillon.minfei@gmail.com/ Dillon Min (3): dt-bindings: display: panel: Add ilitek ili9341 panel bindings ARM: dts: stm32: fix dtbs_check warning on ili9341 dts binding drm/panel: Add ilitek ili9341 panel driver .../bindings/display/panel/ilitek,ili9341.yaml | 78 ++ arch/arm/boot/dts/stm32f429-disco.dts | 2 +- drivers/gpu/drm/panel/Kconfig | 12 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 792 +++++++++++++++++++++ 5 files changed, 884 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml create mode 100644 drivers/gpu/drm/panel/panel-ilitek-ili9341.c