diff mbox series

[v2,3/3] brcmfmac: add patch ram for bluetooth

Message ID 20210811152804.2379405-4-angus@akkea.ca (mailing list archive)
State Changes Requested
Delegated to: Kalle Valo
Headers show
Series Add BCM43752 chipset support | expand

Commit Message

Angus Ainslie Aug. 11, 2021, 3:28 p.m. UTC 
Bluetooth on the BCM43752 needs a patchram file to function correctly.

Signed-off-by: Angus Ainslie <angus@akkea.ca>
---
 drivers/bluetooth/btbcm.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Arend Van Spriel Aug. 12, 2021, 11:40 a.m. UTC | #1 
On 8/11/2021 5:28 PM, Angus Ainslie wrote:
> Bluetooth on the BCM43752 needs a patchram file to function correctly.

this patch is dealing with bluetooth so you should add the proper 
mailing list.

> Signed-off-by: Angus Ainslie <angus@akkea.ca>
> ---
>   drivers/bluetooth/btbcm.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
> index e5d706ed55ea..e4182acee488 100644
> --- a/drivers/bluetooth/btbcm.c
> +++ b/drivers/bluetooth/btbcm.c
> @@ -387,6 +387,7 @@ struct bcm_subver_table {
>   };
>   
>   static const struct bcm_subver_table bcm_uart_subver_table[] = {
> +	{ 0x1111, "BCM4362A2"	},	/* 000.017.017 */

This seems odd. 4362 vs 43752? What is the story here?

Regards,
Arend

>   	{ 0x4103, "BCM4330B1"	},	/* 002.001.003 */
>   	{ 0x410d, "BCM4334B0"	},	/* 002.001.013 */
>   	{ 0x410e, "BCM43341B0"	},	/* 002.001.014 */
>
Arend Van Spriel Aug. 12, 2021, 11:42 a.m. UTC | #2 
On 8/12/2021 1:40 PM, Arend van Spriel wrote:
> On 8/11/2021 5:28 PM, Angus Ainslie wrote:
>> Bluetooth on the BCM43752 needs a patchram file to function correctly.
> 
> this patch is dealing with bluetooth so you should add the proper 
> mailing list.

...and the 'brcmfmac:' prefix in the subject is inappropriate. It should 
  be 'btbcm:' instead.

Regards,
Arend
Angus Ainslie Aug. 12, 2021, 1:01 p.m. UTC | #3 
Hi Arend,

On 2021-08-12 04:42, Arend van Spriel wrote:
> On 8/12/2021 1:40 PM, Arend van Spriel wrote:
>> On 8/11/2021 5:28 PM, Angus Ainslie wrote:
>>> Bluetooth on the BCM43752 needs a patchram file to function 
>>> correctly.
>> 
>> this patch is dealing with bluetooth so you should add the proper 
>> mailing list.
> 
> ...and the 'brcmfmac:' prefix in the subject is inappropriate. It
> should  be 'btbcm:' instead.
> 

Thanks for looking at the patches I'll fix them up for v3.

Angus

> Regards,
> Arend
diff mbox series

Patch

diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
index e5d706ed55ea..e4182acee488 100644
--- a/drivers/bluetooth/btbcm.c
+++ b/drivers/bluetooth/btbcm.c
@@ -387,6 +387,7 @@  struct bcm_subver_table {
 };
 
 static const struct bcm_subver_table bcm_uart_subver_table[] = {
+	{ 0x1111, "BCM4362A2"	},	/* 000.017.017 */
 	{ 0x4103, "BCM4330B1"	},	/* 002.001.003 */
 	{ 0x410d, "BCM4334B0"	},	/* 002.001.013 */
 	{ 0x410e, "BCM43341B0"	},	/* 002.001.014 */