| Message ID | 20210813055729.19885-1-mie@igel.co.jp (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | RDMA/rxe: Remove duplicate umem assignment | expand |
Hi, My same fix[1] has been merged into for-next branch on rdma but it is not merged into mainline for now. [1]: https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?id=cdbdb7724740f62d11519679e11cf673cd9d6c8f Best Regards, Xiao Yang On 2021/8/13 13:57, Shunsuke Mie wrote: > While initialization of rxe_mr, mr->umem is assigned duplicate. Remove > the redundant code. > > Signed-off-by: Shunsuke Mie <mie@igel.co.jp> > --- > drivers/infiniband/sw/rxe/rxe_mr.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/infiniband/sw/rxe/rxe_mr.c b/drivers/infiniband/sw/rxe/rxe_mr.c > index 73bbafd32554..6e2e0da2e50d 100644 > --- a/drivers/infiniband/sw/rxe/rxe_mr.c > +++ b/drivers/infiniband/sw/rxe/rxe_mr.c > @@ -122,7 +122,6 @@ int rxe_mr_init_user(struct rxe_pd *pd, u64 start, u64 length, u64 iova, > goto err1; > } > > - mr->umem = umem; > num_buf = ib_umem_num_pages(umem); > > rxe_mr_init(access, mr);
HI, Xiao. > My same fix[1] has been merged into for-next branch on rdma but it is > not merged into mainline for now. > > [1]: > https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?id=cdbdb7724740f62d11519679e11cf673cd9d6c8f Thank you for the information. I had missed it. Thanks a lot, Shunsuke Mie
diff --git a/drivers/infiniband/sw/rxe/rxe_mr.c b/drivers/infiniband/sw/rxe/rxe_mr.c index 73bbafd32554..6e2e0da2e50d 100644 --- a/drivers/infiniband/sw/rxe/rxe_mr.c +++ b/drivers/infiniband/sw/rxe/rxe_mr.c @@ -122,7 +122,6 @@ int rxe_mr_init_user(struct rxe_pd *pd, u64 start, u64 length, u64 iova, goto err1; } - mr->umem = umem; num_buf = ib_umem_num_pages(umem); rxe_mr_init(access, mr);
While initialization of rxe_mr, mr->umem is assigned duplicate. Remove the redundant code. Signed-off-by: Shunsuke Mie <mie@igel.co.jp> --- drivers/infiniband/sw/rxe/rxe_mr.c | 1 - 1 file changed, 1 deletion(-)