| Message ID | 20210804123015.807929-1-bmeng.cn@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/2] riscv: dts: microchip: Use 'local-mac-address' for emac1 | expand |
On Wed, Aug 4, 2021 at 8:30 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > From: Bin Meng <bin.meng@windriver.com> > > Per the DT spec, 'local-mac-address' is used to specify MAC address > that was assigned to the network device, while 'mac-address' is used > to specify the MAC address that was last used by the boot program, > and shall be used only if the value differs from 'local-mac-address' > property value. > > Signed-off-by: Bin Meng <bin.meng@windriver.com> > Reviewed-by: conor dooley <conor.dooley@microchip.com> > --- > > (no changes since v1) > > arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Ping? It looks like these dts patches are still not applied... Regards, Bin
Hi Bin, On Wed, Aug 4, 2021 at 2:30 PM Bin Meng <bmeng.cn@gmail.com> wrote: > From: Bin Meng <bin.meng@windriver.com> > > Per the DT spec, 'local-mac-address' is used to specify MAC address > that was assigned to the network device, while 'mac-address' is used > to specify the MAC address that was last used by the boot program, > and shall be used only if the value differs from 'local-mac-address' > property value. > > Signed-off-by: Bin Meng <bin.meng@windriver.com> > Reviewed-by: conor dooley <conor.dooley@microchip.com> Thanks for your patch! > --- > > (no changes since v1) > > arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi > index 0659068b62f7..a9c558366d61 100644 > --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi > +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi > @@ -317,7 +317,7 @@ emac1: ethernet@20112000 { > reg = <0x0 0x20112000 0x0 0x2000>; > interrupt-parent = <&plic>; > interrupts = <70 71 72 73>; > - mac-address = [00 00 00 00 00 00]; > + local-mac-address = [00 00 00 00 00 00]; Is there any point in providing an all-zeros MAC address at all? Can't it just be removed? > clocks = <&clkcfg 5>, <&clkcfg 2>; > status = "disabled"; > clock-names = "pclk", "hclk"; Gr{oetje,eeting}s, Geert
On Wed, 04 Aug 2021 05:30:14 PDT (-0700), bmeng.cn@gmail.com wrote: > From: Bin Meng <bin.meng@windriver.com> > > Per the DT spec, 'local-mac-address' is used to specify MAC address > that was assigned to the network device, while 'mac-address' is used > to specify the MAC address that was last used by the boot program, > and shall be used only if the value differs from 'local-mac-address' > property value. > > Signed-off-by: Bin Meng <bin.meng@windriver.com> > Reviewed-by: conor dooley <conor.dooley@microchip.com> > --- > > (no changes since v1) > > arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi > index 0659068b62f7..a9c558366d61 100644 > --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi > +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi > @@ -317,7 +317,7 @@ emac1: ethernet@20112000 { > reg = <0x0 0x20112000 0x0 0x2000>; > interrupt-parent = <&plic>; > interrupts = <70 71 72 73>; > - mac-address = [00 00 00 00 00 00]; > + local-mac-address = [00 00 00 00 00 00]; > clocks = <&clkcfg 5>, <&clkcfg 2>; > status = "disabled"; > clock-names = "pclk", "hclk"; Thanks, these are on fixes.
diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi index 0659068b62f7..a9c558366d61 100644 --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi @@ -317,7 +317,7 @@ emac1: ethernet@20112000 { reg = <0x0 0x20112000 0x0 0x2000>; interrupt-parent = <&plic>; interrupts = <70 71 72 73>; - mac-address = [00 00 00 00 00 00]; + local-mac-address = [00 00 00 00 00 00]; clocks = <&clkcfg 5>, <&clkcfg 2>; status = "disabled"; clock-names = "pclk", "hclk";