| Message ID | 20210813233353.2099459-5-wuhaotsh@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Misc NPCM7XX patches | expand |
On 8/14/21 1:33 AM, Hao Wu wrote: > Our sensor test requires both reading and writing from a sensor's > QOM property. So we need to make the input of ADC module R/W instead > of read only for that to work. > > Signed-off-by: Hao Wu <wuhaotsh@google.com> > Reviewed-by: Titus Rwantare <titusr@google.com> > --- > hw/adc/npcm7xx_adc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/adc/npcm7xx_adc.c b/hw/adc/npcm7xx_adc.c > index 47fb9e5f74..bc6f3f55e6 100644 > --- a/hw/adc/npcm7xx_adc.c > +++ b/hw/adc/npcm7xx_adc.c > @@ -242,7 +242,7 @@ static void npcm7xx_adc_init(Object *obj) > > for (i = 0; i < NPCM7XX_ADC_NUM_INPUTS; ++i) { > object_property_add_uint32_ptr(obj, "adci[*]", > - &s->adci[i], OBJ_PROP_FLAG_WRITE); > + &s->adci[i], OBJ_PROP_FLAG_READWRITE); What about: qtest_enabled() ? OBJ_PROP_FLAG_READWRITE : OBJ_PROP_FLAG_WRITE > } > object_property_add_uint32_ptr(obj, "vref", > &s->vref, OBJ_PROP_FLAG_WRITE); >
diff --git a/hw/adc/npcm7xx_adc.c b/hw/adc/npcm7xx_adc.c index 47fb9e5f74..bc6f3f55e6 100644 --- a/hw/adc/npcm7xx_adc.c +++ b/hw/adc/npcm7xx_adc.c @@ -242,7 +242,7 @@ static void npcm7xx_adc_init(Object *obj) for (i = 0; i < NPCM7XX_ADC_NUM_INPUTS; ++i) { object_property_add_uint32_ptr(obj, "adci[*]", - &s->adci[i], OBJ_PROP_FLAG_WRITE); + &s->adci[i], OBJ_PROP_FLAG_READWRITE); } object_property_add_uint32_ptr(obj, "vref", &s->vref, OBJ_PROP_FLAG_WRITE);