mbox series

[v2,0/3] x86/edac/amd64: Add support for noncpu nodes

Message ID 20210806074350.114614-1-nchatrad@amd.com (mailing list archive)
Headers show
Series x86/edac/amd64: Add support for noncpu nodes | expand

Message

Naveen Krishna Chatradhi Aug. 6, 2021, 7:43 a.m. UTC 
From: Muralidhara M K <muralimk@amd.com>

On newer heterogeneous systems from AMD with GPU nodes connected via
xGMI links to the CPUs, the GPU dies are interfaced with HBM2 memory.

This patchset applies on top of the following series by Yazen Ghannam
AMD MCA Address Translation Updates
[https://patchwork.kernel.org/project/linux-edac/list/?series=505989]

This patchset does the following
1. Add support for northbridges on Aldebaran
	* x86/amd_nb: Add support for northbridges on Aldebaran
2. Modifies the amd64_edac module to
   a. Handle the UMCs on the noncpu nodes,
	* EDAC/mce_amd: extract node id from InstanceHi in IPID
   b. Enumerate HBM memory and add address translation
	* EDAC/amd64: Enumerate memory on noncpu nodes

Muralidhara M K (1):
  x86/amd_nb: Add support for northbridges on Aldebaran

Naveen Krishna Chatradhi (2):
  EDAC/mce_amd: Extract node id from InstanceHi in IPID
  EDAC/amd64: Enumerate memory on noncpu nodes

 arch/x86/include/asm/amd_nb.h |  10 ++
 arch/x86/kernel/amd_nb.c      |  63 ++++++++++-
 drivers/edac/amd64_edac.c     | 202 +++++++++++++++++++++++++++++-----
 drivers/edac/amd64_edac.h     |  27 +++++
 drivers/edac/mce_amd.c        |  19 +++-
 include/linux/pci_ids.h       |   1 +
 6 files changed, 288 insertions(+), 34 deletions(-)

Comments

Yazen Ghannam Aug. 20, 2021, 5:07 p.m. UTC | #1 
On Fri, Aug 06, 2021 at 01:13:47PM +0530, Naveen Krishna Chatradhi wrote:
> From: Muralidhara M K <muralimk@amd.com>
> 
> On newer heterogeneous systems from AMD with GPU nodes connected via
> xGMI links to the CPUs, the GPU dies are interfaced with HBM2 memory.
> 
> This patchset applies on top of the following series by Yazen Ghannam
> AMD MCA Address Translation Updates
> [https://patchwork.kernel.org/project/linux-edac/list/?series=505989]
>

Hi Naveen,

As I was reworking the set referenced above, I got into a circular
dependency with your set here. Can you please rebase your set on the
latest upstream code? I can then base the next version of my set on
yours. I think the only change you may need to make is around the 
address translation hunk in amd64_edac.c in Patch 3.

Also, can you please CC me on the next revision of your set?

Thanks,
Yazen