diff mbox series

[RESEND,for-next] RDMA/hns: Fix incorrect lsn field

Message ID 1629883169-2306-1-git-send-email-liangwenpeng@huawei.com (mailing list archive)
State Accepted
Delegated to: Jason Gunthorpe
Headers show
Series [RESEND,for-next] RDMA/hns: Fix incorrect lsn field | expand

Commit Message

Wenpeng Liang Aug. 25, 2021, 9:19 a.m. UTC
From: Yixing Liu <liuyixing1@huawei.com>

In RNR NAK screnario, according to the specification, when no credit is
available, only the first fragment of the send request can be sent. The
LSN(Limit Sequence Number) field should be 0 or the entire packet will be
resent.

Fixes: 926a01dc000d ("RDMA/hns: Add QP operations support for hip08 SoC")
Signed-off-by: Yixing Liu <liuyixing1@huawei.com>
Signed-off-by: Wenpeng Liang <liangwenpeng@huawei.com>
---
 drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 3 ---
 1 file changed, 3 deletions(-)

--
2.8.1

Comments

Jason Gunthorpe Aug. 25, 2021, 5:50 p.m. UTC | #1
On Wed, Aug 25, 2021 at 05:19:29PM +0800, Wenpeng Liang wrote:
> From: Yixing Liu <liuyixing1@huawei.com>
> 
> In RNR NAK screnario, according to the specification, when no credit is
> available, only the first fragment of the send request can be sent. The
> LSN(Limit Sequence Number) field should be 0 or the entire packet will be
> resent.
> 
> Fixes: 926a01dc000d ("RDMA/hns: Add QP operations support for hip08 SoC")
> Signed-off-by: Yixing Liu <liuyixing1@huawei.com>
> Signed-off-by: Wenpeng Liang <liangwenpeng@huawei.com>
> ---
>  drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 3 ---
>  1 file changed, 3 deletions(-)

Applied to for-next, thanks

Jason
diff mbox series

Patch

diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
index d00be78..198a0c6 100644
--- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
+++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
@@ -4483,9 +4483,6 @@  static int modify_qp_rtr_to_rts(struct ib_qp *ibqp,

 	hr_reg_clear(qpc_mask, QPC_CHECK_FLG);

-	hr_reg_write(context, QPC_LSN, 0x100);
-	hr_reg_clear(qpc_mask, QPC_LSN);
-
 	hr_reg_clear(qpc_mask, QPC_V2_IRRL_HEAD);

 	return 0;