| Message ID | 20210920095730.1216692-1-arnd@kernel.org (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Lorenzo Pieralisi |
| Headers | show |
| Series | PCI: rcar: add COMMON_CLK dependency | expand |
On Mon, Sep 20, 2021 at 11:57:10AM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The __clk_is_enabled() interface is only available when building for > platforms using CONFIG_COMMON_CLK: > > arm-linux-gnueabi-ld: drivers/pci/controller/pcie-rcar-host.o: in function `rcar_pcie_aarch32_abort_handler': > pcie-rcar-host.c:(.text+0x8fc): undefined reference to `__clk_is_enabled' > > Add the necessary dependency to the COMPILE_TEST path. > > Fixes: a115b1bd3af0 ("PCI: rcar: Add L1 link state fix into data abort hook") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/pci/controller/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Marek already posted a fix for this: https://lore.kernel.org/linux-pci/20210907144512.5238-1-marek.vasut@gmail.com and was waiting for Stephen to have a look to determine if this could be simplified (Arnd patch already does, btw). We should merge a fix for this asap. Lorenzo > diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig > index 326f7d13024f..53e3648fe872 100644 > --- a/drivers/pci/controller/Kconfig > +++ b/drivers/pci/controller/Kconfig > @@ -65,7 +65,7 @@ config PCI_RCAR_GEN2 > > config PCIE_RCAR_HOST > bool "Renesas R-Car PCIe host controller" > - depends on ARCH_RENESAS || COMPILE_TEST > + depends on ARCH_RENESAS || (COMMON_CLK && COMPILE_TEST) > depends on PCI_MSI_IRQ_DOMAIN > help > Say Y here if you want PCIe controller support on R-Car SoCs in host > -- > 2.29.2 >
diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig index 326f7d13024f..53e3648fe872 100644 --- a/drivers/pci/controller/Kconfig +++ b/drivers/pci/controller/Kconfig @@ -65,7 +65,7 @@ config PCI_RCAR_GEN2 config PCIE_RCAR_HOST bool "Renesas R-Car PCIe host controller" - depends on ARCH_RENESAS || COMPILE_TEST + depends on ARCH_RENESAS || (COMMON_CLK && COMPILE_TEST) depends on PCI_MSI_IRQ_DOMAIN help Say Y here if you want PCIe controller support on R-Car SoCs in host