mbox series

[v3,0/5] RDMA/rxe: Do some cleanup

Message ID 20210916124652.1304649-1-yangx.jy@fujitsu.com (mailing list archive)
Headers show
Series RDMA/rxe: Do some cleanup | expand

Message

Xiao Yang Sept. 16, 2021, 12:46 p.m. UTC
V2->V3:
1) Rebase on the latest kernel
2) Drop the ternary expression

Xiao Yang (5):
  RDMA/rxe: Remove unnecessary check for qp->is_user/cq->is_user
  RDMA/rxe: Remove the common is_user member of struct rxe_qp
  RDMA/rxe: Change the is_user member of struct rxe_cq to bool
  RDMA/rxe: Set partial attributes when completion status !=
    IBV_WC_SUCCESS
  RDMA/rxe: Remove duplicate settings

 drivers/infiniband/sw/rxe/rxe_comp.c  | 51 +++++++++++++++------------
 drivers/infiniband/sw/rxe/rxe_cq.c    |  3 +-
 drivers/infiniband/sw/rxe/rxe_qp.c    |  5 +--
 drivers/infiniband/sw/rxe/rxe_req.c   |  4 +--
 drivers/infiniband/sw/rxe/rxe_resp.c  | 14 +++-----
 drivers/infiniband/sw/rxe/rxe_verbs.c | 41 +++++----------------
 drivers/infiniband/sw/rxe/rxe_verbs.h |  3 +-
 7 files changed, 49 insertions(+), 72 deletions(-)

Comments

Jason Gunthorpe Sept. 28, 2021, 2:48 p.m. UTC | #1
On Thu, Sep 16, 2021 at 08:46:47PM +0800, Xiao Yang wrote:
> V2->V3:
> 1) Rebase on the latest kernel
> 2) Drop the ternary expression
> 
> Xiao Yang (5):
>   RDMA/rxe: Remove unnecessary check for qp->is_user/cq->is_user
>   RDMA/rxe: Remove the common is_user member of struct rxe_qp
>   RDMA/rxe: Change the is_user member of struct rxe_cq to bool
>   RDMA/rxe: Set partial attributes when completion status !=
>     IBV_WC_SUCCESS
>   RDMA/rxe: Remove duplicate settings
> 
>  drivers/infiniband/sw/rxe/rxe_comp.c  | 51 +++++++++++++++------------
>  drivers/infiniband/sw/rxe/rxe_cq.c    |  3 +-
>  drivers/infiniband/sw/rxe/rxe_qp.c    |  5 +--
>  drivers/infiniband/sw/rxe/rxe_req.c   |  4 +--
>  drivers/infiniband/sw/rxe/rxe_resp.c  | 14 +++-----
>  drivers/infiniband/sw/rxe/rxe_verbs.c | 41 +++++----------------
>  drivers/infiniband/sw/rxe/rxe_verbs.h |  3 +-
>  7 files changed, 49 insertions(+), 72 deletions(-)

This doesn't apply, can you rebase and resend please

Jason
Xiao Yang Sept. 30, 2021, 3:42 a.m. UTC | #2
On 2021/9/28 22:48, Jason Gunthorpe wrote:
> On Thu, Sep 16, 2021 at 08:46:47PM +0800, Xiao Yang wrote:
>> V2->V3:
>> 1) Rebase on the latest kernel
>> 2) Drop the ternary expression
>>
>> Xiao Yang (5):
>>    RDMA/rxe: Remove unnecessary check for qp->is_user/cq->is_user
>>    RDMA/rxe: Remove the common is_user member of struct rxe_qp
>>    RDMA/rxe: Change the is_user member of struct rxe_cq to bool
>>    RDMA/rxe: Set partial attributes when completion status !=
>>      IBV_WC_SUCCESS
>>    RDMA/rxe: Remove duplicate settings
>>
>>   drivers/infiniband/sw/rxe/rxe_comp.c  | 51 +++++++++++++++------------
>>   drivers/infiniband/sw/rxe/rxe_cq.c    |  3 +-
>>   drivers/infiniband/sw/rxe/rxe_qp.c    |  5 +--
>>   drivers/infiniband/sw/rxe/rxe_req.c   |  4 +--
>>   drivers/infiniband/sw/rxe/rxe_resp.c  | 14 +++-----
>>   drivers/infiniband/sw/rxe/rxe_verbs.c | 41 +++++----------------
>>   drivers/infiniband/sw/rxe/rxe_verbs.h |  3 +-
>>   7 files changed, 49 insertions(+), 72 deletions(-)
> This doesn't apply, can you rebase and resend please
Hi Jason,

Sure, I will rebase and resend soon.

Best Regards,
Xiao Yang
> Jason