| Message ID | 54bed9a0e6991490ddb2b07e5abfaf40a7a62928.1633090577.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Lorenzo Pieralisi |
| Headers | show |
| Series | PCI: rcar: pcie-rcar-host: Remove unneeded includes | expand |
Hi Geert, Thanks for your patch. On 2021-10-01 14:16:43 +0200, Geert Uytterhoeven wrote: > Remove includes that are not needed, to speed up (re)compilation. > > Most of these are relics from splitting the driver in a host and a > common part. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > drivers/pci/controller/pcie-rcar-host.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/pci/controller/pcie-rcar-host.c b/drivers/pci/controller/pcie-rcar-host.c > index 8f3131844e7778cf..e12c2d8be05a34e2 100644 > --- a/drivers/pci/controller/pcie-rcar-host.c > +++ b/drivers/pci/controller/pcie-rcar-host.c > @@ -24,13 +24,11 @@ > #include <linux/msi.h> > #include <linux/of_address.h> > #include <linux/of_irq.h> > -#include <linux/of_pci.h> > #include <linux/of_platform.h> > #include <linux/pci.h> > #include <linux/phy/phy.h> > #include <linux/platform_device.h> > #include <linux/pm_runtime.h> > -#include <linux/slab.h> > > #include "pcie-rcar.h" > > -- > 2.25.1 >
Seems overkill to mention "rcar" and "pci" twice in the subject. We have so far not distinguished pcie-rcar-host.c and pcie-rcar-ep.c in subject lines. If we want to start doing that consistently, maybe we could use "PCI: rcar-host:" and "PCI: rcar-ep:" as we have done for cadence-ep and designware-ep. On Fri, Oct 01, 2021 at 02:16:43PM +0200, Geert Uytterhoeven wrote: > Remove includes that are not needed, to speed up (re)compilation. > ...
Hi Bjorn, On Sat, Oct 2, 2021 at 6:00 PM Bjorn Helgaas <helgaas@kernel.org> wrote: > Seems overkill to mention "rcar" and "pci" twice in the subject. We > have so far not distinguished pcie-rcar-host.c and pcie-rcar-ep.c in > subject lines. > > If we want to start doing that consistently, maybe we could use "PCI: > rcar-host:" and "PCI: rcar-ep:" as we have done for cadence-ep and > designware-ep. I know. But this is for PCIe, and there's also pci-rcar-gen2 for traditional PCI. > On Fri, Oct 01, 2021 at 02:16:43PM +0200, Geert Uytterhoeven wrote: > > Remove includes that are not needed, to speed up (re)compilation. > > ... Gr{oetje,eeting}s, Geert
On Sat, Oct 02, 2021 at 08:22:13PM +0200, Geert Uytterhoeven wrote: > Hi Bjorn, > > On Sat, Oct 2, 2021 at 6:00 PM Bjorn Helgaas <helgaas@kernel.org> wrote: > > Seems overkill to mention "rcar" and "pci" twice in the subject. We > > have so far not distinguished pcie-rcar-host.c and pcie-rcar-ep.c in > > subject lines. > > > > If we want to start doing that consistently, maybe we could use "PCI: > > rcar-host:" and "PCI: rcar-ep:" as we have done for cadence-ep and > > designware-ep. > > I know. But this is for PCIe, and there's also pci-rcar-gen2 for traditional > PCI. We do have a precedent of "rcar-gen2" for that driver: $ git log --oneline drivers/pci/controller/pci-rcar-gen2.c df561f6688fe treewide: Use fallthrough pseudo-keyword 669cbc708122 PCI: Move DT resource setup into devm_pci_alloc_host_bridge() 4a957563fe02 PCI: rcar-gen2: Convert to use modern host bridge probe functions 6e0832fa432e PCI: Collect all native drivers under drivers/pci/controller/ $ git log --oneline -- drivers/pci/host/pci-rcar-gen2.c 6e0832fa432e ("PCI: Collect all native drivers under drivers/pci/controller/") 9e2aee80c78d ("PCI: Move private DT related functions into private header") 38b35992b7d2 ("PCI: rcar-gen2: Remove duplicated bit-wise or of RCAR_PCI_INT_SIGRETABORT") 8cfab3cf63cf ("PCI: Add SPDX GPL-2.0 to replace GPL v2 boilerplate") 1e61a57cac56 ("PCI: Use of_pci_dma_range_parser_init() to reduce duplication") bf44167f37a1 ("PCI: rcar-gen2: Make of_device_ids const") 7b99d94277ba ("PCI: rcar-gen2: Use gen2 fallback compatibility last") de9e6bc84b7e ("PCI: rcar-gen2: Add local struct device pointers") 0b9c158925b2 ("PCI: rcar-gen2: Make explicitly non-modular") ac575ead871f ("PCI: rcar Gen2: Request host bridge window resources") b2a5d3e2cf65 ("PCI: rcar: Drop gen2 dummy I/O port region") 3517652fda51 ("PCI: rcar: Add gen2 fallback compatibility string for pci-rcar-gen2") 8d598cabf50d ("PCI: rcar: Allow DT to override default window settings") de24c18c0fac ("PCI: rcar: Add R8A7794 support") 7a27db23a3f6 ("PCI: rcar: Verify that mem_res is 64K-aligned") b44923b78d11 ("PCI: rcar: Convert to use generic config accessors") e27a5130ab64 ("pci: host: drop owner assignment from platform_drivers") d47b62f4b1c0 ("PCI: rcar: Add gen2 device tree support") b9bfe1bca8ec ("PCI: rcar: Use new OF interrupt mapping when possible") 33966fd9b5bc ("PCI: rcar: Break out window size handling") 546cadda3575 ("PCI: rcar: Register each instance independently") e64a2a973e17 ("PCI: rcar: Fix bridge logic configuration accesses") 80a595d941a2 ("PCI: rcar: Add error interrupt handling") ed65b78881c7 ("PCI: rcar: Check platform_get_irq() return code") fb178d8b2fab ("PCI: rcar: Add runtime PM support") c176d1c71bd1 ("PCI: rcar: Fix rcar_pci_probe() return value check") ba3eb9fce315 ("PCI: Add R-Car Gen2 internal PCI support") > > On Fri, Oct 01, 2021 at 02:16:43PM +0200, Geert Uytterhoeven wrote: > > > Remove includes that are not needed, to speed up (re)compilation. > > > ... > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
Hi Bjorn, On Sat, Oct 2, 2021 at 9:01 PM Bjorn Helgaas <helgaas@kernel.org> wrote: > On Sat, Oct 02, 2021 at 08:22:13PM +0200, Geert Uytterhoeven wrote: > > On Sat, Oct 2, 2021 at 6:00 PM Bjorn Helgaas <helgaas@kernel.org> wrote: > > > Seems overkill to mention "rcar" and "pci" twice in the subject. We > > > have so far not distinguished pcie-rcar-host.c and pcie-rcar-ep.c in > > > subject lines. > > > > > > If we want to start doing that consistently, maybe we could use "PCI: > > > rcar-host:" and "PCI: rcar-ep:" as we have done for cadence-ep and > > > designware-ep. > > > > I know. But this is for PCIe, and there's also pci-rcar-gen2 for traditional > > PCI. > > We do have a precedent of "rcar-gen2" for that driver: Feel free to change the prefix while applying. Or ask for a resend, and risk me not changing it to your liking again ;-) Thanks! Gr{oetje,eeting}s, Geert
On Fri, 1 Oct 2021 14:16:43 +0200, Geert Uytterhoeven wrote: > Remove includes that are not needed, to speed up (re)compilation. > > Most of these are relics from splitting the driver in a host and a > common part. > > Applied to pci/rcar, thanks! [1/1] PCI: rcar: pcie-rcar-host: Remove unneeded includes https://git.kernel.org/lpieralisi/pci/c/38d79c556f Thanks, Lorenzo
diff --git a/drivers/pci/controller/pcie-rcar-host.c b/drivers/pci/controller/pcie-rcar-host.c index 8f3131844e7778cf..e12c2d8be05a34e2 100644 --- a/drivers/pci/controller/pcie-rcar-host.c +++ b/drivers/pci/controller/pcie-rcar-host.c @@ -24,13 +24,11 @@ #include <linux/msi.h> #include <linux/of_address.h> #include <linux/of_irq.h> -#include <linux/of_pci.h> #include <linux/of_platform.h> #include <linux/pci.h> #include <linux/phy/phy.h> #include <linux/platform_device.h> #include <linux/pm_runtime.h> -#include <linux/slab.h> #include "pcie-rcar.h"
Remove includes that are not needed, to speed up (re)compilation. Most of these are relics from splitting the driver in a host and a common part. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/pci/controller/pcie-rcar-host.c | 2 -- 1 file changed, 2 deletions(-)