mbox series

[v2,0/5] Switchtec Fixes and Improvements

Message ID 20211014141859.11444-1-kelvin.cao@microchip.com (mailing list archive)
Headers show
Series Switchtec Fixes and Improvements | expand

Message

Kelvin Cao Oct. 14, 2021, 2:18 p.m. UTC
From: Kelvin Cao <kelvin.cao@microchip.com>

Hi,

This patchset is mainly for improving the commit message of [PATCH 1/5]
in v1[1] to elaborate the root cause, together with a function renaming
and some other tweaks.

This patchset is based on v5.15-rc5.

Thanks,
Kelvin

[1] https://lore.kernel.org/lkml/20210924110842.6323-1-kelvin.cao@microchip.com/

Changes since v1:
- Rebase on 5.15-rc5
- Tweak some comment spacing (as suggested by Bjorn)
- Update commit message to elaborate the root cause of MRPC execution
  hanging (as suggested by Bjorn)
- Rename function check_access() to is_firmware_running()
  (as suggested by Logan) so the function name suggests the meaning of
  the return values (as suggested by Bjorn)
- Add comment to function is_firmware_running() (as suggested by Logan)


Kelvin Cao (4):
  PCI/switchtec: Error out MRPC execution when MMIO reads fail
  PCI/switchtec: Fix a MRPC error status handling issue
  PCI/switchtec: Update the way of getting management VEP instance ID
  PCI/switchtec: Replace ENOTSUPP with EOPNOTSUPP

Logan Gunthorpe (1):
  PCI/switchtec: Add check of event support

 drivers/pci/switch/switchtec.c | 95 ++++++++++++++++++++++++++++------
 include/linux/switchtec.h      |  1 +
 2 files changed, 79 insertions(+), 17 deletions(-)

Comments

Bjorn Helgaas Oct. 14, 2021, 2:47 p.m. UTC | #1
On Thu, Oct 14, 2021 at 02:18:54PM +0000, kelvin.cao@microchip.com wrote:
> From: Kelvin Cao <kelvin.cao@microchip.com>
> 
> Hi,
> 
> This patchset is mainly for improving the commit message of [PATCH 1/5]
> in v1[1] to elaborate the root cause, together with a function renaming
> and some other tweaks.
> 
> This patchset is based on v5.15-rc5.

Applied, replacing the previous set, thanks!

> [1] https://lore.kernel.org/lkml/20210924110842.6323-1-kelvin.cao@microchip.com/
> 
> Changes since v1:
> - Rebase on 5.15-rc5
> - Tweak some comment spacing (as suggested by Bjorn)
> - Update commit message to elaborate the root cause of MRPC execution
>   hanging (as suggested by Bjorn)
> - Rename function check_access() to is_firmware_running()
>   (as suggested by Logan) so the function name suggests the meaning of
>   the return values (as suggested by Bjorn)
> - Add comment to function is_firmware_running() (as suggested by Logan)
> 
> 
> Kelvin Cao (4):
>   PCI/switchtec: Error out MRPC execution when MMIO reads fail
>   PCI/switchtec: Fix a MRPC error status handling issue
>   PCI/switchtec: Update the way of getting management VEP instance ID
>   PCI/switchtec: Replace ENOTSUPP with EOPNOTSUPP
> 
> Logan Gunthorpe (1):
>   PCI/switchtec: Add check of event support
> 
>  drivers/pci/switch/switchtec.c | 95 ++++++++++++++++++++++++++++------
>  include/linux/switchtec.h      |  1 +
>  2 files changed, 79 insertions(+), 17 deletions(-)
> 
> -- 
> 2.25.1
>
Kelvin Cao Oct. 14, 2021, 9:19 p.m. UTC | #2
On Thu, 2021-10-14 at 09:47 -0500, Bjorn Helgaas wrote:
> On Thu, Oct 14, 2021 at 02:18:54PM +0000, kelvin.cao@microchip.com
> wrote:
> > From: Kelvin Cao <kelvin.cao@microchip.com>
> > 
> > Hi,
> > 
> > This patchset is mainly for improving the commit message of [PATCH
> > 1/5]
> > in v1[1] to elaborate the root cause, together with a function
> > renaming
> > and some other tweaks.
> > 
> > This patchset is based on v5.15-rc5.
> 
> Applied, replacing the previous set, thanks!

Thank you Bjorn!
> 
> > [1] 
> > https://lore.kernel.org/lkml/20210924110842.6323-1-kelvin.cao@microchip.com/
> > 
> > Changes since v1:
> > - Rebase on 5.15-rc5
> > - Tweak some comment spacing (as suggested by Bjorn)
> > - Update commit message to elaborate the root cause of MRPC
> > execution
> >   hanging (as suggested by Bjorn)
> > - Rename function check_access() to is_firmware_running()
> >   (as suggested by Logan) so the function name suggests the meaning
> > of
> >   the return values (as suggested by Bjorn)
> > - Add comment to function is_firmware_running() (as suggested by
> > Logan)
> > 
> > 
> > Kelvin Cao (4):
> >   PCI/switchtec: Error out MRPC execution when MMIO reads fail
> >   PCI/switchtec: Fix a MRPC error status handling issue
> >   PCI/switchtec: Update the way of getting management VEP instance
> > ID
> >   PCI/switchtec: Replace ENOTSUPP with EOPNOTSUPP
> > 
> > Logan Gunthorpe (1):
> >   PCI/switchtec: Add check of event support
> > 
> >  drivers/pci/switch/switchtec.c | 95 ++++++++++++++++++++++++++++
> > ------
> >  include/linux/switchtec.h      |  1 +
> >  2 files changed, 79 insertions(+), 17 deletions(-)
> > 
> > --
> > 2.25.1
> >