| Message ID | 20211012221144.30638-1-rikard.falkeborn@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | staging: media: rkvdec: Constify static struct v4l2_m2m_ops | expand |
On Wed, Oct 13, 2021 at 12:11:44AM +0200, Rikard Falkeborn wrote: > The only usage of rkvdec_m2m_ops is to pass its address to v4l2_m2m_init(), > which takes a pointer to const v4l2_m2m_ops as argument. Make it const > to allow the compiler to put it in read-only memory. > > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> Reviewed-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> > --- > drivers/staging/media/rkvdec/rkvdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c > index bf00fe6534a3..28aab5c7fe33 100644 > --- a/drivers/staging/media/rkvdec/rkvdec.c > +++ b/drivers/staging/media/rkvdec/rkvdec.c > @@ -677,7 +677,7 @@ static void rkvdec_device_run(void *priv) > rkvdec_job_finish(ctx, VB2_BUF_STATE_ERROR); > } > > -static struct v4l2_m2m_ops rkvdec_m2m_ops = { > +static const struct v4l2_m2m_ops rkvdec_m2m_ops = { > .device_run = rkvdec_device_run, > }; > > -- > 2.33.0 >
Quoting Rikard Falkeborn (2021-10-12 23:11:44) > The only usage of rkvdec_m2m_ops is to pass its address to v4l2_m2m_init(), > which takes a pointer to const v4l2_m2m_ops as argument. Make it const > to allow the compiler to put it in read-only memory. > > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > --- > drivers/staging/media/rkvdec/rkvdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c > index bf00fe6534a3..28aab5c7fe33 100644 > --- a/drivers/staging/media/rkvdec/rkvdec.c > +++ b/drivers/staging/media/rkvdec/rkvdec.c > @@ -677,7 +677,7 @@ static void rkvdec_device_run(void *priv) > rkvdec_job_finish(ctx, VB2_BUF_STATE_ERROR); > } > > -static struct v4l2_m2m_ops rkvdec_m2m_ops = { > +static const struct v4l2_m2m_ops rkvdec_m2m_ops = { > .device_run = rkvdec_device_run, > }; > > -- > 2.33.0 >
diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c index bf00fe6534a3..28aab5c7fe33 100644 --- a/drivers/staging/media/rkvdec/rkvdec.c +++ b/drivers/staging/media/rkvdec/rkvdec.c @@ -677,7 +677,7 @@ static void rkvdec_device_run(void *priv) rkvdec_job_finish(ctx, VB2_BUF_STATE_ERROR); } -static struct v4l2_m2m_ops rkvdec_m2m_ops = { +static const struct v4l2_m2m_ops rkvdec_m2m_ops = { .device_run = rkvdec_device_run, };
The only usage of rkvdec_m2m_ops is to pass its address to v4l2_m2m_init(), which takes a pointer to const v4l2_m2m_ops as argument. Make it const to allow the compiler to put it in read-only memory. Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> --- drivers/staging/media/rkvdec/rkvdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)