| Message ID | 20210920130248.145058-1-krzysztof.kozlowski@canonical.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RESEND,v2,1/5] riscv: dts: sifive: use only generic JEDEC SPI NOR flash compatible | expand |
hi Krzysztof, On Mon, Sep 20, 2021 at 3:05 PM Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote: > > The compatible "issi,is25wp256" is undocumented and instead only a > generic jedec,spi-nor should be used (if appropriate). Why not do it the other way around? I mean adding this compatible to the expected list: don't we lose information using the generic compatible? Thanks, Alex > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > > --- > > Changes since v1: > 1. New patch > --- > arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 2 +- > arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts > index 60846e88ae4b..633b31b6e25c 100644 > --- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts > +++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts > @@ -63,7 +63,7 @@ &i2c0 { > &qspi0 { > status = "okay"; > flash@0 { > - compatible = "issi,is25wp256", "jedec,spi-nor"; > + compatible = "jedec,spi-nor"; > reg = <0>; > spi-max-frequency = <50000000>; > m25p,fast-read; > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > index 2e4ea84f27e7..9b0b9b85040e 100644 > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > @@ -211,7 +211,7 @@ vdd_ldo11: ldo11 { > &qspi0 { > status = "okay"; > flash@0 { > - compatible = "issi,is25wp256", "jedec,spi-nor"; > + compatible = "jedec,spi-nor"; > reg = <0>; > spi-max-frequency = <50000000>; > m25p,fast-read; > -- > 2.30.2 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv
On 12/10/2021 06:29, Alexandre Ghiti wrote: > hi Krzysztof, > > On Mon, Sep 20, 2021 at 3:05 PM Krzysztof Kozlowski > <krzysztof.kozlowski@canonical.com> wrote: >> >> The compatible "issi,is25wp256" is undocumented and instead only a >> generic jedec,spi-nor should be used (if appropriate). > > Why not do it the other way around? I mean adding this compatible to > the expected list: don't we lose information using the generic > compatible? > > Thanks, > We discussed it: https://lore.kernel.org/lkml/ae4c58fe-0af5-3f1d-cc16-27b78772cbb5@microchip.com/ Best regards, Krzysztof
On 20/09/2021 15:02, Krzysztof Kozlowski wrote: > The compatible "issi,is25wp256" is undocumented and instead only a > generic jedec,spi-nor should be used (if appropriate). > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > > --- > > Changes since v1: > 1. New patch > --- > arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 2 +- > arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > Hi Paul and Palmer, This set is waiting for quite a long. Do you pick DTS patches for Risc-v or shall I send it to Arnd/Olof directly? I can do it, but it would be great to have a confirmation of such merging path. Best regards, Krzysztof
On Mon, 20 Sep 2021 15:02:44 +0200, Krzysztof Kozlowski wrote: > The compatible "issi,is25wp256" is undocumented and instead only a > generic jedec,spi-nor should be used (if appropriate). > > Applied, thanks! [1/5] riscv: dts: sifive: use only generic JEDEC SPI NOR flash compatible commit: 8ce936c2f1a68c3a4f46578eed016ff92a67fbc6 [2/5] riscv: dts: sifive: fix Unleashed board compatible commit: 65b2979d52ebf96ed8261d82d84c62acf737548d [3/5] riscv: dts: sifive: drop duplicated nodes and properties in sifive commit: 20ce65bf89aab248886b80d1e7fa12277b2a0f2d [4/5] riscv: dts: microchip: add missing compatibles for clint and plic commit: 73d3c44115514616ee9c4f356bb86d4426d0fc36 [5/5] riscv: dts: sifive: add missing compatible for plic commit: 9962a066f3c1d4588d0dd876ceac2c03ef87acf3 Best regards,
diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts index 60846e88ae4b..633b31b6e25c 100644 --- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts +++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts @@ -63,7 +63,7 @@ &i2c0 { &qspi0 { status = "okay"; flash@0 { - compatible = "issi,is25wp256", "jedec,spi-nor"; + compatible = "jedec,spi-nor"; reg = <0>; spi-max-frequency = <50000000>; m25p,fast-read; diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts index 2e4ea84f27e7..9b0b9b85040e 100644 --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts @@ -211,7 +211,7 @@ vdd_ldo11: ldo11 { &qspi0 { status = "okay"; flash@0 { - compatible = "issi,is25wp256", "jedec,spi-nor"; + compatible = "jedec,spi-nor"; reg = <0>; spi-max-frequency = <50000000>; m25p,fast-read;
The compatible "issi,is25wp256" is undocumented and instead only a generic jedec,spi-nor should be used (if appropriate). Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- Changes since v1: 1. New patch --- arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 2 +- arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)