Message ID | 1a3d63a3-c020-3319-26f6-a2ec338cc42e@gmail.com (mailing list archive) |
---|---|
State | Mainlined, archived |
Commit | 4bdb00edbd2ae354471f8d37d976a864bf29b60f |
Headers | show |
Series | [GIT,PULL] arm64: dts64: mediatek updates for v5.16 | expand |
On Mon, Oct 11, 2021 at 11:58 AM Matthias Brugger <matthias.bgg@gmail.com> wrote: > > Hi Arnd and Olof, > > Here come the latest updates for arm64 DTS cahgnes. > Biggest change is, that we have now support for a reset controller inside the > mmsys. This goes inhand with changes to the driver, that you will find in the > soc pull request. > > > arm64: dts: mt8183: Add the mmsys reset bit to reset the dsi0 (2021-10-08 > 15:11:14 +0200) > > ---------------------------------------------------------------- > - mt8173: add reset for dsi0 to mmsys > - move dt-bindings reset controller includes to correct folder > - split PCIe node to use new format for mt2712 and mt7622 > - mt8183: add audio node to chromebook devices > - mt8192: add clock controller node I skipped this one for now, need some clarification. The PCIe node looks like you are doing an incompatible change to the DT binding, but that is something that should be explained in the tag description or (ideally) avoided if at all possible. Did I misread that patch, or did you forget about it here? On a related note, the tag description should better have full sentences like your introductory text above it, that makes for a better changelog text in the end. Enumerating all the changes is not helpful here because the list of commits is also part of the changeset description after I commit it. Arnd
On 11/10/2021 22:34, Arnd Bergmann wrote: > On Mon, Oct 11, 2021 at 11:58 AM Matthias Brugger > <matthias.bgg@gmail.com> wrote: >> >> Hi Arnd and Olof, >> >> Here come the latest updates for arm64 DTS cahgnes. >> Biggest change is, that we have now support for a reset controller inside the >> mmsys. This goes inhand with changes to the driver, that you will find in the >> soc pull request. >> >> >> arm64: dts: mt8183: Add the mmsys reset bit to reset the dsi0 (2021-10-08 >> 15:11:14 +0200) >> >> ---------------------------------------------------------------- >> - mt8173: add reset for dsi0 to mmsys >> - move dt-bindings reset controller includes to correct folder >> - split PCIe node to use new format for mt2712 and mt7622 >> - mt8183: add audio node to chromebook devices >> - mt8192: add clock controller node > > I skipped this one for now, need some clarification. The PCIe node > looks like you are doing an incompatible change to the DT binding, > but that is something that should be explained in the tag description > or (ideally) avoided if at all possible. > Mediatek PCI device tree binding described the root port in a wrong. The IP actaully implements several root complex with everyone having a single root port. We need to fix the DT in an incompatible way to describe the HW as it is. This also fixes a problem that no IRQ bigger then 32 could be handled. The only public available HW that is affected by this is the BananaPi R64. I'm not aware that there is a big user base using the upstream kernel. In this boards PCI is only used for extension cards, so I don't expect any boot problems. > Did I misread that patch, or did you forget about it here? > > On a related note, the tag description should better have full > sentences like your introductory text above it, that makes for > a better changelog text in the end. Enumerating all the changes > is not helpful here because the list of commits is also part of > the changeset description after I commit it. > Got it, I'll write a full sentence description I use to do for the pull request emails in the tag. Regards, Matthias
From: Arnd Bergmann <arnd@arndb.de> On Mon, 11 Oct 2021 11:58:34 +0200, Matthias Brugger wrote: > Here come the latest updates for arm64 DTS cahgnes. > Biggest change is, that we have now support for a reset controller inside the > mmsys. This goes inhand with changes to the driver, that you will find in the > soc pull request. > > Please have a look. > > Regards, > Matthias Merged into arm/dt, thanks! merge commit: ba232d398aee515ee0f8d046ba391f03bed49bfa Arnd