mbox series

[v2,00/14] mailbox: pcc: Add support for PCCT extended PCC subspaces

Message ID 20210917133357.1911092-1-sudeep.holla@arm.com (mailing list archive)
Headers show
Series mailbox: pcc: Add support for PCCT extended PCC subspaces | expand

Message

Sudeep Holla Sept. 17, 2021, 1:33 p.m. UTC
Hi,

Though the series is about adding support for PCCT extended PCC subspaces,
except one patch, remaining are either preparatory or clean up to add
the PCCT extended PCC subspaces. Only patch 12 adds the support of extended
PCC type3/4 subspaces.

The main change affecting your is the change in pcc_mbox_request_channel
to avoid clien driver using con_priv member which is designed for controller
private pointer rather than for client's to use that.

Shared memory region accesses could be consolidated but I am planning to
take that up later as some drivers are using different types of mappings,
yet to figure out on how to consolidate that aspect.

Regards,
Sudeep

v1->v2:
	- Addressed comments from Cristian and added his review tags as
	  provided

Sudeep Holla (14):
  mailbox: pcc: Fix kernel doc warnings
  ACPI: CPPC: Fix kernel doc warnings
  mailbox: pcc: Refactor all PCC channel information into a structure
  mailbox: pcc: Consolidate subspace interrupt information parsing
  mailbox: pcc: Consolidate subspace doorbell register parsing
  mailbox: pcc: Add pcc_mbox_chan structure to hold shared memory region info
  mailbox: pcc: Use PCC mailbox channel pointer instead of standard
  mailbox: pcc: Rename doorbell ack to platform interrupt ack register
  mailbox: pcc: Add PCC register bundle and associated accessor functions
  mailbox: pcc: Avoid accessing PCCT table in pcc_send_data and pcc_mbox_irq
  mailbox: pcc: Drop handling invalid bit-width in {read,write}_register
  mailbox: pcc: Add support for PCCT extended PCC subspaces(type 3/4)
  mailbox: pcc: Move bulk of PCCT parsing into pcc_mbox_probe
  ACPI/PCC: Add myself as maintainer for PCC mailbox driver

 MAINTAINERS                            |   6 +
 drivers/acpi/cppc_acpi.c               |  50 +--
 drivers/hwmon/xgene-hwmon.c            |  35 +-
 drivers/i2c/busses/i2c-xgene-slimpro.c |  33 +-
 drivers/mailbox/pcc.c                  | 598 +++++++++++++++----------
 include/acpi/pcc.h                     |  21 +-
 6 files changed, 436 insertions(+), 307 deletions(-)

--
2.25.1

Comments

Sudeep Holla Oct. 11, 2021, 10:09 a.m. UTC | #1
Hi Jassi,

On Fri, Sep 17, 2021 at 02:33:43PM +0100, Sudeep Holla wrote:
> Hi,
> 
> Though the series is about adding support for PCCT extended PCC subspaces,
> except one patch, remaining are either preparatory or clean up to add
> the PCCT extended PCC subspaces. Only patch 12 adds the support of extended
> PCC type3/4 subspaces.
> 
> The main change affecting your is the change in pcc_mbox_request_channel
> to avoid clien driver using con_priv member which is designed for controller
> private pointer rather than for client's to use that.
> 

Once I have ack from Guenter, is it OK to get this merged via mailbox tree.
Rafael is happy for me to maintain this PCC part of ACPI. Do you prefer
to merge patches directly or do you prefer pull request ? Let me know.
Sudeep Holla Oct. 21, 2021, 4:54 p.m. UTC | #2
Hi Jassi,

Gentle ping!

On Mon, Oct 11, 2021 at 11:09:49AM +0100, Sudeep Holla wrote:
> Hi Jassi,
> 
> On Fri, Sep 17, 2021 at 02:33:43PM +0100, Sudeep Holla wrote:
> > Hi,
> > 
> > Though the series is about adding support for PCCT extended PCC subspaces,
> > except one patch, remaining are either preparatory or clean up to add
> > the PCCT extended PCC subspaces. Only patch 12 adds the support of extended
> > PCC type3/4 subspaces.
> > 
> > The main change affecting your is the change in pcc_mbox_request_channel
> > to avoid clien driver using con_priv member which is designed for controller
> > private pointer rather than for client's to use that.
> > 
> 
> Once I have ack from Guenter, is it OK to get this merged via mailbox tree.
> Rafael is happy for me to maintain this PCC part of ACPI. Do you prefer
> to merge patches directly or do you prefer pull request ? Let me know.
> 
> -- 
> Regards,
> Sudeep
Jassi Brar Oct. 22, 2021, 3:05 p.m. UTC | #3
On Thu, Oct 21, 2021 at 11:54 AM Sudeep Holla <sudeep.holla@arm.com> wrote:
>
> Hi Jassi,
>
> Gentle ping!
>
I'll pick them.

thanks.
Sudeep Holla Oct. 22, 2021, 5:09 p.m. UTC | #4
On Fri, Oct 22, 2021 at 10:05:52AM -0500, Jassi Brar wrote:
> On Thu, Oct 21, 2021 at 11:54 AM Sudeep Holla <sudeep.holla@arm.com> wrote:
> >
> > Hi Jassi,
> >
> > Gentle ping!
> >
> I'll pick them.
> 
> thanks.

Thanks, you can drop 02/14. I will ask Rafael you pick that up once he is
happy with it.