[RFC,v3,12/12] Simplify dependencies for MODULE_SIG_KEY_TYPE_RSA & MODULE_SIG_KEY_TYPE_ECDSA

Commit Message

Thorsten Berger Oct. 22, 2021, 1:48 p.m. UTC

Co-developed-by: Patrick Franz <[e-mail]>
Signed-off-by: Patrick Franz <[e-mail]>
Co-developed-by: Ibrahim Fayaz <[e-mail]>
Signed-off-by: Ibrahim Fayaz <[e-mail]>
Reviewed-by: Luis Chamberlain <[e-mail]>
Tested-by: Evgeny Groshev <[e-mail]>
Suggested-by: Sarah Nadi <[e-mail]>
Suggested-by: Thorsten Berger <[e-mail]>
Signed-off-by: Thorsten Berger <[e-mail]>

This choice group presents a problem as it is possible that no option can be
chosen when the choice group is visible.
Every option contains additional dependencies compared to the group. Hence it
is possible that the group is visible, but not a single option can be chosen
as these additional dependencies are not satisfied.
By moving these additional dependencies from the options into the group, a
visible choice group ensures that both options can be chosen.

---
 certs/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Luis Chamberlain Oct. 22, 2021, 5:03 p.m. UTC | #1

On Fri, Oct 22, 2021 at 03:48:55PM +0200, Thorsten Berger wrote:
> Co-developed-by: Patrick Franz <[e-mail]>
> Signed-off-by: Patrick Franz <[e-mail]>
> Co-developed-by: Ibrahim Fayaz <[e-mail]>
> Signed-off-by: Ibrahim Fayaz <[e-mail]>
> Reviewed-by: Luis Chamberlain <[e-mail]>
> Tested-by: Evgeny Groshev <[e-mail]>
> Suggested-by: Sarah Nadi <[e-mail]>
> Suggested-by: Thorsten Berger <[e-mail]>
> Signed-off-by: Thorsten Berger <[e-mail]>
> 
> This choice group presents a problem as it is possible that no option can be
> chosen when the choice group is visible.
> Every option contains additional dependencies compared to the group. Hence it
> is possible that the group is visible, but not a single option can be chosen
> as these additional dependencies are not satisfied.
> By moving these additional dependencies from the options into the group, a
> visible choice group ensures that both options can be chosen.
> 

Re-arrange so that description goes first and then you put the SOB tags
/ Reviewed-by tags.

Also, be sure to use ./scripts/get_maintainer.pl foo.patch, and when you
send your patches on v4, please add all the emails you collect to the
target audience. This patch in particular should be reviewed by folks
who maintain the file being changed. Please also cc [e-mail]
on your patch set.

  Luis

Patch

diff --git a/certs/Kconfig b/certs/Kconfig
index ae7f2e876a31..f69c92e5bc30 100644
--- a/certs/Kconfig
+++ b/certs/Kconfig
@@ -17,6 +17,7 @@  config MODULE_SIG_KEY
 
 choice
     prompt "Type of module signing key to be generated"
+    depends on MODULE_SIG || (IMA_APPRAISE_MODSIG && MODULES)
     default MODULE_SIG_KEY_TYPE_RSA
     help
      The type of module signing key type to generate. This option
@@ -24,14 +25,12 @@  choice
 
 config MODULE_SIG_KEY_TYPE_RSA
     bool "RSA"
-    depends on MODULE_SIG || (IMA_APPRAISE_MODSIG && MODULES)
     help
      Use an RSA key for module signing.
 
 config MODULE_SIG_KEY_TYPE_ECDSA
     bool "ECDSA"
     select CRYPTO_ECDSA
-    depends on MODULE_SIG || (IMA_APPRAISE_MODSIG && MODULES)
     help
      Use an elliptic curve key (NIST P384) for module signing. Consider
      using a strong hash like sha256 or sha384 for hashing modules.