diff mbox series

[1/1] Revert "wcn36xx: Enable firmware link monitoring"

Message ID 20211022141008.2846454-2-bryan.odonoghue@linaro.org (mailing list archive)
State Changes Requested
Delegated to: Kalle Valo
Headers show
Series wcn36xx: Revert firmware link monitoring | expand

Commit Message

Bryan O'Donoghue Oct. 22, 2021, 2:10 p.m. UTC 
This reverts commit c973fdad79f6eaf247d48b5fc77733e989eb01e1.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Benjamin Li <benl@squareup.com>
---
 drivers/net/wireless/ath/wcn36xx/main.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Loic Poulain Oct. 22, 2021, 3:05 p.m. UTC | #1 
On Fri, 22 Oct 2021 at 16:08, Bryan O'Donoghue
<bryan.odonoghue@linaro.org> wrote:
>
> This reverts commit c973fdad79f6eaf247d48b5fc77733e989eb01e1.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Signed-off-by: Benjamin Li <benl@squareup.com>

Should it get a 'Fixes' tag?

Regards,
Loic

> ---
>  drivers/net/wireless/ath/wcn36xx/main.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c
> index dd8810fd76a3d..fd8b2753da7dd 100644
> --- a/drivers/net/wireless/ath/wcn36xx/main.c
> +++ b/drivers/net/wireless/ath/wcn36xx/main.c
> @@ -1334,7 +1334,6 @@ static int wcn36xx_init_ieee80211(struct wcn36xx *wcn)
>         ieee80211_hw_set(wcn->hw, HAS_RATE_CONTROL);
>         ieee80211_hw_set(wcn->hw, SINGLE_SCAN_ON_ALL_BANDS);
>         ieee80211_hw_set(wcn->hw, REPORTS_TX_ACK_STATUS);
> -       ieee80211_hw_set(wcn->hw, CONNECTION_MONITOR);
>
>         wcn->hw->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION) |
>                 BIT(NL80211_IFTYPE_AP) |
> --
> 2.33.0
>
Kalle Valo Oct. 25, 2021, 8:54 a.m. UTC | #2 
Loic Poulain <loic.poulain@linaro.org> writes:

> On Fri, 22 Oct 2021 at 16:08, Bryan O'Donoghue
> <bryan.odonoghue@linaro.org> wrote:
>>
>> This reverts commit c973fdad79f6eaf247d48b5fc77733e989eb01e1.
>>
>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> Signed-off-by: Benjamin Li <benl@squareup.com>
>
> Should it get a 'Fixes' tag?

But this patch is not really fixing anything, right? I wonder if there's
patch 2 missing?
Kalle Valo Oct. 25, 2021, 8:55 a.m. UTC | #3 
Bryan O'Donoghue <bryan.odonoghue@linaro.org> writes:

> This reverts commit c973fdad79f6eaf247d48b5fc77733e989eb01e1.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

The commit log should answer to question "why?". Please move the
explanation from the cover email to the commit log.

> Signed-off-by: Benjamin Li <benl@squareup.com>

Why Benjamin's s-o-b?
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c
index dd8810fd76a3d..fd8b2753da7dd 100644
--- a/drivers/net/wireless/ath/wcn36xx/main.c
+++ b/drivers/net/wireless/ath/wcn36xx/main.c
@@ -1334,7 +1334,6 @@  static int wcn36xx_init_ieee80211(struct wcn36xx *wcn)
 	ieee80211_hw_set(wcn->hw, HAS_RATE_CONTROL);
 	ieee80211_hw_set(wcn->hw, SINGLE_SCAN_ON_ALL_BANDS);
 	ieee80211_hw_set(wcn->hw, REPORTS_TX_ACK_STATUS);
-	ieee80211_hw_set(wcn->hw, CONNECTION_MONITOR);
 
 	wcn->hw->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION) |
 		BIT(NL80211_IFTYPE_AP) |