[2/2] MAINTAINERS: Mark VMware mailing list entries as private

Commit Message

Srivatsa S. Bhat Nov. 8, 2021, 8:30 p.m. UTC

From: Srivatsa S. Bhat (VMware) <[e-mail]>

VMware mailing lists in the MAINTAINERS file are private lists meant
for VMware-internal review/notification for patches to the respective
subsystems. So, in an earlier discussion [1][2], it was recommended to
mark them as such. Update all the remaining VMware mailing list
references to use that format -- "L: list@address (private)".

[1]. https://lore.kernel.org/r/[e-mail]
[2]. https://lore.kernel.org/r/[e-mail]

Signed-off-by: Srivatsa S. Bhat (VMware) <[e-mail]>
Cc: Nadav Amit <[e-mail]>
Cc: Vivek Thampi <[e-mail]>
Cc: Vishal Bhakta <[e-mail]>
Cc: Ronak Doshi <[e-mail]>
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Acked-by: Zack Rusin <[e-mail]>
---

 MAINTAINERS |   16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

Comments

Nadav Amit Nov. 8, 2021, 8:45 p.m. UTC | #1

> On Nov 8, 2021, at 12:30 PM, Srivatsa S. Bhat <[e-mail]> wrote:
> 
> From: Srivatsa S. Bhat (VMware) <[e-mail]>
> 
> VMware mailing lists in the MAINTAINERS file are private lists meant
> for VMware-internal review/notification for patches to the respective
> subsystems. So, in an earlier discussion [1][2], it was recommended to
> mark them as such. Update all the remaining VMware mailing list
> references to use that format -- "L: list@address (private)”.

Acked-by: Nadav Amit <[e-mail]>

Joe Perches Nov. 8, 2021, 11:37 p.m. UTC | #2

On Mon, 2021-11-08 at 12:30 -0800, Srivatsa S. Bhat wrote:
> From: Srivatsa S. Bhat (VMware) <[e-mail]>
> 
> VMware mailing lists in the MAINTAINERS file are private lists meant
> for VMware-internal review/notification for patches to the respective
> subsystems. So, in an earlier discussion [1][2], it was recommended to
> mark them as such. Update all the remaining VMware mailing list
> references to use that format -- "L: list@address (private)".
[]
> diff --git a/MAINTAINERS b/MAINTAINERS
[]
> @@ -6134,8 +6134,8 @@ T:	git git://anongit.freedesktop.org/drm/drm-misc
>  F:	drivers/gpu/drm/vboxvideo/
>  
>  DRM DRIVER FOR VMWARE VIRTUAL GPU
> -M:	"VMware Graphics" <[e-mail]>
>  M:	Zack Rusin <[e-mail]>
> +L:	[e-mail] (private)

This MAINTAINERS file is for _public_ use, marking something
non-public isn't useful.

private makes no sense and likely these L: entries shouldn't exist.

Jakub Kicinski Nov. 9, 2021, 12:16 a.m. UTC | #3

On Mon, 08 Nov 2021 15:37:53 -0800 Joe Perches wrote:
> > @@ -6134,8 +6134,8 @@ T:	git git://anongit.freedesktop.org/drm/drm-misc
> >  F:	drivers/gpu/drm/vboxvideo/
> >  
> >  DRM DRIVER FOR VMWARE VIRTUAL GPU
> > -M:	"VMware Graphics" <[e-mail]>
> >  M:	Zack Rusin <[e-mail]>
> > +L:	[e-mail] (private)  
> 
> This MAINTAINERS file is for _public_ use, marking something
> non-public isn't useful.

But Greg has a point. Corporations like to send us code with a list 
as the maintainer and MODULE_AUTHOR set to corp's name. We deal with
humans, not legal entities.

I've been trying to get them to use "M: email" without the name,
but "L: list (private)" also works.

Either way I feel like we need _some_ way to tell humans from corporate
"please CC this address" entries.

> private makes no sense and likely these L: entries shouldn't exist.

Srivatsa S. Bhat Nov. 9, 2021, 12:22 a.m. UTC | #4

+Greg, Thomas

Hi Joe,

On 11/8/21 3:37 PM, Joe Perches wrote:
> On Mon, 2021-11-08 at 12:30 -0800, Srivatsa S. Bhat wrote:
>> From: Srivatsa S. Bhat (VMware) <[e-mail]>
>>
>> VMware mailing lists in the MAINTAINERS file are private lists meant
>> for VMware-internal review/notification for patches to the respective
>> subsystems. So, in an earlier discussion [1][2], it was recommended to
>> mark them as such. Update all the remaining VMware mailing list
>> references to use that format -- "L: list@address (private)".
> []
>> diff --git a/MAINTAINERS b/MAINTAINERS
> []
>> @@ -6134,8 +6134,8 @@ T:	git git://anongit.freedesktop.org/drm/drm-misc
>>  F:	drivers/gpu/drm/vboxvideo/
>>  
>>  DRM DRIVER FOR VMWARE VIRTUAL GPU
>> -M:	"VMware Graphics" <[e-mail]>
>>  M:	Zack Rusin <[e-mail]>
>> +L:	[e-mail] (private)
> 
> This MAINTAINERS file is for _public_ use, marking something
> non-public isn't useful.
> 
> private makes no sense and likely these L: entries shouldn't exist.
> 
> 

Well, the public can send messages to this list, but membership is
restricted.

In many ways, I believe this is similar to [e-mail], which is an
email alias that anyone can post to in order to reach the x86
maintainer community for patch review. I see [e-mail] listed as
both L: and M: in the MAINTAINERS file, among different entries.

Although the @vmware list ids refer to VMware-internal mailing lists
as opposed to email aliases, they serve a very similar purpose -- to
inform VMware folks about patches to the relevant subsystems.

Is there a consensus on how such lists should be specified? One
suggestion (from Greg in the email thread referenced above) was to
mark it as private, which is what this patch does. Maybe we can find a
better alternative?

How about specifying such lists using M: (indicating that this address
can be used to reach maintainers), as long as that is not the only M:
entry for a given subsystem (i.e., it includes real people's email id
as well)? I think that would address Greg's primary objection too from
that other thread (related to personal responsibility as maintainers).

Regards,
Srivatsa

Joe Perches Nov. 9, 2021, 12:22 a.m. UTC | #5

On Mon, 2021-11-08 at 16:16 -0800, Jakub Kicinski wrote:
> On Mon, 08 Nov 2021 15:37:53 -0800 Joe Perches wrote:
> > > @@ -6134,8 +6134,8 @@ T:	git git://anongit.freedesktop.org/drm/drm-misc
> > >  F:	drivers/gpu/drm/vboxvideo/
> > >  
> > >  DRM DRIVER FOR VMWARE VIRTUAL GPU
> > > -M:	"VMware Graphics" <[e-mail]>
> > >  M:	Zack Rusin <[e-mail]>
> > > +L:	[e-mail] (private)  
> > 
> > This MAINTAINERS file is for _public_ use, marking something
> > non-public isn't useful.
> 
> But Greg has a point. Corporations like to send us code with a list 
> as the maintainer and MODULE_AUTHOR set to corp's name. We deal with
> humans, not legal entities.

MAINTAINERS is used not for corporations private use but
to find out _who_ to send and cc patches and defect reports.

A "private" email address used only for corporate internal review
cannot receive patches.

> I've been trying to get them to use "M: email" without the name,
> but "L: list (private)" also works.
> 
> Either way I feel like we need _some_ way to tell humans from corporate
> "please CC this address" entries.

This is not the way AFAIKT.

> > private makes no sense and likely these L: entries shouldn't exist.

Joe Perches Nov. 9, 2021, 12:37 a.m. UTC | #6

On Mon, 2021-11-08 at 16:22 -0800, Srivatsa S. Bhat wrote:
> +Greg, Thomas
> 
> Hi Joe,
> 
> On 11/8/21 3:37 PM, Joe Perches wrote:
> > On Mon, 2021-11-08 at 12:30 -0800, Srivatsa S. Bhat wrote:
> > > From: Srivatsa S. Bhat (VMware) <[e-mail]>
> > > 
> > > VMware mailing lists in the MAINTAINERS file are private lists meant
> > > for VMware-internal review/notification for patches to the respective
> > > subsystems. So, in an earlier discussion [1][2], it was recommended to
> > > mark them as such. Update all the remaining VMware mailing list
> > > references to use that format -- "L: list@address (private)".
> > []
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > []
> > > @@ -6134,8 +6134,8 @@ T:	git git://anongit.freedesktop.org/drm/drm-misc
> > >  F:	drivers/gpu/drm/vboxvideo/
> > >  
> > >  DRM DRIVER FOR VMWARE VIRTUAL GPU
> > > -M:	"VMware Graphics" <[e-mail]>
> > >  M:	Zack Rusin <[e-mail]>
> > > +L:	[e-mail] (private)
> > 
> > This MAINTAINERS file is for _public_ use, marking something
> > non-public isn't useful.
> > 
> > private makes no sense and likely these L: entries shouldn't exist.
> 
> Well, the public can send messages to this list, but membership is
> restricted.

Ah, new information.
That's not quite what the commit message describes.
 
> In many ways, I believe this is similar to [e-mail], which is an
> email alias that anyone can post to in order to reach the x86
> maintainer community for patch review. I see [e-mail] listed as
> both L: and M: in the MAINTAINERS file, among different entries.
> 
> Although the @vmware list ids refer to VMware-internal mailing lists
> as opposed to email aliases, they serve a very similar purpose -- to
> inform VMware folks about patches to the relevant subsystems.
> 
> Is there a consensus on how such lists should be specified?

Not so far as I know.

> One
> suggestion (from Greg in the email thread referenced above) was to
> mark it as private, which is what this patch does. Maybe we can find a
> better alternative?
> 
> How about specifying such lists using M: (indicating that this address
> can be used to reach maintainers), as long as that is not the only M:
> entry for a given subsystem (i.e., it includes real people's email id
> as well)? I think that would address Greg's primary objection too from
> that other thread (related to personal responsibility as maintainers).

So it's an exploder not an actual maintainer and it likely isn't
publically archived with any normal list mechanism.

So IMO "private" isn't appropriate.  Neither is "L:"
Perhaps just mark it as what it is as an "exploder".

Or maybe these blocks should be similar to:

M:	Name of Lead Developer <[e-mail]>
M:	VMware <foo> maintainers <linux-<foo>[e-mail]>

Maybe something like a comment mechanism should be added to the
MAINTAINERS file.

Maybe #

so this entry could be something like:

M:	VMware <foo> maintainers <linux-<foo>[e-mail]> # VMware's ever changing internal maintainers list

Nadav Amit Nov. 9, 2021, 12:58 a.m. UTC | #7

> On Nov 8, 2021, at 4:37 PM, Joe Perches <[e-mail]> wrote:
> 
> On Mon, 2021-11-08 at 16:22 -0800, Srivatsa S. Bhat wrote:
> 
> So it's an exploder not an actual maintainer and it likely isn't
> publically archived with any normal list mechanism.
> 
> So IMO "private" isn't appropriate.  Neither is "L:"
> Perhaps just mark it as what it is as an "exploder".
> 
> Or maybe these blocks should be similar to:
> 
> M:	Name of Lead Developer <[e-mail]>
> M:	VMware <foo> maintainers <linux-<foo>[e-mail]>
> 
> Maybe something like a comment mechanism should be added to the
> MAINTAINERS file.
> 
> Maybe #
> 
> so this entry could be something like:
> 
> M:	VMware <foo> maintainers <linux-<foo>[e-mail]> # VMware's ever changing internal maintainers list

Admittedly, I do not care much about how it turns to be.

But if it is modified, it should be very clear who the maintainer
is, and not to entangle the mailing list and the maintainer.

I am personally not subscribed to the internal pv-drivers mailing
list, which is not just for memory ballooning, and is also listed
as a maintainer for vmmouse, pvscsi, vmxnet3 and others.

As I am the only maintainer of VMware balloon, if someone is
mistaken and sends an email only to the mailing list and not me,
he might be disappointed.

Jürgen Groß Nov. 9, 2021, 5:34 a.m. UTC | #8

On 08.11.21 21:30, Srivatsa S. Bhat wrote:
> From: Srivatsa S. Bhat (VMware) <[e-mail]>
> 
> VMware mailing lists in the MAINTAINERS file are private lists meant
> for VMware-internal review/notification for patches to the respective
> subsystems. So, in an earlier discussion [1][2], it was recommended to
> mark them as such. Update all the remaining VMware mailing list
> references to use that format -- "L: list@address (private)".
> 
> [1]. https://lore.kernel.org/r/[e-mail]
> [2]. https://lore.kernel.org/r/[e-mail]
> 
> Signed-off-by: Srivatsa S. Bhat (VMware) <[e-mail]>
> Cc: Nadav Amit <[e-mail]>
> Cc: Vivek Thampi <[e-mail]>
> Cc: Vishal Bhakta <[e-mail]>
> Cc: Ronak Doshi <[e-mail]>
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> Acked-by: Zack Rusin <[e-mail]>
> ---
> 
>   MAINTAINERS |   16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 118cf8170d02..3e92176e68fb 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6134,8 +6134,8 @@ T:	git git://anongit.freedesktop.org/drm/drm-misc
>   F:	drivers/gpu/drm/vboxvideo/
>   
>   DRM DRIVER FOR VMWARE VIRTUAL GPU
> -M:	"VMware Graphics" <[e-mail]>
>   M:	Zack Rusin <[e-mail]>
> +L:	[e-mail] (private)
>   L:	[e-mail]
>   S:	Supported
>   T:	git git://anongit.freedesktop.org/drm/drm-misc
> @@ -20032,7 +20032,7 @@ F:	tools/testing/vsock/
>   
>   VMWARE BALLOON DRIVER
>   M:	Nadav Amit <[e-mail]>
> -M:	"VMware, Inc." <[e-mail]>
> +L:	[e-mail] (private)
>   L:	[e-mail]
>   S:	Maintained
>   F:	drivers/misc/vmw_balloon.c
> @@ -20050,14 +20050,14 @@ F:	arch/x86/kernel/cpu/vmware.c
>   
>   VMWARE PVRDMA DRIVER
>   M:	Adit Ranadive <[e-mail]>
> -M:	VMware PV-Drivers <[e-mail]>
> +L:	[e-mail] (private)
>   L:	[e-mail]
>   S:	Maintained
>   F:	drivers/infiniband/hw/vmw_pvrdma/
>   
>   VMware PVSCSI driver
>   M:	Vishal Bhakta <[e-mail]>
> -M:	VMware PV-Drivers <[e-mail]>
> +L:	[e-mail] (private)
>   L:	[e-mail]
>   S:	Maintained
>   F:	drivers/scsi/vmw_pvscsi.c
> @@ -20065,7 +20065,7 @@ F:	drivers/scsi/vmw_pvscsi.h
>   
>   VMWARE VIRTUAL PTP CLOCK DRIVER
>   M:	Vivek Thampi <[e-mail]>
> -M:	"VMware, Inc." <[e-mail]>
> +L:	[e-mail] (private)

Maybe replace "(private)" with "(mail alias)"?

This makes it rather clear that it is a valid address to send patches
to, but there isn't public read access like to a ML.


Juergen

Joe Perches Nov. 9, 2021, 9:57 p.m. UTC | #9

On Tue, 2021-11-09 at 00:58 +0000, Nadav Amit wrote:
> > On Nov 8, 2021, at 4:37 PM, Joe Perches <[e-mail]> wrote:
> > On Mon, 2021-11-08 at 16:22 -0800, Srivatsa S. Bhat wrote:
> > 
> > So it's an exploder not an actual maintainer and it likely isn't
> > publically archived with any normal list mechanism.
> > 
> > So IMO "private" isn't appropriate.  Neither is "L:"
> > Perhaps just mark it as what it is as an "exploder".
> > 
> > Or maybe these blocks should be similar to:
> > 
> > M:	Name of Lead Developer <[e-mail]>
> > M:	VMware <foo> maintainers <linux-<foo>[e-mail]>

Maybe adding entries like

M:	Named maintainer <[e-mail]>
R:	VMware <foo> reviewers <linux-<foo>[e-mail]>

would be best/simplest.

Srivatsa S. Bhat Nov. 10, 2021, 5:20 p.m. UTC | #10

On Tue, Nov 09, 2021 at 01:57:31PM -0800, Joe Perches wrote:
> On Tue, 2021-11-09 at 00:58 +0000, Nadav Amit wrote:
> > > On Nov 8, 2021, at 4:37 PM, Joe Perches <[e-mail]> wrote:
> > > On Mon, 2021-11-08 at 16:22 -0800, Srivatsa S. Bhat wrote:
> > > 
> > > So it's an exploder not an actual maintainer and it likely isn't
> > > publically archived with any normal list mechanism.
> > > 
> > > So IMO "private" isn't appropriate.  Neither is "L:"
> > > Perhaps just mark it as what it is as an "exploder".
> > > 
> > > Or maybe these blocks should be similar to:
> > > 
> > > M:	Name of Lead Developer <[e-mail]>
> > > M:	VMware <foo> maintainers <linux-<foo>[e-mail]>
> 
> Maybe adding entries like
> 
> M:	Named maintainer <[e-mail]>
> R:	VMware <foo> reviewers <linux-<foo>[e-mail]>
> 
> would be best/simplest.
> 

Sure, that sounds good to me. I also considered adding "(email alias)"
like Juergen suggested, but I think the R: entry is clear enough.
Please find the updated patch below.

---

From f66faa238facf504cfc66325912ce7af8cbf79ec Mon Sep 17 00:00:00 2001
From: "Srivatsa S. Bhat (VMware)" <[e-mail]>
Date: Mon, 8 Nov 2021 11:46:57 -0800
Subject: [PATCH v2 2/2] MAINTAINERS: Mark VMware mailing list entries as email
 aliases

VMware mailing lists in the MAINTAINERS file are private lists meant
for VMware-internal review/notification for patches to the respective
subsystems. Anyone can post to these addresses, but there is no public
read access like open mailing lists, which makes them more like email
aliases instead (to reach out to reviewers).

So update all the VMware mailing list references in the MAINTAINERS
file to mark them as such, using "R: [e-mail]".

Signed-off-by: Srivatsa S. Bhat (VMware) <[e-mail]>
Cc: Zack Rusin <[e-mail]>
Cc: Nadav Amit <[e-mail]>
Cc: Vivek Thampi <[e-mail]>
Cc: Vishal Bhakta <[e-mail]>
Cc: Ronak Doshi <[e-mail]>
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
---
 MAINTAINERS | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 118cf8170d02..4372d79027e9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6134,8 +6134,8 @@ T:	git git://anongit.freedesktop.org/drm/drm-misc
 F:	drivers/gpu/drm/vboxvideo/
 
 DRM DRIVER FOR VMWARE VIRTUAL GPU
-M:	"VMware Graphics" <[e-mail]>
 M:	Zack Rusin <[e-mail]>
+R:	VMware Graphics Reviewers <[e-mail]>
 L:	[e-mail]
 S:	Supported
 T:	git git://anongit.freedesktop.org/drm/drm-misc
@@ -14189,7 +14189,7 @@ F:	include/uapi/linux/ppdev.h
 PARAVIRT_OPS INTERFACE
 M:	Juergen Gross <[e-mail]>
 M:	Srivatsa S. Bhat (VMware) <[e-mail]>
-L:	[e-mail] (private)
+R:	VMware PV-Drivers Reviewers <[e-mail]>
 L:	[e-mail]
 L:	[e-mail]
 S:	Supported
@@ -20032,7 +20032,7 @@ F:	tools/testing/vsock/
 
 VMWARE BALLOON DRIVER
 M:	Nadav Amit <[e-mail]>
-M:	"VMware, Inc." <[e-mail]>
+R:	VMware PV-Drivers Reviewers <[e-mail]>
 L:	[e-mail]
 S:	Maintained
 F:	drivers/misc/vmw_balloon.c
@@ -20040,7 +20040,7 @@ F:	drivers/misc/vmw_balloon.c
 VMWARE HYPERVISOR INTERFACE
 M:	Srivatsa S. Bhat (VMware) <[e-mail]>
 M:	Alexey Makhalov <[e-mail]>
-L:	[e-mail] (private)
+R:	VMware PV-Drivers Reviewers <[e-mail]>
 L:	[e-mail]
 L:	[e-mail]
 S:	Supported
@@ -20050,14 +20050,14 @@ F:	arch/x86/kernel/cpu/vmware.c
 
 VMWARE PVRDMA DRIVER
 M:	Adit Ranadive <[e-mail]>
-M:	VMware PV-Drivers <[e-mail]>
+R:	VMware PV-Drivers Reviewers <[e-mail]>
 L:	[e-mail]
 S:	Maintained
 F:	drivers/infiniband/hw/vmw_pvrdma/
 
 VMware PVSCSI driver
 M:	Vishal Bhakta <[e-mail]>
-M:	VMware PV-Drivers <[e-mail]>
+R:	VMware PV-Drivers Reviewers <[e-mail]>
 L:	[e-mail]
 S:	Maintained
 F:	drivers/scsi/vmw_pvscsi.c
@@ -20065,7 +20065,7 @@ F:	drivers/scsi/vmw_pvscsi.h
 
 VMWARE VIRTUAL PTP CLOCK DRIVER
 M:	Vivek Thampi <[e-mail]>
-M:	"VMware, Inc." <[e-mail]>
+R:	VMware PV-Drivers Reviewers <[e-mail]>
 L:	[e-mail]
 S:	Supported
 F:	drivers/ptp/ptp_vmw.c
@@ -20073,14 +20073,14 @@ F:	drivers/ptp/ptp_vmw.c
 VMWARE VMCI DRIVER
 M:	Jorgen Hansen <[e-mail]>
 M:	Vishnu Dasa <[e-mail]>
+R:	VMware PV-Drivers Reviewers <[e-mail]>
 L:	[e-mail]
-L:	[e-mail] (private)
 S:	Maintained
 F:	drivers/misc/vmw_vmci/
 
 VMWARE VMMOUSE SUBDRIVER
-M:	"VMware Graphics" <[e-mail]>
-M:	"VMware, Inc." <[e-mail]>
+R:	VMware Graphics Reviewers <[e-mail]>
+R:	VMware PV-Drivers Reviewers <[e-mail]>
 L:	[e-mail]
 S:	Maintained
 F:	drivers/input/mouse/vmmouse.c
@@ -20088,7 +20088,7 @@ F:	drivers/input/mouse/vmmouse.h
 
 VMWARE VMXNET3 ETHERNET DRIVER
 M:	Ronak Doshi <[e-mail]>
-M:	[e-mail]
+R:	VMware PV-Drivers Reviewers <[e-mail]>
 L:	[e-mail]
 S:	Maintained
 F:	drivers/net/vmxnet3/

Nadav Amit Nov. 10, 2021, 5:40 p.m. UTC | #11

> On Nov 10, 2021, at 9:20 AM, Srivatsa S. Bhat <[e-mail]> wrote:
> 
> On Tue, Nov 09, 2021 at 01:57:31PM -0800, Joe Perches wrote:
>> On Tue, 2021-11-09 at 00:58 +0000, Nadav Amit wrote:
>>>> On Nov 8, 2021, at 4:37 PM, Joe Perches <[e-mail]> wrote:
>>>> On Mon, 2021-11-08 at 16:22 -0800, Srivatsa S. Bhat wrote:
>>>> 
>>>> So it's an exploder not an actual maintainer and it likely isn't
>>>> publically archived with any normal list mechanism.
>>>> 
>>>> So IMO "private" isn't appropriate.  Neither is "L:"
>>>> Perhaps just mark it as what it is as an "exploder".
>>>> 
>>>> Or maybe these blocks should be similar to:
>>>> 
>>>> M:	Name of Lead Developer <[e-mail]>
>>>> M:	VMware <foo> maintainers <linux-<foo>[e-mail]>
>> 
>> Maybe adding entries like
>> 
>> M:	Named maintainer <[e-mail]>
>> R:	VMware <foo> reviewers <linux-<foo>[e-mail]>
>> 
>> would be best/simplest.
>> 
> 
> Sure, that sounds good to me. I also considered adding "(email alias)"
> like Juergen suggested, but I think the R: entry is clear enough.
> Please find the updated patch below.
> 
> ---
> 
> From f66faa238facf504cfc66325912ce7af8cbf79ec Mon Sep 17 00:00:00 2001
> From: "Srivatsa S. Bhat (VMware)" <[e-mail]>
> Date: Mon, 8 Nov 2021 11:46:57 -0800
> Subject: [PATCH v2 2/2] MAINTAINERS: Mark VMware mailing list entries as email
> aliases
> 
> VMware mailing lists in the MAINTAINERS file are private lists meant
> for VMware-internal review/notification for patches to the respective
> subsystems. Anyone can post to these addresses, but there is no public
> read access like open mailing lists, which makes them more like email
> aliases instead (to reach out to reviewers).
> 
> So update all the VMware mailing list references in the MAINTAINERS
> file to mark them as such, using "R: [e-mail]".
> 
> Signed-off-by: Srivatsa S. Bhat (VMware) <[e-mail]>
> Cc: Zack Rusin <[e-mail]>
> Cc: Nadav Amit <[e-mail]>
> Cc: Vivek Thampi <[e-mail]>
> Cc: Vishal Bhakta <[e-mail]>
> Cc: Ronak Doshi <[e-mail]>
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> ---
> MAINTAINERS | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 118cf8170d02..4372d79027e9 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6134,8 +6134,8 @@ T:	git git://anongit.freedesktop.org/drm/drm-misc
> F:	drivers/gpu/drm/vboxvideo/
> 
> DRM DRIVER FOR VMWARE VIRTUAL GPU
> -M:	"VMware Graphics" <[e-mail]>
> M:	Zack Rusin <[e-mail]>
> +R:	VMware Graphics Reviewers <[e-mail]>
> L:	[e-mail]
> S:	Supported
> T:	git git://anongit.freedesktop.org/drm/drm-misc
> @@ -14189,7 +14189,7 @@ F:	include/uapi/linux/ppdev.h
> PARAVIRT_OPS INTERFACE
> M:	Juergen Gross <[e-mail]>
> M:	Srivatsa S. Bhat (VMware) <[e-mail]>
> -L:	[e-mail] (private)
> +R:	VMware PV-Drivers Reviewers <[e-mail]>

This patch that you just sent seems to go on top of the previous patches
(as it removes "L: [e-mail] (private)”).

Since the patches were still not merged, I would presume you should squash
the old 2/2 with this new patch and send v3 of these patches.

Srivatsa S. Bhat Nov. 10, 2021, 7:13 p.m. UTC | #12

On Wed, Nov 10, 2021 at 05:40:09PM +0000, Nadav Amit wrote:
> 
> 
> > On Nov 10, 2021, at 9:20 AM, Srivatsa S. Bhat <[e-mail]> wrote:
> > 
> > On Tue, Nov 09, 2021 at 01:57:31PM -0800, Joe Perches wrote:
> >> On Tue, 2021-11-09 at 00:58 +0000, Nadav Amit wrote:
> >>>> On Nov 8, 2021, at 4:37 PM, Joe Perches <[e-mail]> wrote:
> >>>> On Mon, 2021-11-08 at 16:22 -0800, Srivatsa S. Bhat wrote:
> >>>> 
> >>>> So it's an exploder not an actual maintainer and it likely isn't
> >>>> publically archived with any normal list mechanism.
> >>>> 
> >>>> So IMO "private" isn't appropriate.  Neither is "L:"
> >>>> Perhaps just mark it as what it is as an "exploder".
> >>>> 
> >>>> Or maybe these blocks should be similar to:
> >>>> 
> >>>> M:	Name of Lead Developer <[e-mail]>
> >>>> M:	VMware <foo> maintainers <linux-<foo>[e-mail]>
> >> 
> >> Maybe adding entries like
> >> 
> >> M:	Named maintainer <[e-mail]>
> >> R:	VMware <foo> reviewers <linux-<foo>[e-mail]>
> >> 
> >> would be best/simplest.
> >> 
> > 
> > Sure, that sounds good to me. I also considered adding "(email alias)"
> > like Juergen suggested, but I think the R: entry is clear enough.
> > Please find the updated patch below.
> > 
> > ---
> > 
> > From f66faa238facf504cfc66325912ce7af8cbf79ec Mon Sep 17 00:00:00 2001
> > From: "Srivatsa S. Bhat (VMware)" <[e-mail]>
> > Date: Mon, 8 Nov 2021 11:46:57 -0800
> > Subject: [PATCH v2 2/2] MAINTAINERS: Mark VMware mailing list entries as email
> > aliases
> > 
> > VMware mailing lists in the MAINTAINERS file are private lists meant
> > for VMware-internal review/notification for patches to the respective
> > subsystems. Anyone can post to these addresses, but there is no public
> > read access like open mailing lists, which makes them more like email
> > aliases instead (to reach out to reviewers).
> > 
> > So update all the VMware mailing list references in the MAINTAINERS
> > file to mark them as such, using "R: [e-mail]".
> > 
> > Signed-off-by: Srivatsa S. Bhat (VMware) <[e-mail]>
> > Cc: Zack Rusin <[e-mail]>
> > Cc: Nadav Amit <[e-mail]>
> > Cc: Vivek Thampi <[e-mail]>
> > Cc: Vishal Bhakta <[e-mail]>
> > Cc: Ronak Doshi <[e-mail]>
> > Cc: [e-mail]
> > Cc: [e-mail]
> > Cc: [e-mail]
> > Cc: [e-mail]
> > Cc: [e-mail]
> > Cc: [e-mail]
> > Cc: [e-mail]
> > ---
> > MAINTAINERS | 22 +++++++++++-----------
> > 1 file changed, 11 insertions(+), 11 deletions(-)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 118cf8170d02..4372d79027e9 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -6134,8 +6134,8 @@ T:	git git://anongit.freedesktop.org/drm/drm-misc
> > F:	drivers/gpu/drm/vboxvideo/
> > 
> > DRM DRIVER FOR VMWARE VIRTUAL GPU
> > -M:	"VMware Graphics" <[e-mail]>
> > M:	Zack Rusin <[e-mail]>
> > +R:	VMware Graphics Reviewers <[e-mail]>
> > L:	[e-mail]
> > S:	Supported
> > T:	git git://anongit.freedesktop.org/drm/drm-misc
> > @@ -14189,7 +14189,7 @@ F:	include/uapi/linux/ppdev.h
> > PARAVIRT_OPS INTERFACE
> > M:	Juergen Gross <[e-mail]>
> > M:	Srivatsa S. Bhat (VMware) <[e-mail]>
> > -L:	[e-mail] (private)
> > +R:	VMware PV-Drivers Reviewers <[e-mail]>
> 
> This patch that you just sent seems to go on top of the previous patches
> (as it removes "L: [e-mail] (private)”).
> 

Actually, that's a bit misleading, since I had corrected that entry in
the first patch itself, while adding myself as the maintainer. So
there are still only 2 patches in this series right now.

Thanks for pointing this out! I'll move the VMware list modifications
out of the first patch, to avoid confusion.

> Since the patches were still not merged, I would presume you should squash
> the old 2/2 with this new patch and send v3 of these patches.
> 

I'll send out a v3, and also add Zack Rusin as the maintainer for the
vmmouse sub-driver, since it does not have a named maintainer at the
moment (Zack indicated that he will be taking up the maintainership).

Thank you!

Regards,
Srivatsa

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 118cf8170d02..3e92176e68fb 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6134,8 +6134,8 @@  T:	git git://anongit.freedesktop.org/drm/drm-misc
 F:	drivers/gpu/drm/vboxvideo/
 
 DRM DRIVER FOR VMWARE VIRTUAL GPU
-M:	"VMware Graphics" <[e-mail]>
 M:	Zack Rusin <[e-mail]>
+L:	[e-mail] (private)
 L:	[e-mail]
 S:	Supported
 T:	git git://anongit.freedesktop.org/drm/drm-misc
@@ -20032,7 +20032,7 @@  F:	tools/testing/vsock/
 
 VMWARE BALLOON DRIVER
 M:	Nadav Amit <[e-mail]>
-M:	"VMware, Inc." <[e-mail]>
+L:	[e-mail] (private)
 L:	[e-mail]
 S:	Maintained
 F:	drivers/misc/vmw_balloon.c
@@ -20050,14 +20050,14 @@  F:	arch/x86/kernel/cpu/vmware.c
 
 VMWARE PVRDMA DRIVER
 M:	Adit Ranadive <[e-mail]>
-M:	VMware PV-Drivers <[e-mail]>
+L:	[e-mail] (private)
 L:	[e-mail]
 S:	Maintained
 F:	drivers/infiniband/hw/vmw_pvrdma/
 
 VMware PVSCSI driver
 M:	Vishal Bhakta <[e-mail]>
-M:	VMware PV-Drivers <[e-mail]>
+L:	[e-mail] (private)
 L:	[e-mail]
 S:	Maintained
 F:	drivers/scsi/vmw_pvscsi.c
@@ -20065,7 +20065,7 @@  F:	drivers/scsi/vmw_pvscsi.h
 
 VMWARE VIRTUAL PTP CLOCK DRIVER
 M:	Vivek Thampi <[e-mail]>
-M:	"VMware, Inc." <[e-mail]>
+L:	[e-mail] (private)
 L:	[e-mail]
 S:	Supported
 F:	drivers/ptp/ptp_vmw.c
@@ -20079,8 +20079,8 @@  S:	Maintained
 F:	drivers/misc/vmw_vmci/
 
 VMWARE VMMOUSE SUBDRIVER
-M:	"VMware Graphics" <[e-mail]>
-M:	"VMware, Inc." <[e-mail]>
+L:	[e-mail] (private)
+L:	[e-mail] (private)
 L:	[e-mail]
 S:	Maintained
 F:	drivers/input/mouse/vmmouse.c
@@ -20088,7 +20088,7 @@  F:	drivers/input/mouse/vmmouse.h
 
 VMWARE VMXNET3 ETHERNET DRIVER
 M:	Ronak Doshi <[e-mail]>
-M:	[e-mail]
+L:	[e-mail] (private)
 L:	[e-mail]
 S:	Maintained
 F:	drivers/net/vmxnet3/