[0/3] Cleanup and optimize a few bitmap operations

Message

Christophe JAILLET Nov. 24, 2021, 9:30 p.m. UTC

Patch 1 and 2 are just cleanups that uses 'bitmap_zalloc()' and 'bitmap_set()'
instead of hand-writing these functions.

Patch 3 is more questionable. It replaces calls to '[set|clear]_bit()' by their
non-atomic '__[set|clear]_bit()' alternatives.
It looks safe to do so because accesses to the corresponding bitmaps are
protected by spinlocks.
However, this patch is compile-tested only. It is not sure that it worth
changing the code just for saving a few atomic operations.
So review, test and apply only if it make sense.

Christophe JAILLET (3):
  RDMA/cxgb4: Use bitmap_zalloc() when applicable
  RDMA/cxgb4: Use bitmap_set() when applicable
  RDMA/cxgb4: Use non-atomic bitmap functions when possible

 drivers/infiniband/hw/cxgb4/id_table.c | 17 ++++++-----------
 1 file changed, 6 insertions(+), 11 deletions(-)

Comments

Jason Gunthorpe Nov. 25, 2021, 5:30 p.m. UTC | #1

On Wed, Nov 24, 2021 at 10:30:08PM +0100, Christophe JAILLET wrote:
> Patch 1 and 2 are just cleanups that uses 'bitmap_zalloc()' and 'bitmap_set()'
> instead of hand-writing these functions.
> 
> Patch 3 is more questionable. It replaces calls to '[set|clear]_bit()' by their
> non-atomic '__[set|clear]_bit()' alternatives.
> It looks safe to do so because accesses to the corresponding bitmaps are
> protected by spinlocks.
> However, this patch is compile-tested only. It is not sure that it worth
> changing the code just for saving a few atomic operations.
> So review, test and apply only if it make sense.
> 
> Christophe JAILLET (3):
>   RDMA/cxgb4: Use bitmap_zalloc() when applicable
>   RDMA/cxgb4: Use bitmap_set() when applicable
>   RDMA/cxgb4: Use non-atomic bitmap functions when possible

Applied to for-next, thanks

Jason