| Message ID | 1637846230-4798-2-git-send-email-pharish@codeaurora.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v1] Bluetooth: hci_qca: Stop IBS timer during BT OFF | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/checkpatch | success | Checkpatch PASS |
| tedd_an/gitlint | success | Gitlint PASS |
| tedd_an/buildkernel | success | Build Kernel PASS |
| tedd_an/testrunnersetup | success | Test Runner Setup PASS |
| tedd_an/testrunnerl2cap-tester | success | Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnerbnep-tester | success | Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnermgmt-tester | success | Total: 493, Passed: 492 (99.8%), Failed: 0, Not Run: 1 |
| tedd_an/testrunnerrfcomm-tester | success | Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnersco-tester | success | Total: 12, Passed: 12 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunnersmp-tester | success | Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0 |
| tedd_an/testrunneruserchan-tester | success | Total: 4, Passed: 4 (100.0%), Failed: 0, Not Run: 0 |
Hi, > This change stops IBS timers during BT OFF. > > Signed-off-by: pharish <pharish@codeaurora.org> clear name please. > --- > drivers/bluetooth/hci_qca.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c > index dd768a8..6f44b26 100644 > --- a/drivers/bluetooth/hci_qca.c > +++ b/drivers/bluetooth/hci_qca.c > @@ -1928,6 +1928,9 @@ static int qca_power_off(struct hci_dev *hdev) > hu->hdev->hw_error = NULL; > hu->hdev->cmd_timeout = NULL; > > + mod_timer(&qca->tx_idle_timer, 0); > + mod_timer(&qca->wake_retrans_timer, 0); > + And I would really prefer if this gets changed to use a workqueue instead of a timer. Regards Marcel
On 2021-11-26 00:12, Marcel Holtmann wrote: > Hi, > >> This change stops IBS timers during BT OFF. >> >> Signed-off-by: pharish <pharish@codeaurora.org> > > clear name please. [Harish]: will update > >> --- >> drivers/bluetooth/hci_qca.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c >> index dd768a8..6f44b26 100644 >> --- a/drivers/bluetooth/hci_qca.c >> +++ b/drivers/bluetooth/hci_qca.c >> @@ -1928,6 +1928,9 @@ static int qca_power_off(struct hci_dev *hdev) >> hu->hdev->hw_error = NULL; >> hu->hdev->cmd_timeout = NULL; >> >> + mod_timer(&qca->tx_idle_timer, 0); >> + mod_timer(&qca->wake_retrans_timer, 0); >> + > > And I would really prefer if this gets changed to use a workqueue > instead of a timer. [Harish]: The full implementation of IBS is based on timers to that reason I have switched to timers. > > Regards > > Marcel
diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index dd768a8..6f44b26 100644 --- a/drivers/bluetooth/hci_qca.c +++ b/drivers/bluetooth/hci_qca.c @@ -1928,6 +1928,9 @@ static int qca_power_off(struct hci_dev *hdev) hu->hdev->hw_error = NULL; hu->hdev->cmd_timeout = NULL; + mod_timer(&qca->tx_idle_timer, 0); + mod_timer(&qca->wake_retrans_timer, 0); + /* Stop sending shutdown command if soc crashes. */ if (soc_type != QCA_ROME && qca->memdump_state == QCA_MEMDUMP_IDLE) {
This change stops IBS timers during BT OFF. Signed-off-by: pharish <pharish@codeaurora.org> --- drivers/bluetooth/hci_qca.c | 3 +++ 1 file changed, 3 insertions(+)