diff mbox series

drm/i915/gem: Use local pointer for __i915_ttm_move

Message ID 20211203204753.1634865-1-jasmine.newsome@intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915/gem: Use local pointer for __i915_ttm_move | expand

Commit Message

Jasmine Newsome Dec. 3, 2021, 8:47 p.m. UTC 
Replace pointer bo->ttm with ttm in i915_ttm_move
when passed as argument to __i915_ttm_move
---
 drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sudeep Dutt Dec. 3, 2021, 8:57 p.m. UTC | #1 
On Fri, Dec 03, 2021 at 12:47:53PM -0800, Jasmine Newsome wrote:
> Replace pointer bo->ttm with ttm in i915_ttm_move
> when passed as argument to __i915_ttm_move

Hi Jasmine,

Can you please resend this patch with the commit description updated to
describe why this patch is needed?

Thanks,
Sudeep Dutt

> ---
>  drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
> index 80df9f592407..56b6573b5c93 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
> @@ -763,7 +763,7 @@ int i915_ttm_move(struct ttm_buffer_object *bo, bool evict,
>  			return PTR_ERR(dep);
>  		}
>  
> -		migration_fence = __i915_ttm_move(bo, clear, dst_mem, bo->ttm,
> +		migration_fence = __i915_ttm_move(bo, clear, dst_mem, ttm,
>  						  dst_rsgt, true, dep);
>  		dma_fence_put(dep);
>  	}
> -- 
> 2.25.1
>
Jani Nikula Dec. 9, 2021, 9:53 a.m. UTC | #2 
On Fri, 03 Dec 2021, Jasmine Newsome <jasmine.newsome@intel.com> wrote:
> Replace pointer bo->ttm with ttm in i915_ttm_move
> when passed as argument to __i915_ttm_move

Signed-off-by missing.

> ---
>  drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
> index 80df9f592407..56b6573b5c93 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
> @@ -763,7 +763,7 @@ int i915_ttm_move(struct ttm_buffer_object *bo, bool evict,
>  			return PTR_ERR(dep);
>  		}
>  
> -		migration_fence = __i915_ttm_move(bo, clear, dst_mem, bo->ttm,
> +		migration_fence = __i915_ttm_move(bo, clear, dst_mem, ttm,
>  						  dst_rsgt, true, dep);
>  		dma_fence_put(dep);
>  	}
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
index 80df9f592407..56b6573b5c93 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c
@@ -763,7 +763,7 @@  int i915_ttm_move(struct ttm_buffer_object *bo, bool evict,
 			return PTR_ERR(dep);
 		}
 
-		migration_fence = __i915_ttm_move(bo, clear, dst_mem, bo->ttm,
+		migration_fence = __i915_ttm_move(bo, clear, dst_mem, ttm,
 						  dst_rsgt, true, dep);
 		dma_fence_put(dep);
 	}