| Message ID | 0cb4593af06b64eb43a316913dc4bf83d46d7d7f.1639559338.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | drm: rcar-du: Add missing dependencies | expand |
Hi Geert, Thank you for the patch. On Wed, Dec 15, 2021 at 10:27:45AM +0100, Geert Uytterhoeven wrote: > The Renesas R-Car Gen3 and RZ/G2 internal HDMI encoder is only present > on Renesas R-Car Gen3 and RZ/G2 SoCs. Hence add a dependency on > ARCH_RENESAS, to prevent asking the user about this driver when > configuring a kernel without Renesas SoC support. > > Fixes: 40d0fa7095d06c73 ("drm: rcar-du: Add Gen3 HDMI encoder support") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > drivers/gpu/drm/rcar-du/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig > index f6e6a6d5d987bf95..65d72be50f46f19e 100644 > --- a/drivers/gpu/drm/rcar-du/Kconfig > +++ b/drivers/gpu/drm/rcar-du/Kconfig > @@ -25,6 +25,7 @@ config DRM_RCAR_CMM > config DRM_RCAR_DW_HDMI > tristate "R-Car Gen3 and RZ/G2 DU HDMI Encoder Support" > depends on DRM && OF > + depends on ARCH_RENESAS || COMPILE_TEST Let's move this entry first to keep alphabetical order. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > select DRM_DW_HDMI > help > Enable support for R-Car Gen3 or RZ/G2 internal HDMI encoder.
Hi Laurent, On Wed, Dec 15, 2021 at 11:24 AM Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > On Wed, Dec 15, 2021 at 10:27:45AM +0100, Geert Uytterhoeven wrote: > > The Renesas R-Car Gen3 and RZ/G2 internal HDMI encoder is only present > > on Renesas R-Car Gen3 and RZ/G2 SoCs. Hence add a dependency on > > ARCH_RENESAS, to prevent asking the user about this driver when > > configuring a kernel without Renesas SoC support. > > > > Fixes: 40d0fa7095d06c73 ("drm: rcar-du: Add Gen3 HDMI encoder support") > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > --- a/drivers/gpu/drm/rcar-du/Kconfig > > +++ b/drivers/gpu/drm/rcar-du/Kconfig > > @@ -25,6 +25,7 @@ config DRM_RCAR_CMM > > config DRM_RCAR_DW_HDMI > > tristate "R-Car Gen3 and RZ/G2 DU HDMI Encoder Support" > > depends on DRM && OF > > + depends on ARCH_RENESAS || COMPILE_TEST > > Let's move this entry first to keep alphabetical order. I tend to keep the "hard" and "soft" dependencies separate, with the "hard" dependencies listed first. > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Thank you! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig index f6e6a6d5d987bf95..65d72be50f46f19e 100644 --- a/drivers/gpu/drm/rcar-du/Kconfig +++ b/drivers/gpu/drm/rcar-du/Kconfig @@ -25,6 +25,7 @@ config DRM_RCAR_CMM config DRM_RCAR_DW_HDMI tristate "R-Car Gen3 and RZ/G2 DU HDMI Encoder Support" depends on DRM && OF + depends on ARCH_RENESAS || COMPILE_TEST select DRM_DW_HDMI help Enable support for R-Car Gen3 or RZ/G2 internal HDMI encoder.
The Renesas R-Car Gen3 and RZ/G2 internal HDMI encoder is only present on Renesas R-Car Gen3 and RZ/G2 SoCs. Hence add a dependency on ARCH_RENESAS, to prevent asking the user about this driver when configuring a kernel without Renesas SoC support. Fixes: 40d0fa7095d06c73 ("drm: rcar-du: Add Gen3 HDMI encoder support") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/gpu/drm/rcar-du/Kconfig | 1 + 1 file changed, 1 insertion(+)