[0/6] Switchtec NTB Fixes and Improvements

Message

Kelvin Cao Dec. 24, 2021, 1:23 a.m. UTC

Hi,

Please find a bunch of patches for the Switchtec NTB driver.

Patche 1, 2 and 6 fix three minor bugs. Patch 3 works around a minor
firmware issue. Patch 4 updates the method of getting management VEP
instance ID based on a new firmware change. Patch 5 removes code that
disables ID protection to avoid conflict with static Switchtec config
settings.

This patchset is based on 5.16.0-rc5.

Thanks,
Kelvin

Jeremy Pallotta (2):
  ntb_hw_switchtec: Fix pff ioread to read into mmio_part_cfg_all
  ntb_hw_switchtec: AND with the part_map for a valid tpart_vec

Kelvin Cao (3):
  ntb_hw_switchtec: Update the way of getting VEP instance ID
  ntb_hw_switchtec: Remove code for disabling ID protection
  ntb_hw_switchtec: Fix a minor issue in config_req_id_table()

Wesley Sheng (1):
  ntb_hw_switchtec: Fix bug with more than 32 partitions

 drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 24 +++++++++++-------------
 include/linux/switchtec.h              |  2 --
 2 files changed, 11 insertions(+), 15 deletions(-)

Comments

Logan Gunthorpe Jan. 4, 2022, 4:55 p.m. UTC | #1

On 2021-12-23 6:23 p.m., Kelvin Cao wrote:
> Hi,
> 
> Please find a bunch of patches for the Switchtec NTB driver.
> 
> Patche 1, 2 and 6 fix three minor bugs. Patch 3 works around a minor
> firmware issue. Patch 4 updates the method of getting management VEP
> instance ID based on a new firmware change. Patch 5 removes code that
> disables ID protection to avoid conflict with static Switchtec config
> settings.
> 
> This patchset is based on 5.16.0-rc5.
> 
> Thanks,
> Kelvin
> 
> Jeremy Pallotta (2):
>   ntb_hw_switchtec: Fix pff ioread to read into mmio_part_cfg_all
>   ntb_hw_switchtec: AND with the part_map for a valid tpart_vec
> 
> Kelvin Cao (3):
>   ntb_hw_switchtec: Update the way of getting VEP instance ID
>   ntb_hw_switchtec: Remove code for disabling ID protection
>   ntb_hw_switchtec: Fix a minor issue in config_req_id_table()
> 
> Wesley Sheng (1):
>   ntb_hw_switchtec: Fix bug with more than 32 partitions

I've reviewed all these patches and they look good to me.

Reviewed-by: Logan Gunthorpe <[e-mail]>

Thanks,

Logan

Kelvin Cao Jan. 4, 2022, 9:28 p.m. UTC | #2

On Tue, 2022-01-04 at 09:55 -0700, Logan Gunthorpe wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> On 2021-12-23 6:23 p.m., Kelvin Cao wrote:
> > Hi,
> > 
> > Please find a bunch of patches for the Switchtec NTB driver.
> > 
> > Patche 1, 2 and 6 fix three minor bugs. Patch 3 works around a
> > minor
> > firmware issue. Patch 4 updates the method of getting management
> > VEP
> > instance ID based on a new firmware change. Patch 5 removes code
> > that
> > disables ID protection to avoid conflict with static Switchtec
> > config
> > settings.
> > 
> > This patchset is based on 5.16.0-rc5.
> > 
> > Thanks,
> > Kelvin
> > 
> > Jeremy Pallotta (2):
> >   ntb_hw_switchtec: Fix pff ioread to read into mmio_part_cfg_all
> >   ntb_hw_switchtec: AND with the part_map for a valid tpart_vec
> > 
> > Kelvin Cao (3):
> >   ntb_hw_switchtec: Update the way of getting VEP instance ID
> >   ntb_hw_switchtec: Remove code for disabling ID protection
> >   ntb_hw_switchtec: Fix a minor issue in config_req_id_table()
> > 
> > Wesley Sheng (1):
> >   ntb_hw_switchtec: Fix bug with more than 32 partitions
> 
> I've reviewed all these patches and they look good to me.
> 
> Reviewed-by: Logan Gunthorpe <[e-mail]>
> 
Thanks Logan!

Kelvin

> Thanks,
> 
> Logan