| Message ID | 20220104162947.1320936-1-gregkh@linuxfoundation.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | block/rnbd-clt-sysfs: use default_groups in kobj_type | expand |
On Tue, Jan 4, 2022 at 5:29 PM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > There are currently 2 ways to create a set of sysfs files for a > kobj_type, through the default_attrs field, and the default_groups > field. Move the rnbd controller sysfs code to use default_groups field > which has been the preferred way since aa30f47cf666 ("kobject: Add > support for default attribute groups to kobj_type") so that we can soon > get rid of the obsolete default_attrs field. > > Cc: "Md. Haris Iqbal" <haris.iqbal@ionos.com> > Cc: Jack Wang <jinpu.wang@ionos.com> > Cc: Jens Axboe <axboe@kernel.dk> > Cc: linux-block@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Acked-by: Jack Wang <jinpu.wang@ionos.com> Thanks! > --- > drivers/block/rnbd/rnbd-clt-sysfs.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/block/rnbd/rnbd-clt-sysfs.c b/drivers/block/rnbd/rnbd-clt-sysfs.c > index 44e45af00e83..2be5d87a3ca6 100644 > --- a/drivers/block/rnbd/rnbd-clt-sysfs.c > +++ b/drivers/block/rnbd/rnbd-clt-sysfs.c > @@ -452,6 +452,7 @@ static struct attribute *rnbd_dev_attrs[] = { > &rnbd_clt_nr_poll_queues.attr, > NULL, > }; > +ATTRIBUTE_GROUPS(rnbd_dev); > > void rnbd_clt_remove_dev_symlink(struct rnbd_clt_dev *dev) > { > @@ -474,7 +475,7 @@ void rnbd_clt_remove_dev_symlink(struct rnbd_clt_dev *dev) > > static struct kobj_type rnbd_dev_ktype = { > .sysfs_ops = &kobj_sysfs_ops, > - .default_attrs = rnbd_dev_attrs, > + .default_groups = rnbd_dev_groups, > }; > > static int rnbd_clt_add_dev_kobj(struct rnbd_clt_dev *dev) > -- > 2.34.1 >
On Tue, 4 Jan 2022 17:29:47 +0100, Greg Kroah-Hartman wrote: > There are currently 2 ways to create a set of sysfs files for a > kobj_type, through the default_attrs field, and the default_groups > field. Move the rnbd controller sysfs code to use default_groups field > which has been the preferred way since aa30f47cf666 ("kobject: Add > support for default attribute groups to kobj_type") so that we can soon > get rid of the obsolete default_attrs field. > > [...] Applied, thanks! [1/1] block/rnbd-clt-sysfs: use default_groups in kobj_type commit: 050f461e28c5d13f327353d660ffad2603ce7ac1 Best regards,
diff --git a/drivers/block/rnbd/rnbd-clt-sysfs.c b/drivers/block/rnbd/rnbd-clt-sysfs.c index 44e45af00e83..2be5d87a3ca6 100644 --- a/drivers/block/rnbd/rnbd-clt-sysfs.c +++ b/drivers/block/rnbd/rnbd-clt-sysfs.c @@ -452,6 +452,7 @@ static struct attribute *rnbd_dev_attrs[] = { &rnbd_clt_nr_poll_queues.attr, NULL, }; +ATTRIBUTE_GROUPS(rnbd_dev); void rnbd_clt_remove_dev_symlink(struct rnbd_clt_dev *dev) { @@ -474,7 +475,7 @@ void rnbd_clt_remove_dev_symlink(struct rnbd_clt_dev *dev) static struct kobj_type rnbd_dev_ktype = { .sysfs_ops = &kobj_sysfs_ops, - .default_attrs = rnbd_dev_attrs, + .default_groups = rnbd_dev_groups, }; static int rnbd_clt_add_dev_kobj(struct rnbd_clt_dev *dev)
There are currently 2 ways to create a set of sysfs files for a kobj_type, through the default_attrs field, and the default_groups field. Move the rnbd controller sysfs code to use default_groups field which has been the preferred way since aa30f47cf666 ("kobject: Add support for default attribute groups to kobj_type") so that we can soon get rid of the obsolete default_attrs field. Cc: "Md. Haris Iqbal" <haris.iqbal@ionos.com> Cc: Jack Wang <jinpu.wang@ionos.com> Cc: Jens Axboe <axboe@kernel.dk> Cc: linux-block@vger.kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/block/rnbd/rnbd-clt-sysfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)