Message ID | 20211216054842.1099428-1-yanjun.zhu@linux.dev (mailing list archive) |
---|---|
State | Accepted |
Delegated to: | Jason Gunthorpe |
Headers | show |
Series | [1/1] RDMA/rxe: Remove the unused variable | expand |
On Thu, Dec 16, 2021 at 12:48:42AM -0500, yanjun.zhu@linux.dev wrote: > From: Zhu Yanjun <yanjun.zhu@linux.dev> > > The member variable xmit_errors can be replaced with > rxe_counter_inc(rxe, RXE_CNT_SEND_ERR) totally. So > remove it. > > Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev> > --- > drivers/infiniband/sw/rxe/rxe_net.c | 1 - > drivers/infiniband/sw/rxe/rxe_verbs.h | 2 -- > 2 files changed, 3 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
On Thu, Dec 16, 2021 at 12:48:42AM -0500, yanjun.zhu@linux.dev wrote: > From: Zhu Yanjun <yanjun.zhu@linux.dev> > > The member variable xmit_errors can be replaced with > rxe_counter_inc(rxe, RXE_CNT_SEND_ERR) totally. So > remove it. > > Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev> > Reviewed-by: Leon Romanovsky <leonro@nvidia.com> > --- > drivers/infiniband/sw/rxe/rxe_net.c | 1 - > drivers/infiniband/sw/rxe/rxe_verbs.h | 2 -- > 2 files changed, 3 deletions(-) Applied to for-next, thanks Jason
diff --git a/drivers/infiniband/sw/rxe/rxe_net.c b/drivers/infiniband/sw/rxe/rxe_net.c index 2cb810cb890a..112506c31b37 100644 --- a/drivers/infiniband/sw/rxe/rxe_net.c +++ b/drivers/infiniband/sw/rxe/rxe_net.c @@ -444,7 +444,6 @@ int rxe_xmit_packet(struct rxe_qp *qp, struct rxe_pkt_info *pkt, else err = rxe_send(skb, pkt); if (err) { - rxe->xmit_errors++; rxe_counter_inc(rxe, RXE_CNT_SEND_ERR); return err; } diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.h b/drivers/infiniband/sw/rxe/rxe_verbs.h index 35e041450090..af0117710175 100644 --- a/drivers/infiniband/sw/rxe/rxe_verbs.h +++ b/drivers/infiniband/sw/rxe/rxe_verbs.h @@ -392,8 +392,6 @@ struct rxe_dev { struct net_device *ndev; - int xmit_errors; - struct rxe_pool uc_pool; struct rxe_pool pd_pool; struct rxe_pool ah_pool;