mbox series

[v3,0/3] hw/net: Move MV88W8618 network device out of hw/arm/ directory

Message ID 20211217233006.1466747-1-f4bug@amsat.org (mailing list archive)
Headers show
Series hw/net: Move MV88W8618 network device out of hw/arm/ directory | expand

Message

Philippe Mathieu-Daudé Dec. 17, 2021, 11:30 p.m. UTC 
This series simply extract the MV88W8618 device from the ARM
machine in hw/arm/ and move it to hw/net/.

Since v2:
- declare MARVELL_88W8618 in hw/arm/Kconfig
- use MARVELL_88W8618 Kconfig (rth)

Since v1:
- update (c) notice

Philippe Mathieu-Daudé (3):
  hw: Move MARVELL_88W8618 Kconfig from audio/ to arm/
  hw/arm/musicpal: Fix coding style of code related to MV88W8618 device
  hw/net: Move MV88W8618 network device out of hw/arm/ directory

 include/hw/net/mv88w8618_eth.h |  12 +
 hw/arm/musicpal.c              | 380 +------------------------------
 hw/net/mv88w8618_eth.c         | 402 +++++++++++++++++++++++++++++++++
 MAINTAINERS                    |   2 +
 hw/arm/Kconfig                 |   3 +
 hw/audio/Kconfig               |   3 -
 hw/net/meson.build             |   1 +
 7 files changed, 421 insertions(+), 382 deletions(-)
 create mode 100644 include/hw/net/mv88w8618_eth.h
 create mode 100644 hw/net/mv88w8618_eth.c

Comments

Peter Maydell Jan. 6, 2022, 2:48 p.m. UTC | #1 
On Fri, 17 Dec 2021 at 23:30, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> This series simply extract the MV88W8618 device from the ARM
> machine in hw/arm/ and move it to hw/net/.
>
> Since v2:
> - declare MARVELL_88W8618 in hw/arm/Kconfig
> - use MARVELL_88W8618 Kconfig (rth)
>
> Since v1:
> - update (c) notice

Looks like the code-movement in this patchset has a clash with
your other series that's now in master that changed the signature
of dma_memory_read/dma_memory_write; could I ask you to respin,
please?

thanks
-- PMM
Philippe Mathieu-Daudé Jan. 7, 2022, 6:34 p.m. UTC | #2 
On 1/6/22 15:48, Peter Maydell wrote:
> On Fri, 17 Dec 2021 at 23:30, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>>
>> This series simply extract the MV88W8618 device from the ARM
>> machine in hw/arm/ and move it to hw/net/.
>>
>> Since v2:
>> - declare MARVELL_88W8618 in hw/arm/Kconfig
>> - use MARVELL_88W8618 Kconfig (rth)
>>
>> Since v1:
>> - update (c) notice
> 
> Looks like the code-movement in this patchset has a clash with
> your other series that's now in master that changed the signature
> of dma_memory_read/dma_memory_write; could I ask you to respin,
> please?

Oops I didn't notice, sorry. Sure, will respin.