[v2,0/4] x86/PCI: Odd generic PIRQ router improvements

Message

Maciej W. Rozycki Jan. 2, 2022, 11:24 p.m. UTC

Hi,

 Resending as this has gone into void.  Also there is a context dependency 
with a change developed later possibly causing a merge conflict, so to 
make it easier to queue the incoming patches I have folded the follow-up 
change into this series, expanding it to 4 patches from the original 3 and 
mechanically regenerating according to upstream changes.  I have updated 
the cover letter accordingly.

 While working on the SiS85C497 PIRQ router I have noticed an odd
phenomenon with my venerable Tyan Tomcat IV S1564D board, where the PCI 
INTD# line of the USB host controller included as function 3 of the PIIX3 
southbridge cannot be routed in the `noapic' mode.  As it turns out the 
reason for this is the BIOS has two individual entries in its PIRQ table 
for two of its three functions, and the wrong one is chosen for routing 
said line.

 Strictly speaking this violates the PCI BIOS specification, but it can be 
easily worked around while preserving the semantics for compliant systems.

 Therefore I have come up with this patch series, which addresses this 
problem with 3/4, adds function reporting to the debug PIRQ table dump 
with 2/4 and also prints a usable physical memory address of the PIRQ 
table in a debug message with 1/4.

 Then 4/4 follows, addressing the inability to use a PIRQ table to route 
interrupts for devices placed behind PCI-to-PCI bridges on option cards, 
and especially where the BIOS has failed to enumerate the whole bus tree 
in the first place.

 See individual change descriptions for further details.

 Please apply.

  Maciej

Comments

Bjorn Helgaas Jan. 6, 2022, 11:25 p.m. UTC | #1

On Sun, Jan 02, 2022 at 11:24:19PM +0000, Maciej W. Rozycki wrote:
> Hi,
> 
>  Resending as this has gone into void.  Also there is a context dependency 
> with a change developed later possibly causing a merge conflict, so to 
> make it easier to queue the incoming patches I have folded the follow-up 
> change into this series, expanding it to 4 patches from the original 3 and 
> mechanically regenerating according to upstream changes.  I have updated 
> the cover letter accordingly.

I'm assuming the x86/IRQ folks will handle this, too.