| Message ID | 20220106172441.7399-2-laurent.pinchart@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | staging: media: imx7-mipi-csis: Small improvements | expand |
Hi Laurent, On Thu Jan 6, 2022 at 5:24 PM WET, Laurent Pinchart wrote: > The frame counter is useful debugging information, add it to the > register dump printed by mipi_csis_dump_regs(). > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> LGTM Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com> Cheers, Rui > --- > drivers/staging/media/imx/imx7-mipi-csis.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c > index 2b73fa55c938..c9c0089ad816 100644 > --- a/drivers/staging/media/imx/imx7-mipi-csis.c > +++ b/drivers/staging/media/imx/imx7-mipi-csis.c > @@ -211,6 +211,8 @@ > #define MIPI_CSIS_DBG_INTR_SRC_CAM_VSYNC_FALL BIT(4) > #define MIPI_CSIS_DBG_INTR_SRC_CAM_VSYNC_RISE BIT(0) > > +#define MIPI_CSIS_FRAME_COUNTER_CH(n) (0x0100 + (n) * 4) > + > /* Non-image packet data buffers */ > #define MIPI_CSIS_PKTDATA_ODD 0x2000 > #define MIPI_CSIS_PKTDATA_EVEN 0x3000 > @@ -773,6 +775,7 @@ static int mipi_csis_dump_regs(struct csi_state *state) > { MIPI_CSIS_SDW_CONFIG_CH(0), "SDW_CONFIG_CH0" }, > { MIPI_CSIS_SDW_RESOL_CH(0), "SDW_RESOL_CH0" }, > { MIPI_CSIS_DBG_CTRL, "DBG_CTRL" }, > + { MIPI_CSIS_FRAME_COUNTER_CH(0), "FRAME_COUNTER_CH0" }, > }; > > unsigned int i; > -- > Regards, > > Laurent Pinchart
diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c index 2b73fa55c938..c9c0089ad816 100644 --- a/drivers/staging/media/imx/imx7-mipi-csis.c +++ b/drivers/staging/media/imx/imx7-mipi-csis.c @@ -211,6 +211,8 @@ #define MIPI_CSIS_DBG_INTR_SRC_CAM_VSYNC_FALL BIT(4) #define MIPI_CSIS_DBG_INTR_SRC_CAM_VSYNC_RISE BIT(0) +#define MIPI_CSIS_FRAME_COUNTER_CH(n) (0x0100 + (n) * 4) + /* Non-image packet data buffers */ #define MIPI_CSIS_PKTDATA_ODD 0x2000 #define MIPI_CSIS_PKTDATA_EVEN 0x3000 @@ -773,6 +775,7 @@ static int mipi_csis_dump_regs(struct csi_state *state) { MIPI_CSIS_SDW_CONFIG_CH(0), "SDW_CONFIG_CH0" }, { MIPI_CSIS_SDW_RESOL_CH(0), "SDW_RESOL_CH0" }, { MIPI_CSIS_DBG_CTRL, "DBG_CTRL" }, + { MIPI_CSIS_FRAME_COUNTER_CH(0), "FRAME_COUNTER_CH0" }, }; unsigned int i;
The frame counter is useful debugging information, add it to the register dump printed by mipi_csis_dump_regs(). Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- drivers/staging/media/imx/imx7-mipi-csis.c | 3 +++ 1 file changed, 3 insertions(+)