diff mbox series

[01/11] drm/radeon: use ttm_resource_manager_debug

Message ID 20220124130328.2376-2-christian.koenig@amd.com (mailing list archive)
State New, archived
Headers show
Series [01/11] drm/radeon: use ttm_resource_manager_debug | expand

Commit Message

Christian König Jan. 24, 2022, 1:03 p.m. UTC
Instead of calling the debug operation directly.

Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Huang Rui <ray.huang@amd.com>
---
 drivers/gpu/drm/radeon/radeon_ttm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Thomas Hellström Jan. 24, 2022, 4:33 p.m. UTC | #1
On Mon, 2022-01-24 at 14:03 +0100, Christian König wrote:
> Instead of calling the debug operation directly.
> 
> Signed-off-by: Christian König <christian.koenig@amd.com>
> Reviewed-by: Huang Rui <ray.huang@amd.com>

The first two patches seem unrelated to the series. Also is there a
chance of a series cover-letter?

Thanks,
Thomas



> ---
>  drivers/gpu/drm/radeon/radeon_ttm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c
> b/drivers/gpu/drm/radeon/radeon_ttm.c
> index 11b21d605584..0d1283cdc8fb 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -802,7 +802,7 @@ static int radeon_mm_vram_dump_table_show(struct
> seq_file *m, void *unused)
>                                                            
> TTM_PL_VRAM);
>         struct drm_printer p = drm_seq_file_printer(m);
>  
> -       man->func->debug(man, &p);
> +       ttm_resource_manager_debug(man, &p);
>         return 0;
>  }
>  
> @@ -820,7 +820,7 @@ static int radeon_mm_gtt_dump_table_show(struct
> seq_file *m, void *unused)
>                                                            
> TTM_PL_TT);
>         struct drm_printer p = drm_seq_file_printer(m);
>  
> -       man->func->debug(man, &p);
> +       ttm_resource_manager_debug(man, &p);
>         return 0;
>  }
>
Christian König Jan. 24, 2022, 8:21 p.m. UTC | #2
Am 24.01.22 um 17:33 schrieb Thomas Hellström:
> On Mon, 2022-01-24 at 14:03 +0100, Christian König wrote:
>> Instead of calling the debug operation directly.
>>
>> Signed-off-by: Christian König <christian.koenig@amd.com>
>> Reviewed-by: Huang Rui <ray.huang@amd.com>
> The first two patches seem unrelated to the series.

No idea what happened here, those two are already upstream.

I probably just forgot to pull drm-misc-next changes from a different 
system.

> Also is there a chance of a series cover-letter?

Going to add one the next time, but I though it would be pretty clear 
what this is now about.

Thanks,
Christian.

>
> Thanks,
> Thomas
>
>
>
>> ---
>>   drivers/gpu/drm/radeon/radeon_ttm.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c
>> b/drivers/gpu/drm/radeon/radeon_ttm.c
>> index 11b21d605584..0d1283cdc8fb 100644
>> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
>> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
>> @@ -802,7 +802,7 @@ static int radeon_mm_vram_dump_table_show(struct
>> seq_file *m, void *unused)
>>                                                             
>> TTM_PL_VRAM);
>>          struct drm_printer p = drm_seq_file_printer(m);
>>   
>> -       man->func->debug(man, &p);
>> +       ttm_resource_manager_debug(man, &p);
>>          return 0;
>>   }
>>   
>> @@ -820,7 +820,7 @@ static int radeon_mm_gtt_dump_table_show(struct
>> seq_file *m, void *unused)
>>                                                             
>> TTM_PL_TT);
>>          struct drm_printer p = drm_seq_file_printer(m);
>>   
>> -       man->func->debug(man, &p);
>> +       ttm_resource_manager_debug(man, &p);
>>          return 0;
>>   }
>>   
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
index 11b21d605584..0d1283cdc8fb 100644
--- a/drivers/gpu/drm/radeon/radeon_ttm.c
+++ b/drivers/gpu/drm/radeon/radeon_ttm.c
@@ -802,7 +802,7 @@  static int radeon_mm_vram_dump_table_show(struct seq_file *m, void *unused)
 							    TTM_PL_VRAM);
 	struct drm_printer p = drm_seq_file_printer(m);
 
-	man->func->debug(man, &p);
+	ttm_resource_manager_debug(man, &p);
 	return 0;
 }
 
@@ -820,7 +820,7 @@  static int radeon_mm_gtt_dump_table_show(struct seq_file *m, void *unused)
 							    TTM_PL_TT);
 	struct drm_printer p = drm_seq_file_printer(m);
 
-	man->func->debug(man, &p);
+	ttm_resource_manager_debug(man, &p);
 	return 0;
 }