| Message ID | 20220203193803.45671-4-f4bug@amsat.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | exec: Remove 'qemu/log.h' from 'exec-all.h' | expand |
On 03/02/2022 20.37, Philippe Mathieu-Daudé wrote: > CPUS390XState is declared in "cpu.h". And how is this related to your qemu/log.h refactoring / why is this patch needed now? > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > hw/s390x/s390-virtio-hcall.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/s390x/s390-virtio-hcall.h b/hw/s390x/s390-virtio-hcall.h > index 9800c4b351..9773ed8a21 100644 > --- a/hw/s390x/s390-virtio-hcall.h > +++ b/hw/s390x/s390-virtio-hcall.h > @@ -13,6 +13,7 @@ > #define HW_S390_VIRTIO_HCALL_H > > #include "standard-headers/asm-s390/virtio-ccw.h" > +#include "cpu.h" > > /* The only thing that we need from the old kvm_virtio.h file */ > #define KVM_S390_VIRTIO_NOTIFY 0 Anyway: Acked-by: Thomas Huth <thuth@redhat.com>
On 4/2/22 08:50, Thomas Huth wrote: > On 03/02/2022 20.37, Philippe Mathieu-Daudé wrote: >> CPUS390XState is declared in "cpu.h". > > And how is this related to your qemu/log.h refactoring / why is this > patch needed now? Hmm I might have been too overzealous when splitting in 3 parts, this belong to the 3rd part then. >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >> --- >> hw/s390x/s390-virtio-hcall.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/hw/s390x/s390-virtio-hcall.h b/hw/s390x/s390-virtio-hcall.h >> index 9800c4b351..9773ed8a21 100644 >> --- a/hw/s390x/s390-virtio-hcall.h >> +++ b/hw/s390x/s390-virtio-hcall.h >> @@ -13,6 +13,7 @@ >> #define HW_S390_VIRTIO_HCALL_H >> #include "standard-headers/asm-s390/virtio-ccw.h" >> +#include "cpu.h" >> /* The only thing that we need from the old kvm_virtio.h file */ >> #define KVM_S390_VIRTIO_NOTIFY 0 > > Anyway: > Acked-by: Thomas Huth <thuth@redhat.com> >
On Thu, 3 Feb 2022 20:37:56 +0100 Philippe Mathieu-Daudé via <qemu-devel@nongnu.org> wrote: > CPUS390XState is declared in "cpu.h". > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> No objections :) Acked-by: Halil Pasic <pasic@linux.ibm.com>
On 2/4/22 06:37, Philippe Mathieu-Daudé wrote: > CPUS390XState is declared in "cpu.h". > > Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org> > --- > hw/s390x/s390-virtio-hcall.h | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/hw/s390x/s390-virtio-hcall.h b/hw/s390x/s390-virtio-hcall.h index 9800c4b351..9773ed8a21 100644 --- a/hw/s390x/s390-virtio-hcall.h +++ b/hw/s390x/s390-virtio-hcall.h @@ -13,6 +13,7 @@ #define HW_S390_VIRTIO_HCALL_H #include "standard-headers/asm-s390/virtio-ccw.h" +#include "cpu.h" /* The only thing that we need from the old kvm_virtio.h file */ #define KVM_S390_VIRTIO_NOTIFY 0
CPUS390XState is declared in "cpu.h". Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- hw/s390x/s390-virtio-hcall.h | 1 + 1 file changed, 1 insertion(+)