[05/10] qtest: Add missing 'hw/qdev-core.h' include

Commit Message

Philippe Mathieu-Daudé Feb. 3, 2022, 7:37 p.m. UTC

Add "hw/qdev-core.h" to avoid when refactoring include/:

  softmmu/qtest.c:404:9: error: use of undeclared identifier 'NamedGPIOList'
        NamedGPIOList *ngl;
        ^

Signed-off-by: Philippe Mathieu-Daudé <[e-mail]>
---
 softmmu/qtest.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Huth Feb. 4, 2022, 2:56 p.m. UTC | #1

On 03/02/2022 20.37, Philippe Mathieu-Daudé wrote:
> Add "hw/qdev-core.h" to avoid when refactoring include/:
> 
>    softmmu/qtest.c:404:9: error: use of undeclared identifier 'NamedGPIOList'
>          NamedGPIOList *ngl;
>          ^
> 
> Signed-off-by: Philippe Mathieu-Daudé <[e-mail]>
> ---
>   softmmu/qtest.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/softmmu/qtest.c b/softmmu/qtest.c
> index 72751e1fd8..8b7cb6aa8e 100644
> --- a/softmmu/qtest.c
> +++ b/softmmu/qtest.c
> @@ -19,6 +19,7 @@
>   #include "chardev/char-fe.h"
>   #include "exec/ioport.h"
>   #include "exec/memory.h"
> +#include "hw/qdev-core.h"
>   #include "hw/irq.h"
>   #include "qemu/accel.h"
>   #include "sysemu/cpu-timers.h"

Reviewed-by: Thomas Huth <[e-mail]>

Richard Henderson Feb. 5, 2022, 11:50 p.m. UTC | #2

On 2/4/22 06:37, Philippe Mathieu-Daudé wrote:
> Add "hw/qdev-core.h" to avoid when refactoring include/:
> 
>    softmmu/qtest.c:404:9: error: use of undeclared identifier 'NamedGPIOList'
>          NamedGPIOList *ngl;
>          ^
> 
> Signed-off-by: Philippe Mathieu-Daudé<[e-mail]>
> ---
>   softmmu/qtest.c | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Richard Henderson <[e-mail]>

r~

Patch

diff --git a/softmmu/qtest.c b/softmmu/qtest.c
index 72751e1fd8..8b7cb6aa8e 100644
--- a/softmmu/qtest.c
+++ b/softmmu/qtest.c
@@ -19,6 +19,7 @@ 
 #include "chardev/char-fe.h"
 #include "exec/ioport.h"
 #include "exec/memory.h"
+#include "hw/qdev-core.h"
 #include "hw/irq.h"
 #include "qemu/accel.h"
 #include "sysemu/cpu-timers.h"