| Message ID | 20220203193803.45671-7-f4bug@amsat.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | exec: Remove 'qemu/log.h' from 'exec-all.h' | expand |
On 03/02/2022 20.37, Philippe Mathieu-Daudé wrote: > Add missing includes to avoid when refactoring include/ > > include/exec/ramblock.h:26:21: error: field has incomplete type 'struct rcu_head' > struct rcu_head rcu; > ^ ... and errors due to missing definition of RAMBlockNotifier. > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > include/exec/ramblock.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/exec/ramblock.h b/include/exec/ramblock.h > index 664701b759..6cbedf9e0c 100644 > --- a/include/exec/ramblock.h > +++ b/include/exec/ramblock.h > @@ -21,6 +21,8 @@ > > #ifndef CONFIG_USER_ONLY > #include "cpu-common.h" > +#include "qemu/rcu.h" > +#include "exec/ramlist.h" > > struct RAMBlock { > struct rcu_head rcu; Reviewed-by: Thomas Huth <thuth@redhat.com>
On 2/4/22 06:37, Philippe Mathieu-Daudé wrote: > Add missing includes to avoid when refactoring include/ > > include/exec/ramblock.h:26:21: error: field has incomplete type 'struct rcu_head' > struct rcu_head rcu; > ^ > > Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org> > --- > include/exec/ramblock.h | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/include/exec/ramblock.h b/include/exec/ramblock.h index 664701b759..6cbedf9e0c 100644 --- a/include/exec/ramblock.h +++ b/include/exec/ramblock.h @@ -21,6 +21,8 @@ #ifndef CONFIG_USER_ONLY #include "cpu-common.h" +#include "qemu/rcu.h" +#include "exec/ramlist.h" struct RAMBlock { struct rcu_head rcu;
Add missing includes to avoid when refactoring include/ include/exec/ramblock.h:26:21: error: field has incomplete type 'struct rcu_head' struct rcu_head rcu; ^ Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- include/exec/ramblock.h | 2 ++ 1 file changed, 2 insertions(+)