| Message ID | 20220203193803.45671-9-f4bug@amsat.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | exec: Remove 'qemu/log.h' from 'exec-all.h' | expand |
On 03/02/2022 20.38, Philippe Mathieu-Daudé wrote: > cpu_get_host_ticks() and NANOSECONDS_PER_SECOND are declared > in "qemu/timer.h". Seems like target/hppa/cpu.c uses neither of those? ... ok, but it uses timer_new_ns(), so the hunk is still ok. Maybe worth to mention it here in the commit description. > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > target/arm/cpu.c | 1 + > target/arm/helper.c | 1 + > target/hppa/cpu.c | 1 + > target/riscv/csr.c | 1 + > target/sparc/helper.c | 1 + > 5 files changed, 5 insertions(+) > > diff --git a/target/arm/cpu.c b/target/arm/cpu.c > index cdbc4cdd01..9555f6707b 100644 > --- a/target/arm/cpu.c > +++ b/target/arm/cpu.c > @@ -20,6 +20,7 @@ > > #include "qemu/osdep.h" > #include "qemu/qemu-print.h" > +#include "qemu/timer.h" > #include "qemu-common.h" > #include "target/arm/idau.h" > #include "qemu/module.h" > diff --git a/target/arm/helper.c b/target/arm/helper.c > index 6dd241fbef..e39faa2a98 100644 > --- a/target/arm/helper.c > +++ b/target/arm/helper.c > @@ -15,6 +15,7 @@ > #include "exec/helper-proto.h" > #include "qemu/host-utils.h" > #include "qemu/main-loop.h" > +#include "qemu/timer.h" > #include "qemu/bitops.h" > #include "qemu/crc32c.h" > #include "qemu/qemu-print.h" > diff --git a/target/hppa/cpu.c b/target/hppa/cpu.c > index 37b763fca0..5f46ba801e 100644 > --- a/target/hppa/cpu.c > +++ b/target/hppa/cpu.c > @@ -21,6 +21,7 @@ > #include "qemu/osdep.h" > #include "qapi/error.h" > #include "qemu/qemu-print.h" > +#include "qemu/timer.h" > #include "cpu.h" > #include "qemu/module.h" > #include "exec/exec-all.h" > diff --git a/target/riscv/csr.c b/target/riscv/csr.c > index a4db40769b..45f04c701a 100644 > --- a/target/riscv/csr.c > +++ b/target/riscv/csr.c > @@ -19,6 +19,7 @@ > > #include "qemu/osdep.h" > #include "qemu/log.h" > +#include "qemu/timer.h" > #include "cpu.h" > #include "qemu/main-loop.h" > #include "exec/exec-all.h" > diff --git a/target/sparc/helper.c b/target/sparc/helper.c > index c7bcaa3a20..c4358bba84 100644 > --- a/target/sparc/helper.c > +++ b/target/sparc/helper.c > @@ -20,6 +20,7 @@ > #include "qemu/osdep.h" > #include "cpu.h" > #include "exec/exec-all.h" > +#include "qemu/timer.h" > #include "qemu/host-utils.h" > #include "exec/helper-proto.h" > Reviewed-by: Thomas Huth <thuth@redhat.com>
On 2/4/22 06:38, Philippe Mathieu-Daudé wrote: > cpu_get_host_ticks() and NANOSECONDS_PER_SECOND are declared > in "qemu/timer.h". > > Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org> > --- > target/arm/cpu.c | 1 + > target/arm/helper.c | 1 + > target/hppa/cpu.c | 1 + > target/riscv/csr.c | 1 + > target/sparc/helper.c | 1 + > 5 files changed, 5 insertions(+) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On Fri, Feb 4, 2022 at 6:35 AM Philippe Mathieu-Daudé via <qemu-devel@nongnu.org> wrote: > > cpu_get_host_ticks() and NANOSECONDS_PER_SECOND are declared > in "qemu/timer.h". > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > target/arm/cpu.c | 1 + > target/arm/helper.c | 1 + > target/hppa/cpu.c | 1 + > target/riscv/csr.c | 1 + > target/sparc/helper.c | 1 + > 5 files changed, 5 insertions(+) > > diff --git a/target/arm/cpu.c b/target/arm/cpu.c > index cdbc4cdd01..9555f6707b 100644 > --- a/target/arm/cpu.c > +++ b/target/arm/cpu.c > @@ -20,6 +20,7 @@ > > #include "qemu/osdep.h" > #include "qemu/qemu-print.h" > +#include "qemu/timer.h" > #include "qemu-common.h" > #include "target/arm/idau.h" > #include "qemu/module.h" > diff --git a/target/arm/helper.c b/target/arm/helper.c > index 6dd241fbef..e39faa2a98 100644 > --- a/target/arm/helper.c > +++ b/target/arm/helper.c > @@ -15,6 +15,7 @@ > #include "exec/helper-proto.h" > #include "qemu/host-utils.h" > #include "qemu/main-loop.h" > +#include "qemu/timer.h" > #include "qemu/bitops.h" > #include "qemu/crc32c.h" > #include "qemu/qemu-print.h" > diff --git a/target/hppa/cpu.c b/target/hppa/cpu.c > index 37b763fca0..5f46ba801e 100644 > --- a/target/hppa/cpu.c > +++ b/target/hppa/cpu.c > @@ -21,6 +21,7 @@ > #include "qemu/osdep.h" > #include "qapi/error.h" > #include "qemu/qemu-print.h" > +#include "qemu/timer.h" > #include "cpu.h" > #include "qemu/module.h" > #include "exec/exec-all.h" > diff --git a/target/riscv/csr.c b/target/riscv/csr.c > index a4db40769b..45f04c701a 100644 > --- a/target/riscv/csr.c > +++ b/target/riscv/csr.c > @@ -19,6 +19,7 @@ > > #include "qemu/osdep.h" > #include "qemu/log.h" > +#include "qemu/timer.h" > #include "cpu.h" > #include "qemu/main-loop.h" > #include "exec/exec-all.h" > diff --git a/target/sparc/helper.c b/target/sparc/helper.c > index c7bcaa3a20..c4358bba84 100644 > --- a/target/sparc/helper.c > +++ b/target/sparc/helper.c > @@ -20,6 +20,7 @@ > #include "qemu/osdep.h" > #include "cpu.h" > #include "exec/exec-all.h" > +#include "qemu/timer.h" > #include "qemu/host-utils.h" > #include "exec/helper-proto.h" > > -- > 2.34.1 > >
diff --git a/target/arm/cpu.c b/target/arm/cpu.c index cdbc4cdd01..9555f6707b 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -20,6 +20,7 @@ #include "qemu/osdep.h" #include "qemu/qemu-print.h" +#include "qemu/timer.h" #include "qemu-common.h" #include "target/arm/idau.h" #include "qemu/module.h" diff --git a/target/arm/helper.c b/target/arm/helper.c index 6dd241fbef..e39faa2a98 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -15,6 +15,7 @@ #include "exec/helper-proto.h" #include "qemu/host-utils.h" #include "qemu/main-loop.h" +#include "qemu/timer.h" #include "qemu/bitops.h" #include "qemu/crc32c.h" #include "qemu/qemu-print.h" diff --git a/target/hppa/cpu.c b/target/hppa/cpu.c index 37b763fca0..5f46ba801e 100644 --- a/target/hppa/cpu.c +++ b/target/hppa/cpu.c @@ -21,6 +21,7 @@ #include "qemu/osdep.h" #include "qapi/error.h" #include "qemu/qemu-print.h" +#include "qemu/timer.h" #include "cpu.h" #include "qemu/module.h" #include "exec/exec-all.h" diff --git a/target/riscv/csr.c b/target/riscv/csr.c index a4db40769b..45f04c701a 100644 --- a/target/riscv/csr.c +++ b/target/riscv/csr.c @@ -19,6 +19,7 @@ #include "qemu/osdep.h" #include "qemu/log.h" +#include "qemu/timer.h" #include "cpu.h" #include "qemu/main-loop.h" #include "exec/exec-all.h" diff --git a/target/sparc/helper.c b/target/sparc/helper.c index c7bcaa3a20..c4358bba84 100644 --- a/target/sparc/helper.c +++ b/target/sparc/helper.c @@ -20,6 +20,7 @@ #include "qemu/osdep.h" #include "cpu.h" #include "exec/exec-all.h" +#include "qemu/timer.h" #include "qemu/host-utils.h" #include "exec/helper-proto.h"
cpu_get_host_ticks() and NANOSECONDS_PER_SECOND are declared in "qemu/timer.h". Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- target/arm/cpu.c | 1 + target/arm/helper.c | 1 + target/hppa/cpu.c | 1 + target/riscv/csr.c | 1 + target/sparc/helper.c | 1 + 5 files changed, 5 insertions(+)