| Message ID | 20220210224329.2793-9-mario.limonciello@amd.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Overhaul is_thunderbolt | expand |
Hi, On 2/10/22 23:43, Mario Limonciello wrote: > Currently `pci_is_thunderbolt_attached` is used to indicate a device > is connected externally. > > The PCI core now marks such devices as removable and downstream drivers > can use this instead. > > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> Thanks, this looks good to me. I assume that this whole series will be merged in one go through another tree (e.g. the PCI tree), so here is my ack for merging this patch through another tree: Acked-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/platform/x86/apple-gmux.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/apple-gmux.c b/drivers/platform/x86/apple-gmux.c > index 04232fbc7d56..ffac15b9befd 100644 > --- a/drivers/platform/x86/apple-gmux.c > +++ b/drivers/platform/x86/apple-gmux.c > @@ -596,7 +596,7 @@ static int gmux_resume(struct device *dev) > > static int is_thunderbolt(struct device *dev, void *data) > { > - return pci_is_thunderbolt_attached(to_pci_dev(dev)); > + return dev_is_removable(dev); > } > > static int gmux_probe(struct pnp_dev *pnp, const struct pnp_device_id *id) >
On Fri, Feb 11, 2022 at 12:43 AM Mario Limonciello <mario.limonciello@amd.com> wrote: > > Currently `pci_is_thunderbolt_attached` is used to indicate a device > is connected externally. > > The PCI core now marks such devices as removable and downstream drivers > can use this instead. > > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> > --- > drivers/platform/x86/apple-gmux.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/apple-gmux.c b/drivers/platform/x86/apple-gmux.c > index 04232fbc7d56..ffac15b9befd 100644 > --- a/drivers/platform/x86/apple-gmux.c > +++ b/drivers/platform/x86/apple-gmux.c > @@ -596,7 +596,7 @@ static int gmux_resume(struct device *dev) > > static int is_thunderbolt(struct device *dev, void *data) > { > - return pci_is_thunderbolt_attached(to_pci_dev(dev)); > + return dev_is_removable(dev); > } > Maybe it's only me, but isn't it a bit strange to keep this function named `is_thunderbolt` while it's actually about being removable?
Hi, On 2/11/22 10:00, Yehezkel Bernat wrote: > On Fri, Feb 11, 2022 at 12:43 AM Mario Limonciello > <mario.limonciello@amd.com> wrote: >> >> Currently `pci_is_thunderbolt_attached` is used to indicate a device >> is connected externally. >> >> The PCI core now marks such devices as removable and downstream drivers >> can use this instead. >> >> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> >> --- >> drivers/platform/x86/apple-gmux.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/platform/x86/apple-gmux.c b/drivers/platform/x86/apple-gmux.c >> index 04232fbc7d56..ffac15b9befd 100644 >> --- a/drivers/platform/x86/apple-gmux.c >> +++ b/drivers/platform/x86/apple-gmux.c >> @@ -596,7 +596,7 @@ static int gmux_resume(struct device *dev) >> >> static int is_thunderbolt(struct device *dev, void *data) >> { >> - return pci_is_thunderbolt_attached(to_pci_dev(dev)); >> + return dev_is_removable(dev); >> } >> > > Maybe it's only me, but isn't it a bit strange to keep this function named > `is_thunderbolt` while it's actually about being removable? The comment above the only caller says: /* * If Thunderbolt is present, the external DP port is not fully * switchable. Force its AUX channel to the discrete GPU. */ gmux_data->external_switchable = !bus_for_each_dev(&pci_bus_type, NULL, NULL, is_thunderbolt); So IHMO keeping the name as is is fine. Regards, Hans
diff --git a/drivers/platform/x86/apple-gmux.c b/drivers/platform/x86/apple-gmux.c index 04232fbc7d56..ffac15b9befd 100644 --- a/drivers/platform/x86/apple-gmux.c +++ b/drivers/platform/x86/apple-gmux.c @@ -596,7 +596,7 @@ static int gmux_resume(struct device *dev) static int is_thunderbolt(struct device *dev, void *data) { - return pci_is_thunderbolt_attached(to_pci_dev(dev)); + return dev_is_removable(dev); } static int gmux_probe(struct pnp_dev *pnp, const struct pnp_device_id *id)
Currently `pci_is_thunderbolt_attached` is used to indicate a device is connected externally. The PCI core now marks such devices as removable and downstream drivers can use this instead. Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> --- drivers/platform/x86/apple-gmux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)