| Message ID | 20220209230030.93987-2-f4bug@amsat.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | exec: Split some user-mode specific declarations from 'exec/exec-all.h' | expand |
On 2/10/22 10:00, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > accel/tcg/tcg-accel-ops-icount.c | 1 + > accel/tcg/tcg-accel-ops-mttcg.c | 1 + > accel/tcg/tcg-accel-ops-rr.c | 1 + > accel/tcg/tcg-accel-ops.c | 1 + > 4 files changed, 4 insertions(+) What exactly are these files using from tcg.h? I briefly scanned tcg-accel-ops-icount.c and didn't see anything. r~ > > diff --git a/accel/tcg/tcg-accel-ops-icount.c b/accel/tcg/tcg-accel-ops-icount.c > index bdaf2c943b..379a9d44f4 100644 > --- a/accel/tcg/tcg-accel-ops-icount.c > +++ b/accel/tcg/tcg-accel-ops-icount.c > @@ -31,6 +31,7 @@ > #include "qemu/main-loop.h" > #include "qemu/guest-random.h" > #include "exec/exec-all.h" > +#include "tcg/tcg.h" > > #include "tcg-accel-ops.h" > #include "tcg-accel-ops-icount.h" > diff --git a/accel/tcg/tcg-accel-ops-mttcg.c b/accel/tcg/tcg-accel-ops-mttcg.c > index dc421c8fd7..de7dcb02e6 100644 > --- a/accel/tcg/tcg-accel-ops-mttcg.c > +++ b/accel/tcg/tcg-accel-ops-mttcg.c > @@ -33,6 +33,7 @@ > #include "qemu/guest-random.h" > #include "exec/exec-all.h" > #include "hw/boards.h" > +#include "tcg/tcg.h" > > #include "tcg-accel-ops.h" > #include "tcg-accel-ops-mttcg.h" > diff --git a/accel/tcg/tcg-accel-ops-rr.c b/accel/tcg/tcg-accel-ops-rr.c > index a805fb6bdd..889d0882a2 100644 > --- a/accel/tcg/tcg-accel-ops-rr.c > +++ b/accel/tcg/tcg-accel-ops-rr.c > @@ -32,6 +32,7 @@ > #include "qemu/notify.h" > #include "qemu/guest-random.h" > #include "exec/exec-all.h" > +#include "tcg/tcg.h" > > #include "tcg-accel-ops.h" > #include "tcg-accel-ops-rr.h" > diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c > index ea7dcad674..58e4b09043 100644 > --- a/accel/tcg/tcg-accel-ops.c > +++ b/accel/tcg/tcg-accel-ops.c > @@ -33,6 +33,7 @@ > #include "qemu/main-loop.h" > #include "qemu/guest-random.h" > #include "exec/exec-all.h" > +#include "tcg/tcg.h" > > #include "tcg-accel-ops.h" > #include "tcg-accel-ops-mttcg.h"
On 11/2/22 00:25, Richard Henderson wrote: > On 2/10/22 10:00, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >> --- >> accel/tcg/tcg-accel-ops-icount.c | 1 + >> accel/tcg/tcg-accel-ops-mttcg.c | 1 + >> accel/tcg/tcg-accel-ops-rr.c | 1 + >> accel/tcg/tcg-accel-ops.c | 1 + >> 4 files changed, 4 insertions(+) > > What exactly are these files using from tcg.h? > I briefly scanned tcg-accel-ops-icount.c and didn't see anything. extern __thread TCGContext *tcg_ctx; I'll mention it in the description.
diff --git a/accel/tcg/tcg-accel-ops-icount.c b/accel/tcg/tcg-accel-ops-icount.c index bdaf2c943b..379a9d44f4 100644 --- a/accel/tcg/tcg-accel-ops-icount.c +++ b/accel/tcg/tcg-accel-ops-icount.c @@ -31,6 +31,7 @@ #include "qemu/main-loop.h" #include "qemu/guest-random.h" #include "exec/exec-all.h" +#include "tcg/tcg.h" #include "tcg-accel-ops.h" #include "tcg-accel-ops-icount.h" diff --git a/accel/tcg/tcg-accel-ops-mttcg.c b/accel/tcg/tcg-accel-ops-mttcg.c index dc421c8fd7..de7dcb02e6 100644 --- a/accel/tcg/tcg-accel-ops-mttcg.c +++ b/accel/tcg/tcg-accel-ops-mttcg.c @@ -33,6 +33,7 @@ #include "qemu/guest-random.h" #include "exec/exec-all.h" #include "hw/boards.h" +#include "tcg/tcg.h" #include "tcg-accel-ops.h" #include "tcg-accel-ops-mttcg.h" diff --git a/accel/tcg/tcg-accel-ops-rr.c b/accel/tcg/tcg-accel-ops-rr.c index a805fb6bdd..889d0882a2 100644 --- a/accel/tcg/tcg-accel-ops-rr.c +++ b/accel/tcg/tcg-accel-ops-rr.c @@ -32,6 +32,7 @@ #include "qemu/notify.h" #include "qemu/guest-random.h" #include "exec/exec-all.h" +#include "tcg/tcg.h" #include "tcg-accel-ops.h" #include "tcg-accel-ops-rr.h" diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c index ea7dcad674..58e4b09043 100644 --- a/accel/tcg/tcg-accel-ops.c +++ b/accel/tcg/tcg-accel-ops.c @@ -33,6 +33,7 @@ #include "qemu/main-loop.h" #include "qemu/guest-random.h" #include "exec/exec-all.h" +#include "tcg/tcg.h" #include "tcg-accel-ops.h" #include "tcg-accel-ops-mttcg.h"
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- accel/tcg/tcg-accel-ops-icount.c | 1 + accel/tcg/tcg-accel-ops-mttcg.c | 1 + accel/tcg/tcg-accel-ops-rr.c | 1 + accel/tcg/tcg-accel-ops.c | 1 + 4 files changed, 4 insertions(+)