| Message ID | 20220218105358.283769-1-Jerome.Pouiller@silabs.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Johannes Berg |
| Headers | show |
| Series | staging: wfx: fix scan with WFM200 and WW regulation | expand |
On Friday 18 February 2022 11:53:58 CET Jerome Pouiller wrote: > From: Riccardo Ferrazzo <rferrazzo@came.com> > > Some variants of the WF200 disallow active scan on channel 12 and 13. > For these parts, the channels 12 and 13 are marked IEEE80211_CHAN_NO_IR. > > However, the beacon hint procedure was removing the flag > IEEE80211_CHAN_NO_IR from channels where a BSS is discovered. This was > making subsequent scans to fail because the driver was trying active > scans on prohibited channels. > > Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com> I forgot to mention I have reviewed on this patch: Reviewed-by: Jérôme Pouiller <jerome.pouiller@silabs.com> > --- > drivers/staging/wfx/main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/wfx/main.c b/drivers/staging/wfx/main.c > index d832a22850c7..5999e81dc44d 100644 > --- a/drivers/staging/wfx/main.c > +++ b/drivers/staging/wfx/main.c > @@ -381,6 +381,7 @@ int wfx_probe(struct wfx_dev *wdev) > } > > if (wdev->hw_caps.region_sel_mode) { > + wdev->hw->wiphy->regulatory_flags |= REGULATORY_DISABLE_BEACON_HINTS; > wdev->hw->wiphy->bands[NL80211_BAND_2GHZ]->channels[11].flags |= > IEEE80211_CHAN_NO_IR; > wdev->hw->wiphy->bands[NL80211_BAND_2GHZ]->channels[12].flags |= >
On Fri, Feb 18, 2022 at 11:57:47AM +0100, Jérôme Pouiller wrote: > On Friday 18 February 2022 11:53:58 CET Jerome Pouiller wrote: > > From: Riccardo Ferrazzo <rferrazzo@came.com> > > > > Some variants of the WF200 disallow active scan on channel 12 and 13. > > For these parts, the channels 12 and 13 are marked IEEE80211_CHAN_NO_IR. > > > > However, the beacon hint procedure was removing the flag > > IEEE80211_CHAN_NO_IR from channels where a BSS is discovered. This was > > making subsequent scans to fail because the driver was trying active > > scans on prohibited channels. > > > > Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com> > > I forgot to mention I have reviewed on this patch: > > Reviewed-by: Jérôme Pouiller <jerome.pouiller@silabs.com> Reviwed-by is implied with signed-off-by. But what happened to the signed-off-by from the author of this change? thanks, greg k-h
On Friday 18 February 2022 12:00:54 CET Greg Kroah-Hartman wrote: > On Fri, Feb 18, 2022 at 11:57:47AM +0100, Jérôme Pouiller wrote: > > On Friday 18 February 2022 11:53:58 CET Jerome Pouiller wrote: > > > From: Riccardo Ferrazzo <rferrazzo@came.com> > > > > > > Some variants of the WF200 disallow active scan on channel 12 and 13. > > > For these parts, the channels 12 and 13 are marked IEEE80211_CHAN_NO_IR. > > > > > > However, the beacon hint procedure was removing the flag > > > IEEE80211_CHAN_NO_IR from channels where a BSS is discovered. This was > > > making subsequent scans to fail because the driver was trying active > > > scans on prohibited channels. > > > > > > Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com> > > > > I forgot to mention I have reviewed on this patch: > > > > Reviewed-by: Jérôme Pouiller <jerome.pouiller@silabs.com> > > Reviwed-by is implied with signed-off-by. > > But what happened to the signed-off-by from the author of this change? The author hasn't used format-patch to transmit this patch. Riccardo, can you reply to this mail with the mention "Signed-off-by: Your name <your-mail@dom.com>"? It certifies that you wrote it or otherwise have the right to pass it on as an open-source patch[1]. [1] https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin Thank you,
Hello Riccardo, On Friday 18 February 2022 14:53:35 CET Riccardo Ferrazzo wrote: > > Signed-off-by: Riccardo Ferrazzo <rferrazzo@came.com> > > > Sorry for the footer it is added automatically > Your mail has probably not been received by everyone since you sent it in html[1] (try also to avoid top-posting). Nevertheless, Greg, is it sufficient for you? [1]: https://useplaintext.email/ > On Friday 18 February 2022 12:00:54 CET Greg Kroah-Hartman wrote: > > On Fri, Feb 18, 2022 at 11:57:47AM +0100, Jérôme Pouiller wrote: > > > On Friday 18 February 2022 11:53:58 CET Jerome Pouiller wrote: > > > > From: Riccardo Ferrazzo <rferrazzo@came.com> > > > > > > > > Some variants of the WF200 disallow active scan on channel 12 and 13. > > > > For these parts, the channels 12 and 13 are marked IEEE80211_CHAN_NO_IR. > > > > > > > > However, the beacon hint procedure was removing the flag > > > > IEEE80211_CHAN_NO_IR from channels where a BSS is discovered. This was > > > > making subsequent scans to fail because the driver was trying active > > > > scans on prohibited channels. > > > > > > > > Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com> > > > > > > I forgot to mention I have reviewed on this patch: > > > > > > Reviewed-by: Jérôme Pouiller <jerome.pouiller@silabs.com> > > > > Reviwed-by is implied with signed-off-by. > > > > But what happened to the signed-off-by from the author of this change? > > The author hasn't used format-patch to transmit this patch. > > Riccardo, can you reply to this mail with the mention "Signed-off-by: > Your name <your-mail@dom.com>"? It certifies that you wrote it or > otherwise have the right to pass it on as an open-source patch[1]. > > > [1] https://urlsand.esvalabs.com/?u=https%3A%2F%2Fwww.kernel.org%2Fdoc%2Fhtml%2Fv4.17%2Fprocess%2Fsubmitting-patches.html%23sign-your-work-the-developer-s-certificate-of-origin&e=09733f94&h=e09f2efa&f=y&p=n<https://urldefense.com/v3/__https://urlsand.esvalabs.com/?u=https*3A*2F*2Fwww.kernel.org*2Fdoc*2Fhtml*2Fv4.17*2Fprocess*2Fsubmitting-patches.html*23sign-your-work-the-developer-s-certificate-of-origin&e=09733f94&h=e09f2efa&f=y&p=n__;JSUlJSUlJSUl!!N30Cs7Jr!GRgB_JlhZF2XzaDEB1ZDnSbLiMmD8XdrmC_uqyLoczR5e05vvMlDCgyKlEu3XyI3PdJK$> > > Thank you, > > -- > Jérôme Pouiller > > >
>Da: Jérôme Pouiller <jerome.pouiller@silabs.com> >Inviato: venerdì 18 febbraio 2022 15:04 >A: Greg Kroah-Hartman; Riccardo Ferrazzo >Cc: linux-wireless@vger.kernel.org; netdev@vger.kernel.org; Kalle Valo; devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org; David S . Miller >Oggetto: Re: [PATCH] staging: wfx: fix scan with WFM200 and WW regulation > >Hello Riccardo, > > >On Friday 18 February 2022 14:53:35 CET Riccardo Ferrazzo wrote: >> >> Signed-off-by: Riccardo Ferrazzo <rferrazzo@came.com> >> >> >> Sorry for the footer it is added automatically >> > >Your mail has probably not been received by everyone since you sent it >in html[1] (try also to avoid top-posting). > >Nevertheless, Greg, is it sufficient for you? > >[1]: https://urlsand.esvalabs.com/?u=https%3A%2F%2Fuseplaintext.email%2F&e=09733f94&h=1ec5571e&f=y&p=n > >> On Friday 18 February 2022 12:00:54 CET Greg Kroah-Hartman wrote: >> > On Fri, Feb 18, 2022 at 11:57:47AM +0100, Jérôme Pouiller wrote: >> > > On Friday 18 February 2022 11:53:58 CET Jerome Pouiller wrote: >> > > Riccardo Ferrazzo R&D Software Designer rferrazzo@came.com CAME S.p.A. > From: Riccardo Ferrazzo <rferrazzo@came.com> >> > > > >> > > > Some variants of the WF200 disallow active scan on channel 12 and 13. >> > > > For these parts, the channels 12 and 13 are marked IEEE80211_CHAN_NO_IR. >> > > > >> > > > However, the beacon hint procedure was removing the flag >> > > > IEEE80211_CHAN_NO_IR from channels where a BSS is discovered. This was >> > > > making subsequent scans to fail because the driver was trying active >> > > > scans on prohibited channels. >> > > > >> > > > Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com> >> > > >> > > I forgot to mention I have reviewed on this patch: >> > > >> > > Reviewed-by: Jérôme Pouiller <jerome.pouiller@silabs.com> >> > >> > Reviwed-by is implied with signed-off-by. >> > >> > But what happened to the signed-off-by from the author of this change? >> >> The author hasn't used format-patch to transmit this patch. >> >> Riccardo, can you reply to this mail with the mention "Signed-off-by: >> Your name <your-mail@dom.com>"? It certifies that you wrote it or >> otherwise have the right to pass it on as an open-source patch[1]. >> >> >> [1] https://urlsand.esvalabs.com/?u=https%3A%2F%2Fwww.kernel.org%2Fdoc%2Fhtml%2Fv4.17%2Fprocess%2Fsubmitting-patches.html%23sign-your-work-the-developer-s-certificate-of-origin&e=09733f94&h=e09f2efa&f=y&p=n<https://urldefense.com/v3/__https://urlsand.esvalabs.com/?u=https*3A*2F*2Fwww.kernel.org*2Fdoc*2Fhtml*2Fv4.17*2Fprocess*2Fsubmitting-patches.html*23sign-your-work-the-developer-s-certificate-of-origin&e=09733f94&h=e09f2efa&f=y&p=n__;JSUlJSUlJSUl!!N30Cs7Jr!GRgB_JlhZF2XzaDEB1ZDnSbLiMmD8XdrmC_uqyLoczR5e05vvMlDCgyKlEu3XyI3PdJK$> >> >> Thank you, >> >> -- >> Jérôme Pouiller >> >> >> > >-- >Jérôme Pouiller Might look better now Signed-off-by: Riccardo Ferrazzo <rferrazzo@came.com>
diff --git a/drivers/staging/wfx/main.c b/drivers/staging/wfx/main.c index d832a22850c7..5999e81dc44d 100644 --- a/drivers/staging/wfx/main.c +++ b/drivers/staging/wfx/main.c @@ -381,6 +381,7 @@ int wfx_probe(struct wfx_dev *wdev) } if (wdev->hw_caps.region_sel_mode) { + wdev->hw->wiphy->regulatory_flags |= REGULATORY_DISABLE_BEACON_HINTS; wdev->hw->wiphy->bands[NL80211_BAND_2GHZ]->channels[11].flags |= IEEE80211_CHAN_NO_IR; wdev->hw->wiphy->bands[NL80211_BAND_2GHZ]->channels[12].flags |=