diff mbox series

riscv: fix nommu_k210_sdcard_defconfig

Message ID 20220209035623.243675-1-damien.lemoal@opensource.wdc.com (mailing list archive)
State New, archived
Headers show
Series riscv: fix nommu_k210_sdcard_defconfig | expand

Commit Message

Damien Le Moal Feb. 9, 2022, 3:56 a.m. UTC
Instead of an arbitrary delay, use the "rootwait" kernel option to wait
for the mmc root device to be ready.

Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
 arch/riscv/configs/nommu_k210_sdcard_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Anup Patel Feb. 9, 2022, 4:02 a.m. UTC | #1
On Wed, Feb 9, 2022 at 9:26 AM Damien Le Moal
<damien.lemoal@opensource.wdc.com> wrote:
>
> Instead of an arbitrary delay, use the "rootwait" kernel option to wait
> for the mmc root device to be ready.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

Looks good to me.

Reviewed-by: Anup Patel <anup@brainfault.org>

Regards,
Anup

> ---
>  arch/riscv/configs/nommu_k210_sdcard_defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/configs/nommu_k210_sdcard_defconfig b/arch/riscv/configs/nommu_k210_sdcard_defconfig
> index 2a82a3b2992b..af64b95e88cc 100644
> --- a/arch/riscv/configs/nommu_k210_sdcard_defconfig
> +++ b/arch/riscv/configs/nommu_k210_sdcard_defconfig
> @@ -23,7 +23,7 @@ CONFIG_SLOB=y
>  CONFIG_SOC_CANAAN=y
>  CONFIG_SMP=y
>  CONFIG_NR_CPUS=2
> -CONFIG_CMDLINE="earlycon console=ttySIF0 rootdelay=2 root=/dev/mmcblk0p1 ro"
> +CONFIG_CMDLINE="earlycon console=ttySIF0 root=/dev/mmcblk0p1 rootwait ro"
>  CONFIG_CMDLINE_FORCE=y
>  # CONFIG_SECCOMP is not set
>  # CONFIG_STACKPROTECTOR is not set
> --
> 2.34.1
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
Palmer Dabbelt Feb. 25, 2022, 3:57 a.m. UTC | #2
On Tue, 08 Feb 2022 19:56:23 PST (-0800), damien.lemoal@opensource.wdc.com wrote:
> Instead of an arbitrary delay, use the "rootwait" kernel option to wait
> for the mmc root device to be ready.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> ---
>  arch/riscv/configs/nommu_k210_sdcard_defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/configs/nommu_k210_sdcard_defconfig b/arch/riscv/configs/nommu_k210_sdcard_defconfig
> index 2a82a3b2992b..af64b95e88cc 100644
> --- a/arch/riscv/configs/nommu_k210_sdcard_defconfig
> +++ b/arch/riscv/configs/nommu_k210_sdcard_defconfig
> @@ -23,7 +23,7 @@ CONFIG_SLOB=y
>  CONFIG_SOC_CANAAN=y
>  CONFIG_SMP=y
>  CONFIG_NR_CPUS=2
> -CONFIG_CMDLINE="earlycon console=ttySIF0 rootdelay=2 root=/dev/mmcblk0p1 ro"
> +CONFIG_CMDLINE="earlycon console=ttySIF0 root=/dev/mmcblk0p1 rootwait ro"
>  CONFIG_CMDLINE_FORCE=y
>  # CONFIG_SECCOMP is not set
>  # CONFIG_STACKPROTECTOR is not set
> -- 
> 2.34.1

Thanks, this is on fixes.
diff mbox series

Patch

diff --git a/arch/riscv/configs/nommu_k210_sdcard_defconfig b/arch/riscv/configs/nommu_k210_sdcard_defconfig
index 2a82a3b2992b..af64b95e88cc 100644
--- a/arch/riscv/configs/nommu_k210_sdcard_defconfig
+++ b/arch/riscv/configs/nommu_k210_sdcard_defconfig
@@ -23,7 +23,7 @@  CONFIG_SLOB=y
 CONFIG_SOC_CANAAN=y
 CONFIG_SMP=y
 CONFIG_NR_CPUS=2
-CONFIG_CMDLINE="earlycon console=ttySIF0 rootdelay=2 root=/dev/mmcblk0p1 ro"
+CONFIG_CMDLINE="earlycon console=ttySIF0 root=/dev/mmcblk0p1 rootwait ro"
 CONFIG_CMDLINE_FORCE=y
 # CONFIG_SECCOMP is not set
 # CONFIG_STACKPROTECTOR is not set